View Issue Details

This bug affects 1 person(s).
 14
IDProjectCategoryView StatusLast Update
11849Bug reportsSurvey takingpublic2016-11-18 12:53
ReporterDenisChenu Assigned Tomarkusfluer 
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.55.x 
Fixed in Version2.55.x 
Summary11849: Numeric valid item with , show as error
Description

Whan entering a valid number : exemple 8,9 with radix to , : javascript show error

Steps To Reproduce

Import included survey and test . Same survey is OK in 2.06

Additional Information

In 2.06 : LEMis_numeric function receive corrected value (8.9), in 2.55 : receive 8,9 value.

Quick solution : fix value in LEMis_numeric BUT : there are surely other function where it can break in same situation

TagsNo tags attached.
Attached Files
Bug heat14
Complete LimeSurvey version number (& build)20161031
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionn

Relationships

has duplicate 11920 closedc_schmitz Decimal input with in "numerical input" and "multiple numerical input" questions always produce error message 
related to 11732 closedDenisChenu Slider reset don't reset to default position 

Users monitoring this issue

jelo

Activities

DenisChenu

DenisChenu

2016-10-31 19:18

developer   ~41623

2nd screenshot with 2.06 : @markusfluer : i put it to you (else @olle think it's a reminder for myself) beacuse if i remind you add the Decimal system

DenisChenu

DenisChenu

2016-11-09 14:18

developer   ~41816

PS :

In 2.50 too :

LEMval function,
if (typeof attr.onlynum !== 'undefined' && attr.onlynum==1) {
....
if (LEMradix === ',') {
newval = value.split(',').join('.');
}

Think we must return the 'real' number value : all other function wait real number (sum, is_numeric etc ....)

markusfluer

markusfluer

2016-11-16 09:54

administrator   ~41975

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=21427

DenisChenu

DenisChenu

2016-11-17 10:57

developer   ~42019

Last edited: 2016-11-17 10:57

Sill an issue :

QCODE.NAOK return empty string even if it's OK.
I review the lss test and send 2 screenshot

DenisChenu

DenisChenu

2016-11-17 11:06

developer   ~42021

Last edited: 2016-11-17 11:07

See Capture du 2016-11-17 11-04-19.png ( with the new lss)

Set major : all "," survey are broken.

markusfluer

markusfluer

2016-11-17 12:44

administrator   ~42026

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=21452

markusfluer

markusfluer

2016-11-17 12:45

administrator   ~42027

I think it is fixed now, i had to touch is_numeric and _sum.

But it works again

DenisChenu

DenisChenu

2016-11-17 15:24

developer   ~42031

@markusfluer : maybe this part work now, but i think you must review : actually seeing your comment : sum and is_numeric is fixed.

BUT : what for sin ? sqrt ? number_format . etc .... or '1,2' > 1 result ?

Again : before using Decimal.js : we always use dot internally. And send comma only for view.

We have the same issue with date before, until aestu make decision : always use 'Y-m-d H:i:s' internally for date compare.

c_schmitz

c_schmitz

2016-11-18 12:53

administrator   ~42058

Version 2.56.1 released

Related Changesets

LimeSurvey: master 49aff574

2016-11-16 09:54:16

markusfluer

Details Diff
Fixed issue 11849: Numeric valid item with , show as error Affected Issues
11849
mod - application/controllers/admin/questions.php Diff File
mod - scripts/expressions/em_javascript.js Diff File
mod - scripts/survey_runtime.js Diff File

LimeSurvey: master eb806fc1

2016-11-17 12:43:51

markusfluer

Details Diff
Fixed issue 11849: the em now works with ',' as well as with '.' Affected Issues
11849
mod - scripts/expressions/em_javascript.js Diff File
mod - scripts/survey_runtime.js Diff File

Issue History

Date Modified Username Field Change
2016-10-31 19:17 DenisChenu New Issue
2016-10-31 19:17 DenisChenu File Added: limesurvey_survey_multiNum.lss
2016-10-31 19:17 DenisChenu File Added: Capture du 2016-10-31 19-07-09.png
2016-10-31 19:17 DenisChenu File Added: Capture du 2016-10-31 19-08-09.png
2016-10-31 19:18 DenisChenu Note Added: 41623
2016-10-31 19:18 DenisChenu Assigned To => markusfluer
2016-10-31 19:18 DenisChenu Status new => assigned
2016-11-09 14:18 DenisChenu Note Added: 41816
2016-11-10 12:26 jelo Issue Monitored: jelo
2016-11-14 11:43 DenisChenu Relationship added related to 11732
2016-11-16 09:54 markusfluer Changeset attached => LimeSurvey master 49aff574
2016-11-16 09:54 markusfluer Note Added: 41975
2016-11-16 09:54 markusfluer Resolution open => fixed
2016-11-17 10:33 c_schmitz Relationship added has duplicate 11920
2016-11-17 10:33 markusfluer Status assigned => resolved
2016-11-17 10:33 markusfluer Fixed in Version => 2.55.x
2016-11-17 10:57 DenisChenu Status resolved => feedback
2016-11-17 10:57 DenisChenu Resolution fixed => reopened
2016-11-17 10:57 DenisChenu Note Added: 42019
2016-11-17 10:57 DenisChenu Note Edited: 42019
2016-11-17 11:05 DenisChenu File Added: limesurvey_survey_NumComma.lss
2016-11-17 11:05 DenisChenu File Added: Capture du 2016-11-17 11-04-04.png
2016-11-17 11:05 DenisChenu File Added: Capture du 2016-11-17 11-04-19.png
2016-11-17 11:06 DenisChenu Note Added: 42021
2016-11-17 11:06 DenisChenu Status feedback => assigned
2016-11-17 11:06 DenisChenu Severity minor => partial_block
2016-11-17 11:07 DenisChenu Note Edited: 42021
2016-11-17 12:44 markusfluer Changeset attached => LimeSurvey master eb806fc1
2016-11-17 12:44 markusfluer Note Added: 42026
2016-11-17 12:45 markusfluer Note Added: 42027
2016-11-17 13:05 markusfluer Status assigned => resolved
2016-11-17 13:05 markusfluer Resolution reopened => fixed
2016-11-17 15:24 DenisChenu Note Added: 42031
2016-11-18 12:53 c_schmitz Note Added: 42058
2016-11-18 12:53 c_schmitz Status resolved => closed