View Issue Details

IDProjectCategoryView StatusLast Update
11432Feature requests[All Projects] Pluginspublic2019-09-07 13:30
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityfeature 
Status closedResolutionduplicate 
Product Version 
Target VersionFixed in Versiondevelop 
Summary11432: Allow plugin to add (or update) REPLACEMENT
Description

Seems there are a lot of feature wher user want 'this' in replacement,: replacing or updating.
examples :

Some are cloase because we add it in core. I think have a solution in EM or in globals helper for this can be really great

Additional Information

Global helpers : must add an event at end of replacement_helper : somethging here : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/replacements_helper.php#L729

But with this solution : we can add QuestionCode.help (for example : i know there are a feature request for this).
(i don't think we can add QuestionCode.help)

or something likle this : QuestionCode.medium / QuestionCode.count
See https://framagit.org/SondagePro-LimeSurvey-plugin/getStatInSurvey/tree/master#documentation

But : add an system like this in EM can break a lot of things ....

TagsNo tags attached.

Relationships

related to 10260 new Feature requests customizable privacy message 
related to 11716 closedLouisGac Feature requests Number of Questiongroups 
related to 09649 new Feature requests Plugin event : update "default core string" 
related to 11424 new Feature requests ADMINNAME and ADMINEMAIL as token fields 
related to 10983 closedDenisChenu Feature requests Create a placeholder for {SID} in the invitation email 
related to 11519 closedDenisChenu Feature requests make fields Anonyous and ip address in Expression Manager available 
related to 11783 closedDenisChenu Development  SUBMITBUTTON SUBMITCOMPLETE SUBMITREVIEW can we remove it ? 

Activities

DenisChenu

DenisChenu

2016-08-10 10:52

developer   ~40223

One more again : https://bugs.limesurvey.org/view.php?id=11519

This is from survey part : then can be in global replacement.

DenisChenu

DenisChenu

2016-09-28 08:04

developer   ~40996

See : https://github.com/LimeSurvey/LimeSurvey/pull/545 one more again

DenisChenu

DenisChenu

2016-10-02 19:27

developer   ~41055

Again one : https://www.limesurvey.org/forum/design-issues/107171-editing-registration-variables#142501

DenisChenu

DenisChenu

2016-10-11 23:27

developer   ~41240

See https://bugs.limesurvey.org/view.php?id=11783 for a reason why i don't like new {REPLACEMENT} system.

In X month : we don't know what is it, where it's uses, how it's used.
A plugin have own clear documentation

DenisChenu

DenisChenu

2017-07-04 17:41

developer   ~44047

Another solution : i EM

I think it's great if we can extend 'replacement' part : replace or add new KEYWORD
(i attach related bug some minute after)

But we try to remove event , then it's seems the best way is just to add :

  1. A public function setKnowVar($var as string, $value=null as string|null)
  2. Add it in LimesurveyApi

This fix partially, but after : we can have

  1. Add a var in EM
  2. Another system for another purpose (or same)

Still the issue with existing knowVars
Easys
If $var didn't exist : create it in readWrite->N mode (https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/helpers/expressions/em_manager_helper.php#L3642)
If $var exist and is a "fixed var" : update code

if $var exist and is a dynamic var ( answer in fact) allow updating the actual value ? In DB + in $_SESSION ?

DenisChenu

DenisChenu

2019-09-07 13:30

developer   ~53524

https://github.com/LimeSurvey/LimeSurvey/tree/develop/plugins/expressionFixedDbVar

Issue History

Date Modified Username Field Change
2016-07-06 17:06 DenisChenu New Issue
2016-07-06 17:06 DenisChenu Relationship added related to 11424
2016-07-06 17:06 DenisChenu Relationship added related to 10983
2016-07-29 17:10 DenisChenu Relationship added related to 10260
2016-08-10 10:51 DenisChenu Relationship added related to 11519
2016-08-10 10:52 DenisChenu Note Added: 40223
2016-09-28 08:04 DenisChenu Note Added: 40996
2016-09-28 08:26 DenisChenu Relationship added related to 11716
2016-10-02 19:27 DenisChenu Note Added: 41055
2016-10-11 23:26 DenisChenu Relationship added related to 11783
2016-10-11 23:27 DenisChenu Note Added: 41240
2016-11-14 11:58 DenisChenu Relationship added related to 09649
2017-07-04 17:39 DenisChenu Relationship added related to 12514
2017-07-04 17:39 DenisChenu Relationship replaced has duplicate 12514
2017-07-04 17:41 DenisChenu Note Added: 44047
2019-09-07 11:02 DenisChenu Relationship deleted has duplicate 12514
2019-09-07 13:30 DenisChenu Assigned To => DenisChenu
2019-09-07 13:30 DenisChenu Status new => closed
2019-09-07 13:30 DenisChenu Resolution open => duplicate
2019-09-07 13:30 DenisChenu Fixed in Version => develop
2019-09-07 13:30 DenisChenu Note Added: 53524