View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
10389Bug reportsSurvey takingpublic2016-02-23 08:51
Reporterhalliballi123 Assigned ToLouisGac 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Summary10389: Validation Messages in public survey are not really informative
Description

I have loads of fields in one group and I show group by group.
Now there I can not navigate to next group because one value in a field does not fit to the validation. The dialog/alert that is shown just says that there is some input that is not valid and I have to fix it.

But neither the field is highlighted or some how marked nor does it say which validation is the problem, like number lower than minvalue or number higher than maxvalue

TagsNo tags attached.
Attached Files
Bug heat8
Complete LimeSurvey version number (& build)160206
I will donate to the project if issue is resolvedNo
Browserfirefox 38
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

related to 09106 feedback Add some 'error' in tite and list error before showing question 
related to 10388 closedLouisGac Can not disable showing hints in survey 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-02-11 13:32

developer   ~34900

lss file please ?

halliballi123

halliballi123

2016-02-11 15:03

reporter   ~34906

sorry can not provide our survey but it is only for closed user group.
But it is easy to reproduce. just add some questions with e.g. numbers type and set min and max values. (you can create one question and then copy it multiple times)
then start survey and enter invalid values.

if there are many fields, it takes some while to find out which value is causing the problem.

halliballi123

halliballi123

2016-02-11 15:04

reporter   ~34907

added example .lss

halliballi123

halliballi123

2016-02-11 15:09

reporter   ~34908

in my opinion it should be quite easy to show which question causes the problem and what causes the problem. you must know at validation time which question you are validating and which rule you are valdating.

All the questions have their id in html source so you just need to select the question and e.g. highlight the input field or the label or something like that. and in the error alert you can show which rules are violated like e.g. input value is less than min value

DenisChenu

DenisChenu

2016-02-11 15:11

developer   ~34909

You're right : template issue :
Not compatible SkeletonQuest template : http://limesurvey.sondages.pro/index.php/survey/index/sid/245494/newtest/Y
New template : http://limesurvey.sondages.pro/index.php/232512?newtest=Y

halliballi123

halliballi123

2016-02-11 15:34

reporter   ~34913

Does this mean that I used some invalid template?
I think I used the default template.

DenisChenu

DenisChenu

2016-02-11 15:57

developer   ~34919

No : it means the default included template need fix.

LouisGac

LouisGac

2016-02-11 16:01

developer   ~34921

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17336

LouisGac

LouisGac

2016-02-11 16:04

developer   ~34922

that's a quick fix. It could still be done in a better way in the future.
by the way, em-manager should raise much more events in general.

DenisChenu

DenisChenu

2016-02-11 16:31

developer   ~34925

.trigger('classChangeError') can be used : but actually : no em for mandatory ....

DenisChenu

DenisChenu

2016-02-11 17:44

developer   ~34935

@LouisGac : https://github.com/Shnoulle/LimeSurvey-shnoulle/tree/206_EM_jquery_event .

Added relevanceOn relevanceOff event .

halliballi123

halliballi123

2016-02-12 07:39

reporter   ~34971

thank you, problem is fixed

halliballi123

halliballi123

2016-02-12 08:01

reporter   ~34972

by the way, how did you get the skeletonQuest Template working? I can't import it into the 2.5+ Version. Or I can but it does not work, folder structure under /upload/templates does look different.

DenisChenu

DenisChenu

2016-02-22 09:57

developer   ~35500

@halliballi123 : i send it in FTP (in real via git clone ....)

c_schmitz

c_schmitz

2016-02-23 08:51

administrator   ~35572

Version 2.50+ Build 160222 released

Related Changesets

LimeSurvey: master 3a51ac63

2016-02-11 14:58:40

LouisGac

Details Diff
Fixed issue 10389: animate emtip changes Affected Issues
10389
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - templates/default/css/template.css Diff File
mod - templates/default/scripts/template.js Diff File
mod - templates/news_paper/css/template.css Diff File
mod - templates/news_paper/scripts/template.js Diff File
mod - templates/ubuntu_orange/css/template.css Diff File
mod - templates/ubuntu_orange/scripts/template.js Diff File

Issue History

Date Modified Username Field Change
2016-02-11 13:17 halliballi123 New Issue
2016-02-11 13:32 DenisChenu Note Added: 34900
2016-02-11 13:32 DenisChenu Relationship added related to 09106
2016-02-11 13:33 DenisChenu Summary Validation Messages are not really informative => Validation Messages in public survey are not really informative
2016-02-11 15:03 halliballi123 Note Added: 34906
2016-02-11 15:03 halliballi123 File Added: limesurvey_survey_232512.lss
2016-02-11 15:04 halliballi123 Note Added: 34907
2016-02-11 15:09 halliballi123 Note Added: 34908
2016-02-11 15:10 DenisChenu Assigned To => LouisGac
2016-02-11 15:10 DenisChenu Status new => assigned
2016-02-11 15:11 DenisChenu Note Added: 34909
2016-02-11 15:12 DenisChenu Relationship added related to 10388
2016-02-11 15:34 halliballi123 Note Added: 34913
2016-02-11 15:57 DenisChenu Note Added: 34919
2016-02-11 16:01 LouisGac Changeset attached => LimeSurvey master 3a51ac63
2016-02-11 16:01 LouisGac Note Added: 34921
2016-02-11 16:01 LouisGac Resolution open => fixed
2016-02-11 16:04 LouisGac Note Added: 34922
2016-02-11 16:16 LouisGac Status assigned => feedback
2016-02-11 16:31 DenisChenu Note Added: 34925
2016-02-11 17:44 DenisChenu Note Added: 34935
2016-02-12 07:39 halliballi123 Note Added: 34971
2016-02-12 07:39 halliballi123 Status feedback => assigned
2016-02-12 08:01 halliballi123 Note Added: 34972
2016-02-22 09:51 LouisGac Status assigned => resolved
2016-02-22 09:57 DenisChenu Note Added: 35500
2016-02-23 08:51 c_schmitz Note Added: 35572
2016-02-23 08:51 c_schmitz Status resolved => closed