View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
10079Bug reportsTheme editorpublic2016-02-02 14:57
ReporterDenisChenu Assigned ToLouisGac 
PrioritynormalSeverityminor 
Status closedResolutionwon't fix 
Product Version2.50.x 
Summary10079: Without javascript there are still present button that don't work in the survey : back, clear the survey, send it incomplete.
Description

Same bug than https://bugs.limesurvey.org/view.php?id=7967

Steps To Reproduce

Test a survey, default template, deactivate javascript in your browser and try:

  • Reset survey
  • Load survey
  • Index jumping
Additional Information

All this fixed in 2.06 actually and work without JS

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)151207
I will donate to the project if issue is resolvedNo
Browserfirefox
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

parent of 10087 closedLouisGac User stats page have invalid link 
related to 10085 closedLouisGac New index don't work actually 
child of 07967 closedc_schmitz Without javascript there are still present button that don't work in the survey : back, clear the survey, send it incomplete. 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2015-12-07 21:36

administrator   ~33724

As we previously said, we will not put any effort into making it compatible to non-JS users (which is around 1% of users or less).

DenisChenu

DenisChenu

2015-12-08 09:04

developer   ~33725

Last edited: 2015-12-08 09:08

I really don't understand .... it work before, and actually it's a regression ...

We have all system to have a working solution, why remove something this.

And actually : it's only a CSS issue :
{SAVE} : have .hidden class : why ? Just hide it in javascript in template. It must be hidden by template , not by core. (ANd why the col-xs-4 class too).
{CLEARALL} : have class col-xs-4 hidden : why force xs-4 and hidden.

Just remove this class from core and add it just for default template if you need/want it.

Template can update it, but it's a bad way to do....

PS:
For QUESTION_INDEX : this need to be completly reworked.

c_schmitz

c_schmitz

2015-12-08 10:01

administrator   ~33731

Dropping an outdated feature is not a regression. We dropped IE6 support at some point too, and it is not a regression.

Denis, if you want to fix this you are welcome to do so.
But we said in the past that we will put no effort into this.

LouisGac

LouisGac

2015-12-08 10:03

developer   ~33732

I can use another class than hidden, and hide them with CSS in my template. So if you want to build a template with those buttons, it will be possible.

c_schmitz

c_schmitz

2015-12-08 10:05

administrator   ~33734

Ok, Louis, please do.

DenisChenu

DenisChenu

2015-12-08 10:08

developer   ~33735

Last edited: 2015-12-08 10:21

SAVE and CLEARALL can be rewamped in template, OK (stille strange the xs-4 .... why this one ?).

For QUESTION_INDEX : i'm unsure for accessibility actually. Before it can be used :

  • In any browser
  • By blind user
  • With phone etc ....

You do a submit, an action : you don't go elsewhere.

Submit/action => input or button
Go elsewhere : a link

PS:
1 : modernizer still use no-js class : https://modernizr.com/docs#no-js
2 : mdo : "Strive to maintain HTML standards and semantic" : i really think an action must be in input or button.

DenisChenu

DenisChenu

2015-12-09 08:53

developer   ~33773

PS: if we have a "core replacement update" plugin event then this can be done in plugin.
{SAVE} - {CLEARALL} - {QUESTION_INDEX} can be done in HTML without javascript. Then add an event fix the issue (i ok to do and manage the plugin)

LouisGac

LouisGac

2015-12-09 09:55

developer   ~33777

I'm more thinking about simple CSS classes to hide/display part of the HTML.

DenisChenu

DenisChenu

2015-12-09 10:54

developer   ~33787

Then attention to index : it's action button in 2.06, not link like in 2.0.

And this unsure control of CRSF moire easily (even if you do a
$("a.indexLinbk").click(function(){
"button[value"+(this).data("submit-button")."]").click();
});
for example.

LouisGac

LouisGac

2015-12-23 11:28

developer   ~34092

https://github.com/LimeSurvey/LimeSurvey/commit/9bd256db795caa08829816656fc270d6d0497ed8

LouisGac

LouisGac

2015-12-23 11:30

developer   ~34093

So : I put back the old index, which is just hidden via js in the new bootstrap template. So, the old template should be able to use the index as before.

To display the index as a menu in bootstrap, there is a new position called "questionindexmenu".

c_schmitz

c_schmitz

2016-01-08 15:36

administrator   ~34200

Version 2.5RC6 released

DenisChenu

DenisChenu

2016-02-02 12:12

developer   ~34470

Just to move to not fixed : Last GIT version show the top link but not real button without JS.

LouisGac

LouisGac

2016-02-02 12:43

developer   ~34473

Well, the surveys can't work without javascript, so there is no point to give the possibility to use those buttons without javascript...

DenisChenu

DenisChenu

2016-02-02 14:57

developer   ~34476

Some survey CAN work without javascript.

Issue History

Date Modified Username Field Change
2015-12-07 09:12 DenisChenu New Issue
2015-12-07 09:13 DenisChenu Relationship added child of 07967
2015-12-07 21:36 c_schmitz Note Added: 33724
2015-12-07 21:36 c_schmitz Status new => closed
2015-12-07 21:36 c_schmitz Assigned To => c_schmitz
2015-12-07 21:36 c_schmitz Resolution open => won't fix
2015-12-08 09:04 DenisChenu Note Added: 33725
2015-12-08 09:04 DenisChenu Status closed => feedback
2015-12-08 09:04 DenisChenu Resolution won't fix => reopened
2015-12-08 09:08 DenisChenu Note Edited: 33725
2015-12-08 10:01 c_schmitz Note Added: 33731
2015-12-08 10:03 LouisGac Note Added: 33732
2015-12-08 10:05 c_schmitz Note Added: 33734
2015-12-08 10:08 DenisChenu Note Added: 33735
2015-12-08 10:08 DenisChenu Status feedback => assigned
2015-12-08 10:21 DenisChenu Note Edited: 33735
2015-12-08 11:18 DenisChenu Relationship added related to 10085
2015-12-08 11:28 DenisChenu Relationship added parent of 10087
2015-12-09 08:53 DenisChenu Note Added: 33773
2015-12-09 09:55 LouisGac Note Added: 33777
2015-12-09 10:54 DenisChenu Note Added: 33787
2015-12-09 11:32 c_schmitz Assigned To c_schmitz => LouisGac
2015-12-11 14:40 c_schmitz Category Templates => Theme editor
2015-12-23 11:28 LouisGac Note Added: 34092
2015-12-23 11:28 LouisGac Status assigned => resolved
2015-12-23 11:28 LouisGac Resolution reopened => fixed
2015-12-23 11:30 LouisGac Note Added: 34093
2016-01-08 15:36 c_schmitz Note Added: 34200
2016-01-08 15:36 c_schmitz Status resolved => closed
2016-02-02 12:12 DenisChenu Note Added: 34470
2016-02-02 12:12 DenisChenu Status closed => feedback
2016-02-02 12:12 DenisChenu Resolution fixed => reopened
2016-02-02 12:12 DenisChenu Status feedback => closed
2016-02-02 12:12 DenisChenu Resolution reopened => won't fix
2016-02-02 12:43 LouisGac Note Added: 34473
2016-02-02 12:43 LouisGac Status closed => feedback
2016-02-02 12:43 LouisGac Resolution won't fix => reopened
2016-02-02 12:43 LouisGac Status feedback => closed
2016-02-02 12:43 LouisGac Resolution reopened => fixed
2016-02-02 14:57 DenisChenu Note Added: 34476
2016-02-02 14:57 DenisChenu Status closed => feedback
2016-02-02 14:57 DenisChenu Resolution fixed => reopened
2016-02-02 14:57 DenisChenu Status feedback => closed
2016-02-02 14:57 DenisChenu Resolution reopened => won't fix