Changesets: LimeSurvey

master 3dbba5b8

2020-08-13 14:08:57

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16483: Adding condition triggers bulk update for complete database (#1542)

Dev: UpgradeConditionsToRelevance receives two params: surveyId and qid. If the qid is specified, it should only update that question (as per the function doc). But, if surveyId is null, it loops trough all the surveys, which only makes sense if no qid is specified.
Affected Issues
16483
mod - application/helpers/expressions/em_manager_helper.php Diff File

master 9aec0b63

2020-08-12 17:57:28

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16326: Statistics filters do not reflect percentages and totals (#1531) Affected Issues
16326
mod - application/helpers/admin/statistics_helper.php Diff File

master e6a4bb4d

2020-08-12 17:55:38

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16206: Slider tip indicates false error (#1508)

Dev: Added extra validation for situations where value got NaN
Affected Issues
16206
mod - assets/packages/questions/numeric-slider/scripts/numeric-slider.js Diff File

master 16425fff

2020-08-12 17:50:51

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16566: We cannot create multiple choice questions (#1543)

Dev: Before issue 16469, QuestionEditorController tried to find the questions using 'findByPk', which automatically casts the value to int. Now, 'find' is used because the survey ID, as the search is done by multiple criterias.
Dev: When saving a new question, 'qid' is an empty string, and the resulting SQL fails in Postgres because of the data type. Solved by casting 'qid' to int.
Dev: This also helps with issue 16563.
Dev: Casting subquestion id as to remove the random characters vue id adds for its view.
Affected Issues
16469, 16563, 16566
mod - application/controllers/QuestionEditorController.php Diff File

master b2c63ba5

2020-08-12 17:48:11

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 15864: When deleting a question at LS 4 the system switches to the "Settings" menu (#1544)

Dev: The 'delete' method now supports the 'redirectTo' parameter: to question list or group overview. Depending on that, the sidebar is set as well
Affected Issues
15864
mod - application/controllers/admin/questions.php Diff File
mod - application/controllers/admin/surveyadmin.php Diff File
mod - application/views/admin/survey/topbar/question_topbar.php Diff File

master 257d2447

2020-08-12 17:42:21

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16335: Cannot see more label sets if the list is long (#1548) Affected Issues
16335
mod - assets/packages/questioneditor/build.min/css/main.css Diff File
mod - assets/packages/questioneditor/build.min/js/questionedit.js Diff File
mod - assets/packages/questioneditor/build.min/js/questionedit.js.map Diff File
mod - assets/packages/questioneditor/build/js/questionedit.js Diff File
mod - assets/packages/questioneditor/build/js/questionedit.js.map Diff File
mod - assets/packages/questioneditor/src/helperComponents/Autocomplete.vue Diff File

3.x-LTS 9830b32b

2020-08-12 11:08:49

pstelling

Details Diff
Release 3.23.0+200813
Attach Issues:
mod - application/config/version.php Diff File
mod - docs/release_notes.txt Diff File

master e2876dc0

2020-08-12 10:05:20

pstelling

Details Diff
Release 4.3.10+200812
Attach Issues:
mod - application/config/version.php Diff File
mod - docs/release_notes.txt Diff File

master 67db44ac

2020-08-10 19:01:01

gabrieljenik

Details Diff
Fixed answer 16441: Problem in field type = List (Dropdown),

The language attributes for the answer options were not retrieved.
Merged the answer attributes with the corresponding answerl10ns attributes in getQuestionArray (SurveyDynamic.php).
Affected Issues
16441
mod - application/models/SurveyDynamic.php Diff File

master a520ff1a

2020-08-10 15:45:30

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16269: "Start bounce processing" menu item doesn't work (#1533)

Validation is inverted, so it considers the bounce processing is disabled when it's not.
Affected Issues
16269
mod - application/views/admin/survey/topbar/token_bar.php Diff File

3.x-LTS f35f77b0

2020-08-10 15:45:05

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16273 - Validation regex including unicode characters fails (#1499)

Decoding html before running regex. This (a decode string) is similar to what the PHP side regex function gets.
Affected Issues
16273
mod - assets/scripts/expressions/em_javascript.js Diff File

master b46da279

2020-08-10 15:44:44

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16531: Validation regex including unicode characters fails (#1521)

Decoding html before running regex. This (a decode string) is similar to what the PHP side regex function gets.
Affected Issues
16531
mod - assets/packages/expressions/em_javascript.js Diff File

3.x-LTS 0285abf8

2020-08-10 15:44:09

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 14218: hover OK button on confirm hide the OK (#1540)

Reviewed CSS for hover on btn-danger
Affected Issues
14218
mod - themes/survey/fruity/css/variations/apple_blossom.css Diff File
mod - themes/survey/fruity/css/variations/bay_of_many.css Diff File
mod - themes/survey/fruity/css/variations/black_pearl.css Diff File
mod - themes/survey/fruity/css/variations/free_magenta.css Diff File
mod - themes/survey/fruity/css/variations/purple_tentacle.css Diff File
mod - themes/survey/fruity/css/variations/sea_green.css Diff File
mod - themes/survey/fruity/css/variations/skyline_blue.css Diff File
mod - themes/survey/fruity/css/variations/sunset_orange.css Diff File

master a380df5e

2020-08-10 15:41:52

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16235: Welcome page show again if cookies are enable and survey is already done (#1538)

newTest param shouldn't be considered for this validation
Affected Issues
16235
mod - application/controllers/survey/index.php Diff File

master 44e977ed

2020-08-10 15:41:14

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16205: Slider left/right text and min/max not displayed correctly (#1509)

The renderer was correctly processing the subquestion text to strip the labels, but ended passing the original subquestion text to the view.
Affected Issues
16205
mod - application/core/QuestionTypes/MultipleNumericalQuestion/RenderMultipleNumerical.php Diff File

master fdd72ede

2020-08-10 15:40:09

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 15939: Update to 4x seems to have changed the Display/Export (#1503)

Adding group order criteria.
Affected Issues
15939
mod - application/controllers/admin/printablesurvey.php Diff File

master 83bbfda5

2020-08-10 15:36:33

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16534: No creation date when importing participants to CPDB (#1529)

Made creation date to be current date
Affected Issues
16534
mod - application/models/Participant.php Diff File

master babbddb1

2020-08-10 15:36:03

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16508: Can't run survey with child theme because of enheritance problems. (#1523)

1- Removed xml comments after loading config.xml.
2 - Had empty nodes to be saved in DB as empty strings.
Affected Issues
16508
mod - application/models/TemplateConfig.php Diff File
mod - application/models/TemplateManifest.php Diff File

3.x-LTS b427d9ed

2020-08-10 15:25:51

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 15951: No creation date when importing participants to CPDB (#1502)

Made creation date to be current date
Affected Issues
15951
mod - application/models/Participant.php Diff File

master 4b0890a2

2020-08-10 15:16:19

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16529: After deleting a user who owned a survey, the survey list generates a dump (#1513)

Added getOwnerUserName in Survey model, and use that ownerUserName property in listSurveys.php.
Affected Issues
16529
mod - application/extensions/admin/survey/ListSurveysWidget/views/listSurveys.php Diff File
mod - application/models/Survey.php Diff File

master be147d53

2020-08-10 15:14:46

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16250: Slider for numeric question display text area (#1512)

Hide the slider options, which were not available on LS3 anyway.
If we want to implement slider for LS3, we could make a new ticket.
Affected Issues
16250
mod - application/views/survey/questions/answer/numerical/config.xml Diff File

master a849e665

2020-08-10 15:13:17

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 15758: Slider settings not saved (#1504)

Setting was saved. It was not shown correctly in the settings. Sending slider_showminmax variable to the view
Affected Issues
15758
mod - application/core/QuestionTypes/MultipleNumericalQuestion/RenderMultipleNumerical.php Diff File

master 1312ef36

2020-08-10 11:38:51

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16550: Answer option code is not limited to 5 characters (#1541) Affected Issues
16550
mod - assets/packages/questioneditor/build.min/css/main.css Diff File
mod - assets/packages/questioneditor/build.min/js/questionedit.js Diff File
mod - assets/packages/questioneditor/build.min/js/questionedit.js.map Diff File
mod - assets/packages/questioneditor/build/js/questionedit.js Diff File
mod - assets/packages/questioneditor/build/js/questionedit.js.map Diff File
mod - assets/packages/questioneditor/src/components/subcomponents/_answeroptions.vue Diff File

master 53d57fbd

2020-08-06 17:29:19

pstelling

Details Diff
Release 4.3.9+200806
Attach Issues:
mod - application/config/version.php Diff File
mod - docs/release_notes.txt Diff File

master 17f0a0d5

2020-08-06 14:08:31

DenisChenu


Committer: GitHub Details Diff
Master ls base controller check params (#1479)

Fixed issue 16469: Any admin user can see any question (without read right on survey)
Fixed issue #16467: Reflected XSS vulnerabilities
Dev: add a function to validate int parameters
Dev: throw 400/403 or 404 error

Dev: remove some uneeded redirect and filter

Dev: Move functionnality to an helper function to call
Dev : getValidateSurveyId return a validated sid related with qid and gid

Dev: rename to getValidatedSurveyId
Dev: getQuestionObject must be reviewed : $sureyId must be a mandatory param

Dev: more details in function doc and fix partially phpDoc

Dev: getValidatedSurveyId get the final sid by param
Dev: review test :
Affected Issues
16467, 16469
mod - application/controllers/LSBaseController.php Diff File
mod - application/controllers/QuestionEditorController.php Diff File
mod - tests/functional/backend/AdminViewsTest.php Diff File
 First  Prev  1 2 3 ... 150 ... 235 236 237 238 239 240 241 ... 300 ... 450 ... 600 ... 750 ... 900 ... 1050 ... 1200 ... 1350 ... 1451 1452 1453  Next  Last