Changesets: LimeSurvey

master 38437afb

2020-08-19 17:03:14

gabrieljenik

Details Diff
Fixed issue 16194: file upload disables other clicks.

Applying same fix as in 16415, now for LSv4
Reverting a change, mimicing a rollback done in chromium
Affected Issues
16194
mod - application/controllers/UploaderController.php Diff File
mod - assets/packages/questions/upload/build/uploadquestion.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js.map Diff File
mod - assets/packages/questions/upload/src/ajaxupload.js Diff File

master e5155535

2020-08-18 20:59:00

gabrieljenik

Details Diff
Fixed issue 16194: file upload disables other clicks.

After loading the upload frame inside the modal, 'relevance:on' event handlers are lost.

Removed the jquery package as it was overstepping all the bindings previously done.

Removes the cache for the currentUploadHandler. This wasn't working for multiple upload question in the same as it was caching it on a window level variable. Removed the cache for simplifiying.

Contains also fix for 16549: Error message is shown while trying to delete and reupload file using File upload
Affected Issues
16194, 16549
mod - application/controllers/UploaderController.php Diff File
mod - assets/packages/questions/upload/build/uploadquestion.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js.map Diff File
mod - assets/packages/questions/upload/src/ajaxupload.js Diff File
mod - assets/packages/questions/upload/src/uploader.js Diff File

master dd0e3673

2020-08-18 20:57:51

gabrieljenik

Details Diff
Revert "Fixed issue 16194: file upload disables other clicks."

This reverts commit e3229069839435b28de88cfcd994be9873d64e78.
Affected Issues
16194
mod - assets/packages/questions/upload/build/uploadquestion.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js.map Diff File
mod - assets/packages/questions/upload/src/ajaxupload.js Diff File
mod - assets/packages/questions/upload/src/modaldialog.js Diff File
mod - assets/packages/questions/upload/src/uploader.js Diff File

master e3229069

2020-08-18 19:00:29

gabrieljenik

Details Diff
Fixed issue 16194: file upload disables other clicks.

After loading the upload frame inside the modal, 'relevance:on' event handlers are lost.
Calling triggerEmRelevance() when closing the modal fixes the issue.

Removes the cache for the currentUploadHandler. This wasn't working for multiple upload question in the same as it was caching it on a window level variable. Removed the cache for simplifiying.

Contains also fix for 16549: Error message is shown while trying to delete and reupload file using File upload
Affected Issues
16194, 16549
mod - assets/packages/questions/upload/build/uploadquestion.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js.map Diff File
mod - assets/packages/questions/upload/src/ajaxupload.js Diff File
mod - assets/packages/questions/upload/src/modaldialog.js Diff File
mod - assets/packages/questions/upload/src/uploader.js Diff File

master be5f29fc

2020-08-18 18:58:13

gabrieljenik

Details Diff
Revert "Fixed issue 16194: file upload disables other clicks."

This reverts commit 09da665557ea5e4b094ff4c4eabb9d821a14b878.
Affected Issues
16194
mod - assets/packages/questions/upload/build/uploadquestion.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js.map Diff File
mod - assets/packages/questions/upload/src/ajaxupload.js Diff File

master 3972733c

2020-08-18 18:43:40

gabrieljenik

Details Diff
Fixed issue 16217: Survey will not show is the "inherit on" is chosen.

Removed "public" scope from Survey model, because it doesn't work with inheritance (DBCriteria can't manage inheritance recurrency). Added a "findAllPublic" method to the model to use in public listing.
Also fixed survey overview.
Affected Issues
16217
mod - application/controllers/SurveysController.php Diff File
mod - application/models/Survey.php Diff File
mod - application/views/admin/survey/subview/surveydashboard/003-publicationpanel.twig Diff File

master 2c59a34c

2020-08-18 18:42:48

gabrieljenik

Details Diff
Revert "Fixed issue 16217: Survey will not show is the "inherit on" is chosen."

This reverts commit fa5801bd6ebc2bf50a163a3c9823daf74963a301.
Affected Issues
16217
mod - application/controllers/SurveysController.php Diff File
mod - application/models/Survey.php Diff File
mod - application/views/admin/survey/subview/surveydashboard/003-publicationpanel.twig Diff File

master 48ab3e2b

2020-08-18 16:39:44

Dietrich Streifert


Committer: GitHub Details Diff
Fixed issue 16083: Cannot edit assessments

Dev: After uncommenting this line editing and deleting assessments works again
Affected Issues
16083
mod - application/views/admin/assessments/assessments_view.php Diff File

master 8286026a

2020-08-18 16:33:45

ollehar1

Details Diff
Dev: Rebuild question editor
Attach Issues:
mod - assets/packages/questioneditor/build.min/js/questionedit.js Diff File
mod - assets/packages/questioneditor/build.min/js/questionedit.js.map Diff File
mod - assets/packages/questioneditor/build/js/questionedit.js Diff File
mod - assets/packages/questioneditor/build/js/questionedit.js.map Diff File
mod - assets/packages/questioneditor/src/helperComponents/LabelSets.vue Diff File

master 3c8df805

2020-08-18 16:33:45

ollehar1

Details Diff
Fix issue 16504: Lable Sets Assessment Value Not Copied to Answer options Affected Issues
16504
mod - assets/packages/questioneditor/build.min/js/questionedit.js Diff File
mod - assets/packages/questioneditor/build.min/js/questionedit.js.map Diff File
mod - assets/packages/questioneditor/build/js/questionedit.js Diff File
mod - assets/packages/questioneditor/build/js/questionedit.js.map Diff File
mod - assets/packages/questioneditor/src/helperComponents/LabelSets.vue Diff File

master 811d14e8

2020-08-18 16:21:52

ollehar1

Details Diff
Dev: Fix correct permission for users batch add group
Attach Issues:
mod - application/controllers/UserManagementController.php Diff File

master 2819688c

2020-08-18 16:14:40

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16507: Mass permissions are not being saved (#1546)

Dev: Reworked how custom-data is posted to the controller. Specially on checkboxes (which were always sent as TRUE)
Dev: Reviewed how checkbox are linked: "general" permission for an activity with the "read"/"update"/"delete"/.... checkboxes.
Dev: Reviewed results view
Affected Issues
16507
mod - application/controllers/UserManagementController.php Diff File
mod - application/extensions/admin/grid/MassiveActionsWidget/assets/listActions.js Diff File
mod - application/views/userManagement/massiveAction/_updatepermissions.php Diff File
mod - assets/packages/usermanagement/js/usermanagement.js Diff File

master 09da6655

2020-08-17 14:37:41

gabrieljenik

Details Diff
Fixed issue 16194: file upload disables other clicks.

After loading the upload frame inside the modal, 'relevance:on' event handlers are lost.
Calling triggerEmRelevance() when closing the modal fixes the issue.

Contains also fix for 16549: Error message is shown while trying to delete and reupload file using File upload
Affected Issues
16194, 16549
mod - assets/packages/questions/upload/build/uploadquestion.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js Diff File
mod - assets/packages/questions/upload/build/uploadquestion.min.js.map Diff File
mod - assets/packages/questions/upload/src/ajaxupload.js Diff File

master 6673343e

2020-08-17 14:04:20

LimeBot

Details Diff
Release 4.3.11+200817
Attach Issues:
mod - application/config/version.php Diff File
mod - docs/release_notes.txt Diff File

master 437c95a6

2020-08-17 13:51:19

LimeSurvey Translations Bot

Details Diff
Updated translation: Danish by pedesjensen, Mikkel, c_schmitz
Attach Issues:
mod - locale/_template/limesurvey.pot Diff File
mod - locale/da/da.mo Diff File

3.x-LTS ce0a51d6

2020-08-17 13:51:07

LimeSurvey Translations Bot

Details Diff
Updated translation: Croatian by rovinj
Updated translation: Italian by albertoberton
Attach Issues:
mod - locale/hr/hr.mo Diff File
mod - locale/it/it.mo Diff File

3.x-LTS 90810b8f

2020-08-14 20:32:04

gabrieljenik

Details Diff
Fixed issue 15980: No results shown for selected date questions at statistics

- Date/Time responses are treated as "Answer" when the value is not null, and "No answer" when it's null.
- Equation questions are handled as text. It seems they always have a value, so "Not displayed" may always be 0.
- Condition had to be updated as to work with dates. It may have an impact on some DB engine (not sure).
Affected Issues
15980
mod - application/helpers/admin/statistics_helper.php Diff File
mod - application/views/admin/export/statistics_subviews/_question.php Diff File

master dd225176

2020-08-14 15:31:57

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 15929: Missing button to scan files at plugin overview at LS4 (#1536) Affected Issues
15929
mod - application/controllers/admin/PluginManagerController.php Diff File
mod - application/views/admin/pluginmanager/scanFilesResult.php Diff File

master b351bc7f

2020-08-14 11:26:41

LimeSurvey Translations Bot

Details Diff
Updated translation: Finnish by Jmantysalo
Updated translation: Croatian by rovinj
Updated translation: Italian by ritapas
Updated translation: Korean by zist21
Updated translation: Dutch by Han
Updated translation: Italian (Informal) by ritapas
Updated translation: Dutch (Informal) by Han
Updated translation: Chinese (Taiwan) (Traditional) by scott306lr
Attach Issues:
mod - locale/_template/limesurvey.pot Diff File
mod - locale/fi/fi.mo Diff File
mod - locale/hr/hr.mo Diff File
mod - locale/it-informal/it-informal.mo Diff File
mod - locale/it/it.mo Diff File
mod - locale/ko/ko.mo Diff File
mod - locale/nl-informal/nl-informal.mo Diff File
mod - locale/nl/nl.mo Diff File
mod - locale/zh-Hant-TW/zh-Hant-TW.mo Diff File

3.x-LTS a8730901

2020-08-14 11:26:17

LimeSurvey Translations Bot

Details Diff
Updated translation: Catalan by qualitatuvic
Updated translation: Italian by ritapas
Updated translation: Kazakh by xhoper
Updated translation: Italian (Informal) by ritapas
Attach Issues:
mod - locale/_template/limesurvey.pot Diff File
mod - locale/ca/ca.mo Diff File
mod - locale/it-informal/it-informal.mo Diff File
mod - locale/it/it.mo Diff File
mod - locale/kk/kk.mo Diff File

master 3dbba5b8

2020-08-13 14:08:57

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16483: Adding condition triggers bulk update for complete database (#1542)

Dev: UpgradeConditionsToRelevance receives two params: surveyId and qid. If the qid is specified, it should only update that question (as per the function doc). But, if surveyId is null, it loops trough all the surveys, which only makes sense if no qid is specified.
Affected Issues
16483
mod - application/helpers/expressions/em_manager_helper.php Diff File

master 9aec0b63

2020-08-12 17:57:28

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16326: Statistics filters do not reflect percentages and totals (#1531) Affected Issues
16326
mod - application/helpers/admin/statistics_helper.php Diff File

master e6a4bb4d

2020-08-12 17:55:38

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16206: Slider tip indicates false error (#1508)

Dev: Added extra validation for situations where value got NaN
Affected Issues
16206
mod - assets/packages/questions/numeric-slider/scripts/numeric-slider.js Diff File

master 16425fff

2020-08-12 17:50:51

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16566: We cannot create multiple choice questions (#1543)

Dev: Before issue 16469, QuestionEditorController tried to find the questions using 'findByPk', which automatically casts the value to int. Now, 'find' is used because the survey ID, as the search is done by multiple criterias.
Dev: When saving a new question, 'qid' is an empty string, and the resulting SQL fails in Postgres because of the data type. Solved by casting 'qid' to int.
Dev: This also helps with issue 16563.
Dev: Casting subquestion id as to remove the random characters vue id adds for its view.
Affected Issues
16469, 16563, 16566
mod - application/controllers/QuestionEditorController.php Diff File

master b2c63ba5

2020-08-12 17:48:11

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 15864: When deleting a question at LS 4 the system switches to the "Settings" menu (#1544)

Dev: The 'delete' method now supports the 'redirectTo' parameter: to question list or group overview. Depending on that, the sidebar is set as well
Affected Issues
15864
mod - application/controllers/admin/questions.php Diff File
mod - application/controllers/admin/surveyadmin.php Diff File
mod - application/views/admin/survey/topbar/question_topbar.php Diff File
 First  Prev  1 2 3 ... 150 ... 234 235 236 237 238 239 240 ... 300 ... 450 ... 600 ... 750 ... 900 ... 1050 ... 1200 ... 1350 ... 1450 1451 1452  Next  Last