Source Control Integration - LimeSurvey bugs and feature requests

master 7804ea53 2020-10-12 20:15:48 LimeBot Details Diff	Fixed issue: No update notification for comfort update users	Attach Issues:
	mod - application/config/version.php	Diff File
	add - application/core/plugins/ComfortUpdateChecker/ComfortUpdateChecker.php	Diff File
	add - application/core/plugins/ComfortUpdateChecker/assets/script.js	Diff File
	add - application/core/plugins/ComfortUpdateChecker/assets/style.css	Diff File
	add - application/core/plugins/ComfortUpdateChecker/config.xml	Diff File
	add - application/core/plugins/ComfortUpdateChecker/helpers/CUCMenuClass.php	Diff File
	mod - application/helpers/update/updatedb_helper.php	Diff File
3.x-LTS f780d8dd 2020-10-12 20:15:48 LimeBot Details Diff	Fixed issue: No update notification for Comfort Update users	Attach Issues:
	mod - application/config/version.php	Diff File
	add - application/core/plugins/ComfortUpdateChecker/ComfortUpdateChecker.php	Diff File
	add - application/core/plugins/ComfortUpdateChecker/assets/script.js	Diff File
	add - application/core/plugins/ComfortUpdateChecker/assets/style.css	Diff File
	add - application/core/plugins/ComfortUpdateChecker/config.xml	Diff File
	add - application/core/plugins/ComfortUpdateChecker/helpers/CUCMenuClass.php	Diff File
	mod - application/helpers/update/updatedb_helper.php	Diff File
master 3f9b19fa 2020-10-12 15:54:28 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16714: Clear process after test script is failing (#1614) Clear cache after test ends and also after a survye is deleted	Affected Issues 16714
	mod - application/models/Survey.php	Diff File
	mod - tests/TestBaseClass.php	Diff File
3.x-LTS 93946540 2020-10-12 09:30:31 LimeBot Details Diff	Release 3.24.0+201013	Attach Issues:
	mod - application/config/version.php	Diff File
	mod - docs/release_notes.txt	Diff File
master ee7a2087 2020-10-12 09:14:53 LimeBot Details Diff	Release 4.3.20+201012	Attach Issues:
	mod - application/config/version.php	Diff File
	mod - docs/release_notes.txt	Diff File
3.x-LTS 8b2818dd 2020-10-09 15:58:41 c_schmitz Details Diff	Fixed issue: Database exception when trying to import a question/group/survey from an incompatible LimeSurvey version	Attach Issues:
	mod - application/helpers/admin/import_helper.php	Diff File
3.x-LTS baca35c2 2020-10-09 15:46:25 c_schmitz Details Diff	Fixed issue: Database exception when trying to import a question/group/survey from an incompatible LimeSurvey version	Attach Issues:
	mod - application/helpers/admin/import_helper.php	Diff File
3.x-LTS a5bfe999 2020-10-09 14:59:50 c_schmitz Details Diff	Fixed issue: Database exception is shown when trying to download files on a inactive survey	Attach Issues:
	mod - application/controllers/admin/responses.php	Diff File
master bd3490ce 2020-10-09 14:59:50 c_schmitz Details Diff	Fixed issue: Database exception is shown when trying to download files on a inactive survey	Attach Issues:
	mod - application/controllers/admin/responses.php	Diff File
master 44f35ed7 2020-10-09 11:24:38 c_schmitz Details Diff	Fixed issue: Database exception is shown when trying to reload responses for/resume an inactive survey	Attach Issues:
	mod - application/controllers/survey/index.php	Diff File
3.x-LTS 2abb5762 2020-10-09 11:24:38 c_schmitz Details Diff	Fixed issue: Database exception is shown when trying to reload responses for/resume an inactive survey	Attach Issues:
	mod - application/controllers/survey/index.php	Diff File
master e71c7d2f 2020-10-08 09:36:06 LimeSurvey Translations Bot Details Diff	Updated translation: Arabic by medhat Updated translation: Finnish by Jmantysalo Updated translation: Italian by lfanfoni Updated translation: Japanese by nomoto, kmrmtr Updated translation: Italian (Informal) by lfanfoni	Attach Issues:
	mod - locale/_template/limesurvey.pot	Diff File
	mod - locale/ar/ar.mo	Diff File
	mod - locale/fi/fi.mo	Diff File
	mod - locale/it-informal/it-informal.mo	Diff File
	mod - locale/it/it.mo	Diff File
	mod - locale/ja/ja.mo	Diff File
3.x-LTS 94c4719c 2020-10-08 09:35:49 LimeSurvey Translations Bot Details Diff	Updated translation: Catalan by qualitatuvic Updated translation: Greek by george01 Updated translation: Italian by lfanfoni Updated translation: Japanese by nomoto, kmrmtr Updated translation: Italian (Informal) by lfanfoni	Attach Issues:
	mod - locale/_template/limesurvey.pot	Diff File
	mod - locale/ca/ca.mo	Diff File
	mod - locale/el/el.mo	Diff File
	mod - locale/it-informal/it-informal.mo	Diff File
	mod - locale/it/it.mo	Diff File
	mod - locale/ja/ja.mo	Diff File
master 076d6d0e 2020-10-08 09:17:50 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16708: php error in statistics view (#1616) ### Diagnosis According to the description of the issue we believe to be caused by a combination of errors: 1) When changing the type of a question from a type with subquestions to a type without subquestions (ex: from Array to List), the subquestions are not removed from the DB. The subquestions remain in the table with the old type. 2) Check Integrity processes these "orphan" subquestions making sure they match the parent question's type, without checking if it's actually correct for that type to have subquestions. So, it updates the subquestions while it should remove them. I think both actions should check the question type definition (QuestionType attributes) and, if the 'subquestions' attribute is false, remove the subquestions from the DB. ### Solution 1) Override 'update' method in Question model to delete existing subquestions if the question's type doesn't allow them. 2) Updated saveQuestionData action to avoid saving subquestions if the question's type doesn't allow them (because the subquestions are part the POST if they exist in the original question). 3) Updated common_helper's 'fixSubquestions' (used by check integrity) to do the same as mentioned in point 1. Note that 'fixSubquestions' only processes subquestions where the type is not the same as the parent question. This wasn't modified because of the potential impact in performance, but it means it won't fix subquestions of a wrong type if the parent question has the same type.	Affected Issues 16708
	mod - application/controllers/QuestionEditorController.php	Diff File
	mod - application/helpers/common_helper.php	Diff File
	mod - application/models/Question.php	Diff File
master 0dab3a85 2020-10-07 19:42:18 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16642: PHP warning when showing array questions (#1608) For dual scale questions, the 'cellwidth' variable calculation involved the number of labels. But, the number of labels is only calculated when the question is shown as radios, and not when it's shown as dropdown. However, fixing the 'cellwidth' calculation (diving by 1 when 'numrows' is not set) affected the rendering because the "answer_dropdown" view used the 'cellwidth' value for styling and it now changed from "INF" (infinity) to an actual number. So, the use of 'cellwidth' in dropdown view was removed in order to not alter how the question was rendered.	Affected Issues 16642
	mod - application/core/QuestionTypes/ArrayMultiscale/RenderArrayMultiscale.php	Diff File
	mod - application/views/survey/questions/answer/arrays/dualscale/answer_dropdown.twig	Diff File
3.x-LTS b8d06892 2020-10-07 14:03:55 gabrieljenik Committer: GitHub Details Diff	Fixed issue #16506: Fruity theme: question type Matrix (texts), you do not see the sums of the total columns and grand total. (#1605) Updating CSS clasess for the inputs as to have the data to be more visible	Affected Issues 16506
	mod - application/views/survey/questions/answer/arrays/texts/columns/col_total.twig	Diff File
	mod - application/views/survey/questions/answer/arrays/texts/rows/cells/td_grand_total.twig	Diff File
master 1f3e2932 2020-10-07 12:29:39 c_schmitz Details Diff	New feature: E-Mail bodies allow now for more than 64kb size when using MySQL Fixed issue: Error when too many translations are added to a survey Fixed issue: Some database updates from 3.x were not run on update	Attach Issues:
	mod - application/config/version.php	Diff File
	mod - application/controllers/admin/database.php	Diff File
	mod - application/core/db/MssqlSchema.php	Diff File
	mod - application/core/db/PgsqlSchema.php	Diff File
	mod - application/helpers/update/updatedb_helper.php	Diff File
	mod - installer/create-database.php	Diff File
3.x-LTS 4b7991ed 2020-10-07 12:03:06 c_schmitz Details Diff	New feature: E-Mail bodies allow now for more than 64kb size when using MySQL Fixed issue: Error when too many translations are added to a survey	Attach Issues:
	mod - application/config/version.php	Diff File
	mod - application/controllers/admin/database.php	Diff File
	mod - application/core/db/MssqlSchema.php	Diff File
	mod - application/core/db/PgsqlSchema.php	Diff File
	mod - application/helpers/update/updatedb_helper.php	Diff File
	mod - installer/create-database.php	Diff File
3.x-LTS 4315c673 2020-10-06 16:38:19 c_schmitz Details Diff	Fixed issue: Database exception when trying to add the same user twice in survey permissions	Attach Issues:
	mod - application/controllers/admin/surveypermission.php	Diff File
master 7cb3e8ba 2020-10-06 16:38:19 c_schmitz Details Diff	Fixed issue: Database exception when trying to add the same user twice in survey permissions	Attach Issues:
	mod - application/controllers/admin/surveypermission.php	Diff File
master de658f2d 2020-10-06 11:48:17 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16685: Delete Plugin files is not working (#1607) The 'Delete files' button existed but had no action assigned. Added new 'delete files' feature. Limited to the 'upload' plugin type. Added pluginType to the info returned by the scanPlugins method	Affected Issues 16685, 16711
	mod - application/controllers/admin/PluginManagerController.php	Diff File
	mod - application/libraries/PluginManager/PluginManager.php	Diff File
	mod - application/views/admin/pluginmanager/scanFilesResult.php	Diff File
3.x-LTS b5a79263 2020-10-06 10:06:42 c_schmitz Details Diff	Fixed issue: Database error on sorting CPDB participants by owner	Attach Issues:
	mod - application/models/Participant.php	Diff File
master 990190be 2020-10-06 10:06:42 c_schmitz Details Diff	Fixed issue: Database error on sorting CPDB participants by owner	Attach Issues:
	mod - application/models/Participant.php	Diff File
master b7b4378d 2020-10-05 17:01:22 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16704: Inheritance not working when importing themes created for LS3.x (#1611) The "theme options" page has multiple forms, and the right one was not being sent.	Affected Issues 16704
	mod - application/views/admin/themeoptions/update.php	Diff File
3.x-LTS cfe6bc1f 2020-10-05 17:00:13 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16560: After downloading tokens for the first time, need to refresh for a second download (#1613) When "save buttons" are clicked, they are disabled, the spinner is shown, and the form is submitted. It is expected that the submit ends in a redirect. The export button was identified as a "save button", but ended in a file download. In this case, since a file is donwloaded, the page remains in the same state, with the spinner displayed and the button disabled. It was changed to be handled as an "export button".	Affected Issues 16560
	mod - application/views/admin/token/token_bar.php	Diff File

Changesets: LimeSurvey