View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
16704Bug reportsTheme editorpublic2020-09-29 08:592020-10-12 09:28
ReporterMazi Assigned Togabrieljenik  
PrioritynoneSeverityblock 
Status closedResolutionfixed 
Product Version4.3.14 
Summary16704: Inheritance not working when importing themes created for LS3.x
Description

Importing themes created for LS 3.x works fine but when trying to change e.g. the logo at survey level by setting "inherit everything" at the theme options to "no" and then changing the logo file, this has no effect.

Steps To Reproduce
  1. Import the attached theme.
  2. Assign the theme to your test survey.
  3. Go to the theme options and set "Inherit everything" to "no".
  4. set the "logo left" setting to "yes" and select a different file, e.g. the "powered_by" file.
  5. Save
  6. Test your survey -> It still uses the globally assigned "logo" image.
  7. Check the theme options -> The default settings are still there.
Additional Information

I tested by extending vanilla and changing the brand logo the same way and there it was working fine. So there seems to be a problem with backwards compatibility.

TagsNo tags attached.
Attached Files
shop_backy-qfu0er.zip (764,074 bytes)
Bug heat10
Complete LimeSurvey version number (& build)4.3.14
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL
Server OS (if known)Ubuntu 20
Webserver software & version (if known)Apache 2.0
PHP Version7.3

Users monitoring this issue

DenisChenu

Activities

Mazi

Mazi

2020-09-29 09:13

updater   ~59976

@cdorin: This is a little show stopper for us since our customers can't change the theme options at survey level. It seems to affect all our templates offered at our shop. They work fine with LS 3.x but there are issues at LS 4.x.
DenisChenu

DenisChenu

2020-09-29 16:09

developer   ~59985

I check inheritance with skelvanilla like this

  1. Create a SurveyGroup
  2. Set some theme option : logo ON + logo in global file + skelvanilla variations
  3. Select skelvanilla on a survey in SurveyGroup : seem to work.

Please : don't broke it …
gabrieljenik

gabrieljenik

2020-09-29 18:49

manager   ~59986

@DenisChenu: skelvanilla is based on vanilla, right?
@Mazi: Yours are based on... Fruity?
DenisChenu

DenisChenu

2020-09-29 19:38

developer   ~59987

Last edited: 2020-09-29 19:39

@gabrieljenik yes based on vanilla

shop_backy-qfu0er.zip based on vanilla too …
DenisChenu

DenisChenu

2020-09-29 19:43

developer   ~59988

Ibherit all to NO :

  • update logo only : it's OK
  • update variation : OK
  • reset variation inherited : from SurveyGroup
  • set SurveyGroup to default : get it by default (no logo
  • set logo to on : have the logo …

All seems OK (on 4.3.16/ PHP7.4.10)
Mazi

Mazi

2020-09-29 23:41

updater   ~59989

Our themes are based on vanilla as well. Testing an extended version of vanilla works fine as mentioned above. But our default LS 3.x themes do not seem to work with LS4 when it comes to the inheritance settings.
DenisChenu

DenisChenu

2020-09-30 08:26

developer   ~59990

But our default LS 3.x themes do not seem to work with LS4 when it comes to the inheritance settings.

It seems to work with skelvanilla, it can be a manual fix , for logo : i use aSurveyInfo.options.brandlogofile

It work when

  1. Set to inherit and set in SurveyGroup
  2. Set in Survey

But : with you Theme : when i save : it come back to inherit …
My opinion : the issue is here :

I have to update my options.twig : https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/commit/209da6bd270d0a118efffba7afcd37079f45a97f to fix this issue in skelvanilla.
Mazi

Mazi

2020-09-30 09:45

updater   ~59991

Thanks for the hint, Denis!

But I would assume that custom LS3 themes work out of the box at LS4. If every users has to edit the options.js file, then there literally is no backwards compatibility.
DenisChenu

DenisChenu

2020-09-30 10:15

developer   ~59992

I have to control my plugins each time LimeSurvey was updated … even with minor fix since years …
Theme and template less, but need sometimes.

Theory VS reality …

And when i tell to some developer that broke API some month ago : the only answer was "We need to update" …
DenisChenu

DenisChenu

2020-09-30 16:27

developer   ~59996

See https://github.com/LimeSurvey/LimeSurvey/commit/cf1ee2855a6d74cfcc170857c97040fb700b2c63#diff-1ee8da614588472a13075b3c1a197b9a

This commit broke API
gabrieljenik

gabrieljenik

2020-10-01 14:47

manager   ~60025

https://github.com/LimeSurvey/LimeSurvey/pull/1611

The "theme options" page has multiple forms, and the right one was not being sent.
Mazi

Mazi

2020-10-01 21:59

updater   ~60042

Thanks for debugging and fixing, Gabriel!
gabrieljenik

gabrieljenik

2020-10-05 17:01

manager   ~60075

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30546
lime_release_bot

lime_release_bot

2020-10-12 09:28

administrator   ~60146

Fixed in Release 4.3.20+201012

Related Changesets

LimeSurvey: master b7b4378d

2020-10-05 17:01:22

gabrieljenik


Committer: GitHub Details Diff 		Fixed issue 16704: Inheritance not working when importing themes created for LS3.x (#1611)

The "theme options" page has multiple forms, and the right one was not being sent.		 Affected Issues
16704
mod - application/views/admin/themeoptions/update.php Diff File

Issue History

Date Modified Username Field Change
2020-09-29 08:59 Mazi New Issue
2020-09-29 08:59 Mazi File Added: shop_backy-qfu0er.zip
2020-09-29 09:13 Mazi Note Added: 59976
2020-09-29 11:01 DenisChenu Issue Monitored: DenisChenu
2020-09-29 16:08 cdorin Assigned To => gabrieljenik
2020-09-29 16:08 cdorin Status new => assigned
2020-09-29 16:09 DenisChenu Note Added: 59985
2020-09-29 18:49 gabrieljenik Note Added: 59986
2020-09-29 19:38 DenisChenu Note Added: 59987
2020-09-29 19:39 DenisChenu Note Edited: 59987
2020-09-29 19:43 DenisChenu Note Added: 59988
2020-09-29 23:41 Mazi Note Added: 59989
2020-09-30 08:26 DenisChenu Note Added: 59990
2020-09-30 09:45 Mazi Note Added: 59991
2020-09-30 10:15 DenisChenu Note Added: 59992
2020-09-30 15:53 gabrieljenik View Status private => public
2020-09-30 15:53 gabrieljenik Steps to Reproduce Updated
2020-09-30 16:27 DenisChenu Note Added: 59996
2020-10-01 14:47 gabrieljenik Note Added: 60025
2020-10-01 21:59 Mazi Note Added: 60042
2020-10-05 17:01 gabrieljenik Changeset attached => LimeSurvey master b7b4378d
2020-10-05 17:01 gabrieljenik Note Added: 60075
2020-10-05 17:01 gabrieljenik Resolution open => fixed
2020-10-12 09:28 lime_release_bot Note Added: 60146
2020-10-12 09:28 lime_release_bot Status assigned => closed
2021-08-03 04:14 guest Bug heat 8 => 10