16685: Delete Plugin files is not working - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

16685	Bug reports	Plugins	public	2020-09-22 11:32	2020-10-12 09:28

Reporter	LimeBot	Assigned To	gabrieljenik
Priority	none	Severity	minor
Status	closed	Resolution	fixed
Product Version	4.3.17

Summary	16685: Delete Plugin files is not working
Description	After scan for new plugins , there is a list of Plugins found in the system that are not installed or activated. The action button "Delete files " is not working (the page just simply refresh). The "Delete files" should be available only for uploaded Plugins not for core plugins.
Steps To Reproduce	Go to configuration Click on Plugin manager Unsinstall an uploaded plugin (Or Upload manually a plugin into your upload/plugins directory) Click on "Scan files" Try to delete plugin
Tags	No tags attached.
Attached Files	Delete Files.PNG (21,014 bytes) Delete Files.PNG (21,014 bytes)

Bug heat	6
Complete LimeSurvey version number (& build)	4.3.16+200915
I will donate to the project if issue is resolved	No
Browser
Database type & version	MySql - DB version 427
Server OS (if known)
Webserver software & version (if known)
PHP Version	7.4

User List	There are no users monitoring this issue.

gabrieljenik 2020-10-01 14:23 manager ~60014	https://github.com/LimeSurvey/LimeSurvey/pull/1607 The 'Delete files' button existed but had no action assigned. Added new 'delete files' feature. Limited to the 'upload' plugin type. Added pluginType to the info returned by the scanPlugins method I guess this happens on LSv3, as well, right? Still, maybe not that prioritary

LimeBot 2020-10-01 14:25 administrator ~60015	We don't have this feature in LS3 - Bug fix only for LS4 :)

gabrieljenik 2020-10-06 11:48 manager ~60079	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30550

lime_release_bot 2020-10-12 09:28 administrator ~60148	Fixed in Release 4.3.20+201012

LimeSurvey: master de658f2d 2020-10-06 11:48:17 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16685: Delete Plugin files is not working (#1607) The 'Delete files' button existed but had no action assigned. Added new 'delete files' feature. Limited to the 'upload' plugin type. Added pluginType to the info returned by the scanPlugins method	Affected Issues 16685, 16711
	mod - application/controllers/admin/PluginManagerController.php	Diff File
	mod - application/libraries/PluginManager/PluginManager.php	Diff File
	mod - application/views/admin/pluginmanager/scanFilesResult.php	Diff File

Date Modified	Username	Field	Change
2020-09-22 11:32	LimeBot	New Issue
2020-09-22 11:32	LimeBot	Status	new => assigned
2020-09-22 11:32	LimeBot	Assigned To	=> gabrieljenik
2020-09-22 11:32	LimeBot	File Added: Delete Files.PNG
2020-10-01 14:23	gabrieljenik	Note Added: 60014
2020-10-01 14:25	LimeBot	Note Added: 60015
2020-10-01 14:25	LimeBot	Status	assigned => ready for testing
2020-10-06 11:48	gabrieljenik	Changeset attached	=> LimeSurvey master de658f2d
2020-10-06 11:48	gabrieljenik	Note Added: 60079
2020-10-06 11:48	gabrieljenik	Resolution	open => fixed
2020-10-12 09:28	lime_release_bot	Note Added: 60148
2020-10-12 09:28	lime_release_bot	Status	ready for testing => closed