Relationship Graph View Issue Dependency Graph
related to child of duplicate of

View Issue Details

IDProjectCategoryView StatusLast Update
14129Bug reports[All Projects] Translationpublic2020-03-17 00:24
Reporterwolfganghueffer Assigned Touser204295 
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.19.2 
Target VersionFixed in Version3.21.1 
Summary14129: wrong translation table in German version
Description

Enclosed screenshots shows that there is a wrong translation for some buttons. Possibly the translation function is not connected correctly at these points.

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.13.0+180628
I will donate to the project if issue is resolvedNo
BrowserMozilla Firefox
Database & DB-VersionMS SQL 2012 SP4
Server OS (if known)Red Hat Enterprise Linux Server Release 7.4
Webserver software & version (if known)Apache/2.4.6
PHP VersionPHP 5.4.16

Activities

wolfganghueffer

wolfganghueffer

2018-10-04 13:04

reporter  

LimeSurvey_Bug01.JPG (38,283 bytes)
LimeSurvey_Bug01.JPG (38,283 bytes)
LimeSurvey_Bug02.JPG (38,103 bytes)
LimeSurvey_Bug02.JPG (38,103 bytes)
LimeSurvey_Bug03.JPG (21,097 bytes)
LimeSurvey_Bug03.JPG (21,097 bytes)
Mazi

Mazi

2018-10-05 12:24

partner   ~49250

I can still reproduce this at v3.14.11.

guest

guest

2018-11-12 17:33

viewer   ~49619

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=28509

Mazi

Mazi

2019-02-20 10:49

partner   ~50647

"Predefined label set" ist still not translated properly (screenshot: https://bugs.limesurvey.org/file_download.php?file_id=10786&type=bug). I just tested at demo.limesurvey.org

Mazi

Mazi

2019-04-05 08:33

partner   ~51355

@c_schmitz, this one was reported by a long term customer. They really wonder why such a simple thing like a missing translation takes half a year to fix. Any chance to get the fix included at the next release?

Mazi

Mazi

2019-04-05 09:27

partner   ~51368

The pre-filled "Same example answer option" also seems to not be translated yet.



image002.png (9,938 bytes)
image002.png (9,938 bytes)
DenisChenu

DenisChenu

2019-04-05 11:49

developer   ~51377

twig translation …

Mazi

Mazi

2019-04-15 11:08

partner   ~51467

The customer needs a fix so we will take over this one due to missing feedback by the development team.

DenisChenu

DenisChenu

2019-04-15 11:20

developer   ~51468

@Mazi : maybe the best for such situation (quickest way) is to add some "unused" call to gT("the string in twig") in https://github.com/LimeSurvey/LimeSurvey/blob/master/application/controllers/admin/questions.php#L420

For example : this sentence https://github.com/LimeSurvey/LimeSurvey/blob/d2adb9703d9f2847413239509525e9c682fbc47d/application/helpers/SurveyRuntimeHelper.php#L1128 are not used in twig …

This more an hack but … it work …

bismark

bismark

2019-05-03 09:25

reporter   ~51747

There is a yii event "onMissingTranslation" you can use to get noticed about missing translations:

in application/config.php add the folowing snippet within the components array,

'messages' => array(
    'onMissingTranslation' => function ($event) {
        var_dump($event->message); // you should log into a file instead
    }
),
bismark

bismark

2019-05-03 09:27

reporter   ~51748

by the way I sent a mail to translations@limesurvey.org to ask some workflow questions regarding translations

bismark

bismark

2019-05-03 10:35

reporter   ~51750

Translation of LimeSurvey 3.x.x in German

This file is distributed under the same license as the LimeSurvey 3.x.x package.

msgid ""
msgstr ""
"PO-Revision-Date: 2019-04-30 08:11:33+0000\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=n != 1;\n"
"X-Generator: GlotPress/2.2.2\n"
"Language: de\n"
"Project-Id-Version: LimeSurvey 3.x.x\n"

msgid "Predefined label sets…"
msgstr "Vordefinierte Beschriftungssets"

msgid "Some example answer option"
msgstr "Beispielantwort"

msgid "Subquestion"
msgstr "Teilfrage"

bismark

bismark

2019-05-03 10:37

reporter   ~51751

msgcat.exe limesurvey-3-de.po consulting-3-de.po -o merge.po

compile merge.po to de.mo

c_schmitz

c_schmitz

2019-05-03 12:06

administrator   ~51753

@LouisGac The regex is not properly grepping all translations.
I suggest we use this solution instead:

https://twig-extensions.readthedocs.io/en/latest/i18n.html#using-xgettext-or-poedit-1

Please implement. Thank you.

Mazi

Mazi

2019-05-07 17:20

partner   ~51812

@LouisGac, the customer would love to see this at the next release. Can you give it a try?
Thanks!

Mazi

Mazi

2019-10-25 15:12

partner   ~54225

Re-opened because this is still an issue at Version 3.19.3+191023.

Mazi

Mazi

2019-10-25 15:14

partner   ~54226

Screenshot of issue with current 3.19.3 version.



label_translation.png (43,342 bytes)
label_translation.png (43,342 bytes)
cdorin

cdorin

2019-10-25 15:16

manager   ~54229

@LouisGac

Mazi

Mazi

2019-12-13 09:38

partner   ~55015

@cdoring, this is still an issue at the latest version. When doing trainings people always stumble upon these missing translations and ask why that is or what a "subquestion" is and the like.

Is it that difficult to fix?



missing_translations.png (39,720 bytes)
missing_translations.png (39,720 bytes)
cdorin

cdorin

2019-12-13 10:32

manager   ~55017

not in the backlog either. Will add it now and increase its priority. Thx for the heads up

user204295

2020-01-15 15:37

  ~55295

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29397

lime_release_bot

lime_release_bot

2020-01-21 14:35

administrator   ~55404

Fixed in Release 4.0.0-RC14+200109

Mazi

Mazi

2020-01-21 15:09

partner   ~55408

@cdorin, can you confirm that this is fixed at LS 3.x and 4.x? We need the fix for both.

Mazi

Mazi

2020-01-30 15:49

partner   ~55576

New screenshots showing LS 3.21.6 and LS 4RC14



ls3.png (40,283 bytes)
ls3.png (40,283 bytes)
ls4.png (24,562 bytes)
ls4.png (24,562 bytes)

user204295

2020-02-11 09:11

  ~55850

@Mazi, thank you for your ongoing feedback - i've found the problem and will fix it asap

c_schmitz

c_schmitz

2020-03-16 23:36

administrator   ~56584

Please update to the latest version and try again. Thank you.

Mazi

Mazi

2020-03-17 00:24

partner   ~56587

Looks good at the latest 3.22.9 version.



image.png (32,328 bytes)
image.png (32,328 bytes)

Related Changesets

LimeSurvey: master 413b5b05

2018-11-12 17:28:53

Dominik Vitt

Details Diff
Fixed issue 14129: wrong translation table in German version Affected Issues
14129
mod - application/views/admin/survey/Question/answerOptionsEdit_view.twig Diff File
mod - application/views/admin/survey/Question/question_subviews/_modals.twig Diff File
mod - application/views/admin/survey/Question/subquestionsAndAnswers/_answer_option.twig Diff File

LimeSurvey: master 298e7109

2019-12-27 16:13:58

user204295

Details Diff
Fixed issue 14129: Translation missing in subquestion panel Affected Issues
14129
mod - application/commands/TwigCommand.php Diff File
mod - application/views/admin/survey/Question/answerOptionsEdit_view.twig Diff File

LimeSurvey: master 0aa2497d

2019-12-30 15:33:22

user204295

Details Diff
Fixed issue 14129: Translation missing in subquestion panel Affected Issues
14129
mod - application/commands/TwigCommand.php Diff File

LimeSurvey: master ea5483aa

2019-12-30 15:33:22

user204295

Details Diff
Fixed issue 14129: Translation missing in subquestion panel Affected Issues
14129
mod - application/views/admin/survey/Question/answerOptionsEdit_view.twig Diff File

LimeSurvey: master 83678892

2020-01-02 10:42:47

user204295

Details Diff
Fixed issue 14129: Translation missing in subquestion panel Affected Issues
14129
mod - application/commands/TwigCommand.php Diff File

LimeSurvey: master b690b559

2020-01-02 15:52:48

user204295

Details Diff
Fixed issue 14129: Translation missing in subquestion panel Affected Issues
14129
mod - application/commands/TwigCommand.php Diff File
mod - application/core/ConsoleApplication.php Diff File
mod - application/views/admin/survey/Question/answerOptionsEdit_view.twig Diff File
mod - application/views/admin/survey/subview/surveydashboard/001-sharingpanel.twig Diff File
mod - application/views/survey/questions/answer/multiplenumeric/answer.twig Diff File

Issue History

Date Modified Username Field Change
2018-10-04 13:04 wolfganghueffer New Issue
2018-10-04 13:04 wolfganghueffer File Added: LimeSurvey_Bug01.JPG
2018-10-04 13:04 wolfganghueffer File Added: LimeSurvey_Bug02.JPG
2018-10-04 13:04 wolfganghueffer File Added: LimeSurvey_Bug03.JPG
2018-10-05 12:24 Mazi Note Added: 49250
2018-10-05 12:24 Mazi Assigned To => dominikvitt
2018-10-05 12:24 Mazi Status new => assigned
2018-11-12 17:33 Changeset attached => LimeSurvey master 413b5b05
2018-11-12 17:33 guest Note Added: 49619
2018-11-12 17:33 guest Resolution open => fixed
2018-11-12 17:43 dominikvitt Status assigned => resolved
2018-11-12 17:43 dominikvitt Fixed in Version => 3.15.x
2019-02-20 10:49 Mazi Status resolved => assigned
2019-02-20 10:49 Mazi Note Added: 50647
2019-04-05 08:33 Mazi Note Added: 51355
2019-04-05 09:27 Mazi File Added: image002.png
2019-04-05 09:27 Mazi Note Added: 51368
2019-04-05 11:49 DenisChenu Note Added: 51377
2019-04-05 11:49 DenisChenu Relationship added related to 14340
2019-04-05 11:50 DenisChenu Relationship added related to 13583
2019-04-15 11:08 Mazi Assigned To dominikvitt => Mazi
2019-04-15 11:08 Mazi Note Added: 51467
2019-04-15 11:20 DenisChenu Note Added: 51468
2019-05-03 09:25 bismark Note Added: 51747
2019-05-03 09:27 bismark Note Added: 51748
2019-05-03 10:35 bismark Note Added: 51750
2019-05-03 10:37 bismark Note Added: 51751
2019-05-03 10:57 cdorin Assigned To Mazi => c_schmitz
2019-05-03 12:04 c_schmitz Assigned To c_schmitz => LouisGac
2019-05-03 12:06 c_schmitz Note Added: 51753
2019-05-07 17:20 Mazi Note Added: 51812
2019-05-23 15:04 c_schmitz Relationship added duplicate of 14933
2019-05-23 15:04 c_schmitz Status assigned => closed
2019-05-23 15:04 c_schmitz Resolution fixed => duplicate
2019-06-24 16:04 cdorin Relationship replaced related to 14933
2019-10-25 15:12 Mazi Reproducibility have not tried => always
2019-10-25 15:12 Mazi Status closed => new
2019-10-25 15:12 Mazi Resolution duplicate => reopened
2019-10-25 15:12 Mazi Product Version 3.12.x => 3.19.2
2019-10-25 15:12 Mazi Note Added: 54225
2019-10-25 15:14 Mazi File Added: label_translation.png
2019-10-25 15:14 Mazi Note Added: 54226
2019-10-25 15:16 cdorin Note Added: 54229
2019-12-13 09:38 Mazi File Added: missing_translations.png
2019-12-13 09:38 Mazi Note Added: 55015
2019-12-13 10:30 cdorin Assigned To LouisGac => cdorin
2019-12-13 10:32 cdorin Note Added: 55017
2019-12-27 16:20 user204295 Changeset attached => LimeSurvey master 298e7109
2019-12-27 16:20 user204295 Assigned To cdorin => user204295
2019-12-27 16:20 user204295 Resolution reopened => fixed
2019-12-30 15:57 user204295 Changeset attached => LimeSurvey master 0aa2497d
2019-12-30 17:45 user204295 Changeset attached => LimeSurvey master ea5483aa
2020-01-02 16:04 user204295 Changeset attached => LimeSurvey master 83678892
2020-01-15 15:37 user204295 Changeset attached => LimeSurvey master b690b559
2020-01-15 15:37 user204295 Note Added: 55295
2020-01-21 14:35 lime_release_bot Note Added: 55404
2020-01-21 14:35 lime_release_bot Status new => closed
2020-01-21 15:09 Mazi Note Added: 55408
2020-01-30 15:49 Mazi File Added: ls3.png
2020-01-30 15:49 Mazi File Added: ls4.png
2020-01-30 15:49 Mazi Note Added: 55576
2020-02-03 15:08 user204295 Status closed => acknowledged
2020-02-03 17:46 user204295 Status acknowledged => assigned
2020-02-11 09:11 user204295 Note Added: 55850
2020-02-11 09:13 user204295 Status assigned => confirmed
2020-03-16 23:36 c_schmitz Status confirmed => closed
2020-03-16 23:36 c_schmitz Fixed in Version 3.15.x => 3.21.1
2020-03-16 23:36 c_schmitz Note Added: 56584
2020-03-17 00:24 Mazi File Added: image.png
2020-03-17 00:24 Mazi Note Added: 56587