Dependency Graph

Dependency Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
11891Bug reportsCentral participant databasepublic2020-03-13 19:23
ReporterDenisChenu Assigned Toollehar  
PrioritynoneSeverityminor 
Status closedResolutionreopened 
Product Version2.55.x 
Summary11891: Lost a really needed feature in the lasts version : filter + move whole filter to a survey
DescriptionIn 2.50 : in CPDB we can in the listing:
1: apply a filter to the list
2: Send the filtered particpant to a survey even if there are 10000 filtered partcipant
Steps To ReproduceTry to send more than 1000 partcipant filtered by a specific attribute in a survey with 2.55.
Additional InformationI think it's a needed feature for CPDB, else : no reason to use CPDB.

Old system for filter is not so great, but exist (usage of jqgrid filter ?). Have a separate system/page with allowing complex filter seems best.

There are 2 lack of option actually
 - The "Add particpant to survey" is here only for 'checked' participant
 - We can only do filter on attribute show in list and simple AND filter
TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)20161109
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

related to 11971 closedmarkusfluer Bug reports Central Participant Database hangs for many participants 
related to 12019 closedmarkusfluer Bug reports Can't see survey listing for participants in CPDB 
related to 12057 new Feature requests Full Search not possible on version 2.58 
related to 12218 closedc_schmitz Bug reports Error when selecting display 2500 rows per page 

Activities

DenisChenu

DenisChenu

2016-11-09 10:47

developer  

250_1.png (28,896 bytes)   
250_1.png (28,896 bytes)   
DenisChenu

DenisChenu

2016-11-09 10:48

developer  

250_2.png (28,052 bytes)   
250_2.png (28,052 bytes)   
DenisChenu

DenisChenu

2016-11-09 10:48

developer  

255_partialsolution.png (12,325 bytes)   
255_partialsolution.png (12,325 bytes)   
ollehar

ollehar

2016-11-22 14:24

administrator   ~42125

But, just use the grid view filter instead?
DenisChenu

DenisChenu

2016-11-22 14:40

developer   ~42128

There are 2 lack of option actually
 - The "Add particpant to survey" is here only for 'checked' participant
 - We can only do filter on attribute show in list and simple AND filt

Before

"Add participant" allow to whole partcipant 'filtered' not only 'checked' : even if you show 10 partcipant : you can transfert 1000 of them

We have attribute not shown in "table" but shown in "advanced filter".

Actually :! must work with external tools to do same thing.
DenisChenu

DenisChenu

2016-11-22 14:43

developer   ~42129

Sincerely : you CAN not
- Assign 1000 participant in one click
- Filter with "not shown" attribute in table
ollehar

ollehar

2016-11-22 14:45

administrator   ~42130

1. Display 1000 rows in grid view
2. Filter
3. Mark all
4. Use massive action to add all marked to survey

No?
ollehar

ollehar

2016-11-22 14:46

administrator   ~42131

But yes, there's only AND-filtering, no OR-filtering.
DenisChenu

DenisChenu

2016-11-22 14:57

developer   ~42132

And 5000 ?
And 10000 ?
And 100000 ?

1000 : a lot more long time to show.

I test it in real situation.

The partcipant DB come from another tool, some column are hidden in table : then can not be filtered.
DenisChenu

DenisChenu

2016-11-22 14:58

developer   ~42133

In real situation : i go on phpMyAdmin to filter/export import hacked CSV
DenisChenu

DenisChenu

2016-11-22 15:06

developer   ~42134

OR/AND : yes, but it's not major: can do it in 2/3 step.

1000 : you can not show 1000 partcipant (in 2.55.0 version) only 100
With 100 : you have javascript time alert.
And 9 second to take it
DenisChenu

DenisChenu

2016-11-22 15:09

developer   ~42135

See Real-situation-2.55.png
DenisChenu

DenisChenu

2016-11-22 15:49

developer  

Real-situation-2.55.png (65,578 bytes)   
Real-situation-2.55.png (65,578 bytes)   
LouisGac

LouisGac

2017-01-18 10:49

developer   ~42743

If I remember well, Markus unactivate the JavaScript when the number of participants shown are up to a certain amount. So the problem should be fixed.
Markus, can you confirm please?
LouisGac

LouisGac

2017-01-18 10:50

developer   ~42744

Yep it the case:
https://bugs.limesurvey.org/view.php?id=11971

So we can close this bug report, right?
DenisChenu

DenisChenu

2017-01-18 10:53

developer   ~42746

@LouisGac: you don't read the bug report:

Please compare the 2.50 CPDB feature and the new one. The actual fix are only a workaround.


1: apply a filter to the list : 250_1.png : complex filter, filter on hidden columns etc ....
2: Send the filtered participant to a survey even if there are 10000 filtered partcipant : in 2.50 : if no line are checked : then we allow to send all user (filtered by actual filter) in another survey : 250_2.png The Add all (number) participant in you current list ....
DenisChenu

DenisChenu

2017-01-18 10:54

developer   ~42747

No : can not close ..... 2 previous feature are lost ....
ollehar

ollehar

2017-01-18 10:55

administrator   ~42748

I worked on this bug, there's a branch for it: cpdb_filter. Sadly I got interrupted, did not have time to finish it yet.
LouisGac

LouisGac

2017-01-18 11:07

developer   ~42749

Last edited: 2017-01-18 11:08

View 2 revisions

I compared the features, and they are logically equivalent.


No need to spend too much time on it. The only problem is the 'OR' statement, and has you told it yourself, it's just about doing multiple requests instead of one. Maybe also the operator 'not contains', but it should not be necessary if the users are created with a strong logic.

So basically: if it's possible to show an unlimited number of users in the list without causing the javascript crash, the problem is fixed.

DenisChenu

DenisChenu

2017-01-18 14:42

developer   ~42751

logically equivalent : you kidding ?

Usage : 100 columns + more than 100 000 participant.
with 2.50 : less than 1 minutes to filter and move 10 000 participant
with 2.58 : show needed column, filter 1000 by 1000 (else time issue (not by js, by server)) : more than 10 minutes

ANd if it's equivlent : why 2 other user's post a feature/bug report ?
LouisGac

LouisGac

2017-01-18 15:57

developer   ~42756

logically equivalent: for the operators (>, =, <). Like I said, the only missing operator is "not contains" and "or".

10 minutes to show 1000 entries: wow.That's a problem. I didn't wrote the model for that part, it's probably possible to get it working faster.

Also, I remember that jQgrid was having a huge speed problems. Eg: in survey list, when having a lot of surveys, it took a very long time to load.
ollehar

ollehar

2017-01-18 16:02

administrator   ~42758

There are some nested queries within queries to fetch active surveys for each participant. It could be lazily loaded instead, I guess. I thought about that.
LouisGac

LouisGac

2017-01-18 16:09

developer   ~42759

ok I see.

Maybe it would be easier to do as denis suggested, to provide a way to export all the users corresponding to the current filter without selecting them (it's just about relaunching the query without limit)... but: I bet it would take the very same time to export them than to show them.
ollehar

ollehar

2017-01-18 17:23

administrator   ~42760

My solution was to let the massive action button show "Filtered" instead of "Selected" when nothing is selected.
LouisGac

LouisGac

2017-01-18 17:28

developer   ~42761

yep good idea. But I bet it would take the very same time to export them than to show them (and could crash in the middle of the request because of time limit of the script)
DenisChenu

DenisChenu

2017-03-21 18:50

developer   ~43309

See https://bugs.limesurvey.org/view.php?id=12218

Move partcipant id only or display whole participant information are really different in memory.
DenisChenu

DenisChenu

2017-07-25 08:04

developer   ~44210

https://demo.andmemasin.eu/yii1-querybuilder/ :)
c_schmitz

c_schmitz

2020-03-13 18:46

administrator   ~56451

This version of LimeSurvey is not longer supported. Please check so that the issue is fixed in a more recent version of LimeSurvey. If it's not, please reopen this bug report. Thank you.
DenisChenu

DenisChenu

2020-03-13 19:23

developer   ~56528

It still not fixed.

2.6lts filter system din't work in any 3 and up versin

Issue History

Date Modified Username Field Change
2016-11-09 10:47 DenisChenu New Issue
2016-11-09 10:47 DenisChenu Status new => assigned
2016-11-09 10:47 DenisChenu Assigned To => ollehar
2016-11-09 10:47 DenisChenu File Added: 250_1.png
2016-11-09 10:48 DenisChenu File Added: 250_2.png
2016-11-09 10:48 DenisChenu File Added: 255_partialsolution.png
2016-11-22 14:24 ollehar Note Added: 42125
2016-11-22 14:25 ollehar Status assigned => closed
2016-11-22 14:25 ollehar Resolution open => won't fix
2016-11-22 14:40 DenisChenu Note Added: 42128
2016-11-22 14:43 DenisChenu Status closed => feedback
2016-11-22 14:43 DenisChenu Resolution won't fix => reopened
2016-11-22 14:43 DenisChenu Note Added: 42129
2016-11-22 14:45 ollehar Note Added: 42130
2016-11-22 14:46 ollehar Note Added: 42131
2016-11-22 14:57 DenisChenu Note Added: 42132
2016-11-22 14:57 DenisChenu Status feedback => assigned
2016-11-22 14:58 DenisChenu Note Added: 42133
2016-11-22 15:06 DenisChenu Note Added: 42134
2016-11-22 15:09 DenisChenu File Added: Real-situation-2.55.png
2016-11-22 15:09 DenisChenu Note Added: 42135
2016-11-22 15:48 DenisChenu File Deleted: Real-situation-2.55.png
2016-11-22 15:48 DenisChenu File Added: Real-situation-2.55.png
2016-11-22 15:48 DenisChenu File Deleted: Real-situation-2.55.png
2016-11-22 15:49 DenisChenu File Added: Real-situation-2.55.png
2016-12-02 22:40 DenisChenu Relationship added related to 11971
2016-12-26 10:56 DenisChenu Relationship added related to 12019
2017-01-14 12:09 DenisChenu Relationship added related to 12057
2017-01-18 10:49 LouisGac Note Added: 42743
2017-01-18 10:50 LouisGac Note Added: 42744
2017-01-18 10:53 DenisChenu Note Added: 42746
2017-01-18 10:54 DenisChenu Note Added: 42747
2017-01-18 10:55 ollehar Note Added: 42748
2017-01-18 11:07 LouisGac Note Added: 42749
2017-01-18 11:08 LouisGac Note Edited: 42749 View Revisions
2017-01-18 14:42 DenisChenu Note Added: 42751
2017-01-18 15:57 LouisGac Note Added: 42756
2017-01-18 16:02 ollehar Note Added: 42758
2017-01-18 16:09 LouisGac Note Added: 42759
2017-01-18 17:23 ollehar Note Added: 42760
2017-01-18 17:28 LouisGac Note Added: 42761
2017-03-21 18:49 DenisChenu Relationship added related to 12218
2017-03-21 18:50 DenisChenu Note Added: 43309
2017-07-25 08:04 DenisChenu Note Added: 44210
2020-03-13 18:46 c_schmitz Note Added: 56451
2020-03-13 18:46 c_schmitz Status assigned => closed
2020-03-13 19:23 DenisChenu Note Added: 56528