View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
09907Bug reportsSurvey participants (Tokens)public2015-09-30 11:01
Reportermas_carpone Assigned ToDenisChenu  
PrioritylowSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Fixed in Version2.06+ 
Summary09907: Invitations can not be sent before the start date of the tokens / inappropriate error message
Description

If token start date/time is > to the date/time at which an invitation is sent, no emails are sent and the following (contradicting) error message is given:

Email to XX (xx@xxx.org) delayed: Token is not yet valid.
All emails were sent

Steps To Reproduce

Create a token with a start date/time > than current date/time.
Send an invitation

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)2.05+ 150222
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL
Server OS (if known)Linux
Webserver software & version (if known)?
PHP Version?

Users monitoring this issue

There are no users monitoring this issue.

Activities

Mazi

Mazi

2015-09-22 13:52

updater   ~33130

Denis, I discussed this with several others and we came to the conclusion that the best fix would be to:

  • first show a warning
    "Some tokens have a 'valid from' date set which is in the future. When sending emails now they will not be able to access the survey before that 'valid from' date.
    Do you want to continue?" (Yes/Cancel)
  • if YES -> send emails
  • if NO -> stop

See https://www.limesurvey.org/en/forum/design-issues/65596-invalid-token?start=10#125967 for forum discussion.

DenisChenu

DenisChenu

2015-09-22 14:04

developer   ~33131

Just a "check box" in send mail , unchecked by default.

Mazi

Mazi

2015-09-22 14:17

updater   ~33132

Well, I'd really like to see a warning if there are tokens that are not valid yet.
Maybe we can hide the check box and show it after having shown the warning?

DenisChenu

DenisChenu

2015-09-22 14:46

developer   ~33133

All are to be reviewed for 2.05 AND 3.0 . Then just a checkbox.

Mazi

Mazi

2015-09-22 14:51

updater   ~33134

If only a checkbox we definitely need to adjust the error message! We should change
"Email to XX (xx@xxx.org) delayed: Token is not yet valid."
to:
"Note: Token for XX (xx@xxx.org) is not yet valid."

The "All emails were sent" part I think we can leave as is.

DenisChenu

DenisChenu

2015-09-22 14:56

developer   ~33135

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15934

mas_carpone

mas_carpone

2015-09-23 09:24

reporter   ~33138

Last edited: 2015-09-23 09:24

I personally like the first option better:

  • first show a warning
    "Some tokens have a 'valid from' date set which is in the future. When sending emails now they will not be able to access the survey before that 'valid from' date.
    Do you want to continue?" (Yes/Cancel)
  • if YES -> send emails
  • if NO -> stop

It would definitely give more flexibility
Thanks for looking into that!

DenisChenu

DenisChenu

2015-09-23 09:39

developer   ~33139

With your option :

  • Send valid email but not send invalid

Aren't possible.

c_schmitz

c_schmitz

2015-09-30 11:01

administrator   ~33220

Version 2.06+ Build 150930 released

Related Changesets

LimeSurvey: master b8445767

2015-09-22 12:55:53

DenisChenu

Details Diff
Fixed issue 09907: Invitations can not be sent before the start date of the tokens / inappropriate error message
Dev: Add a checkbox to bypass date control
Dev: TokenDynamic->findUninvitedIDsfind don't accept more Criteria : review it for 3.0
Affected Issues
09907
mod - application/controllers/admin/tokens.php Diff File
mod - application/views/admin/token/emailwarning.php Diff File
mod - application/views/admin/token/invite.php Diff File
mod - application/views/admin/token/remind.php Diff File

Issue History

Date Modified Username Field Change
2015-09-22 13:44 mas_carpone New Issue
2015-09-22 13:49 Mazi Assigned To => DenisChenu
2015-09-22 13:49 Mazi Status new => assigned
2015-09-22 13:52 Mazi Note Added: 33130
2015-09-22 14:04 DenisChenu Note Added: 33131
2015-09-22 14:17 Mazi Note Added: 33132
2015-09-22 14:46 DenisChenu Note Added: 33133
2015-09-22 14:51 Mazi Note Added: 33134
2015-09-22 14:56 DenisChenu Changeset attached => LimeSurvey master b8445767
2015-09-22 14:56 DenisChenu Note Added: 33135
2015-09-22 14:56 DenisChenu Resolution open => fixed
2015-09-22 14:56 DenisChenu Status assigned => resolved
2015-09-22 14:56 DenisChenu Fixed in Version => 2.06+
2015-09-23 09:24 mas_carpone Note Added: 33138
2015-09-23 09:24 mas_carpone Note Edited: 33138
2015-09-23 09:39 DenisChenu Note Added: 33139
2015-09-30 11:01 c_schmitz Note Added: 33220
2015-09-30 11:01 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)