View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
09837Bug reportsSurvey editingpublic2015-09-30 11:01
Reporterjelo Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.06+ 
Fixed in Version2.06+ 
Summary09837: Quotes are removed in End URL field
Description

In the End URL field all quotes are removed.
That is the behavior in 2.05 and 2.06.

EM code like "if(q01_A1.NAOK == "Y", "1", "0")" won't work.

Steps To Reproduce

Enter quotes and save. Quotes are removed. Both "" and '' will removed.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)150812
I will donate to the project if issue is resolvedNo
BrowserFirefox 39
Database type & versionMySQL 5.5.27
Server OS (if known)CentOS 6.6 x86_64
Webserver software & version (if known)Apache 2.2.31
PHP Version5.5.27

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2015-08-21 14:27

administrator   ~32971

Can you give a full URL example ?

jelo

jelo

2015-08-21 14:34

partner   ~32972

There is no need for a full URL, since the quotes are removed when are in the field. Just enter >abc "'< and you get >abc<.

I recognized the error, when I was using a complete URL with EMcode.
Same behaviour. The last 2.05+ and 2.06+ show no difference.

Are you not able to reproduce?

c_schmitz

c_schmitz

2015-08-21 14:44

administrator   ~32975

The quotes could be removed because it is not a valid expression or not a valid URL. So I would appreciate a full URL example.

jelo

jelo

2015-08-21 14:54

partner   ~32976

https://HOSTwithScript?lsn={SAVEDID}&amp;test={if(q01_A1.NAOK == "Y", 1, 0)}

Workaround without quotes:
https://HOSTwithScript?lsn={SAVEDID}&amp;test={if(!is_empty(q03_A1.NAOK),1,0)}

When using "Y" the quotes are removed and and QA is only having one warning.
Y unknown Variable since quotes are missing.

Question is, why a automatically working filter of quotes is needed at all. The QA check shows most of the errors nicely.

c_schmitz

c_schmitz

2015-08-24 12:59

administrator   ~32994

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=15780

c_schmitz

c_schmitz

2015-08-24 13:00

administrator   ~32995

Fix committed to develop branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=15781

c_schmitz

c_schmitz

2015-09-30 11:01

administrator   ~33238

Version 2.06+ Build 150930 released

Related Changesets

LimeSurvey: master 4fd58c1a

2015-08-24 10:58:56

c_schmitz

Details Diff
Fixed issue 09837: Quotes are removed in End URL field Affected Issues
09837
mod - application/core/LSYii_Validators.php Diff File

LimeSurvey: develop d2b7fcfb

2015-08-24 10:58:56

c_schmitz

Details Diff
Fixed issue 09837: Quotes are removed in End URL field Affected Issues
09837
mod - application/core/LSYii_Validators.php Diff File

Issue History

Date Modified Username Field Change
2015-08-18 20:34 jelo New Issue
2015-08-21 14:27 c_schmitz Note Added: 32971
2015-08-21 14:27 c_schmitz Assigned To => c_schmitz
2015-08-21 14:27 c_schmitz Status new => feedback
2015-08-21 14:34 jelo Note Added: 32972
2015-08-21 14:34 jelo Status feedback => assigned
2015-08-21 14:44 c_schmitz Note Added: 32975
2015-08-21 14:54 jelo Note Added: 32976
2015-08-24 12:59 c_schmitz Changeset attached => LimeSurvey master 4fd58c1a
2015-08-24 12:59 c_schmitz Note Added: 32994
2015-08-24 12:59 c_schmitz Resolution open => fixed
2015-08-24 12:59 c_schmitz Status assigned => resolved
2015-08-24 12:59 c_schmitz Fixed in Version => 2.06+
2015-08-24 13:00 c_schmitz Changeset attached => LimeSurvey develop d2b7fcfb
2015-08-24 13:00 c_schmitz Note Added: 32995
2015-09-30 11:01 c_schmitz Note Added: 33238
2015-09-30 11:01 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing