View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
09772 | Bug reports | Survey taking | public | 2015-07-10 21:31 | 2015-07-24 11:44 |
Reporter | scottturnbull | Assigned To | DenisChenu | ||
Priority | normal | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.05+ | ||||
Fixed in Version | 2.06+ | ||||
Summary | 09772: Using "Previous" Button to Navigate back to Welcome Screen before Exit Makes ReVisiting Fail | ||||
Description | When running a survey that uses tokens allowing revisiting of the survey, this results in the saved "Last Page" for that token to be saved as -1, and the survey can no longer be visited for that token. The result is a PHP error with "Undefined index: gid" message. | ||||
Steps To Reproduce | Create a survey with a welcome and one or two question groups. Activate tokens for the survey, configure the token use allowing the survey to be revisited with a single token. Create a token. Activate the survey, so that data records are kept. Using the Token Administration dialog, access the survey for the token. Use Next button to move from welcome to first page of questions. Now use the Next button to move down into the survey. Use the Token Admin dialog to access the survey again for the same token. Doing an export of the saved response associated with the token shows that the "Last Page" field has a value of -1. | ||||
Additional Information | Trivial survey exhibiting the issue is attached as an .lss file. PHP notice and stack trace that is generated by the error pasted below... PHP notice Undefined index: gid /var/www/survey.uvm.edu/application/helpers/SurveyRuntimeHelper.php(767) 755 else if ($surveyMode != 'survey') | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 22 | ||||
Complete LimeSurvey version number (& build) | unknown (user, not admin) | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Firefox 39.0 | ||||
Database type & version | MySQL Percona 5.5 | ||||
Server OS (if known) | Apache/2.2.15 (Red Hat) Yii Framework/1.1.15 | ||||
Webserver software & version (if known) | Apache/2.2.15 (Red Hat) Yii Framework/1.1.15 | ||||
PHP Version | 5.3.29 | ||||
Hi, Can you test with last 2.06 version ? |
|
2.06 : same bug :) |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15562 |
|
Fix committed to develop branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15563 |
|
Thanks for the prompt review and fix. I'll let the campus admin know that we're backlevel (2.05+) and that a fix is waiting in (2.06+). Can you tell me whether the fix tolerates the data records that previously prevented access to the survey, or whether the fix prevents the generation of the saved data that broke the survey access? The former would resurrect access for tokens that have bent data. The latter would make sure no bad data is generated going into the future. |
|
Hi, The fix can be easily apply to any 2.05, just after testing is $_SESSION[$LEMsessid]['step'] is set. then after the else: |
|
Version 2.06 Build 150723 released |
|
LimeSurvey: master 63c722de 2015-07-11 18:55 Details Diff |
Fixed issue 09772: Using "Previous" Button to Navigate back to Welcome Screen before Exit Makes ReVisiting Fail Dev: debug 0 show and empty group with preview and next Dev: globally force $_SESSION[$LEMsessid]['step'] to 0 or up |
Affected Issues 09772 |
|
mod - application/helpers/SurveyRuntimeHelper.php | Diff File | ||
LimeSurvey: develop 13f48a76 2015-07-11 19:05 Details Diff |
Fixed issue 09772: Using "Previous" Button to Navigate back to Welcome Screen before Exit Makes ReVisiting Fail Dev: force 0 or throw error ? Here force 0. |
Affected Issues 09772 |
|
mod - application/components/SurveySession.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2015-07-10 21:31 | scottturnbull | New Issue | |
2015-07-10 21:31 | scottturnbull | File Added: limesurvey_survey_635925.lss | |
2015-07-11 11:09 | DenisChenu | Note Added: 32669 | |
2015-07-11 11:09 | DenisChenu | Assigned To | => DenisChenu |
2015-07-11 11:09 | DenisChenu | Status | new => feedback |
2015-07-11 18:36 | DenisChenu | Note Added: 32670 | |
2015-07-11 18:36 | DenisChenu | Status | feedback => confirmed |
2015-07-11 18:56 | DenisChenu | Changeset attached | => LimeSurvey master 63c722de |
2015-07-11 18:56 | DenisChenu | Note Added: 32671 | |
2015-07-11 18:56 | DenisChenu | Resolution | open => fixed |
2015-07-11 19:06 | DenisChenu | Changeset attached | => LimeSurvey develop 13f48a76 |
2015-07-11 19:06 | DenisChenu | Note Added: 32672 | |
2015-07-11 19:06 | DenisChenu | Status | confirmed => resolved |
2015-07-11 19:06 | DenisChenu | Fixed in Version | => 2.06+ |
2015-07-13 14:54 | scottturnbull | Note Added: 32675 | |
2015-07-13 16:09 | DenisChenu | Note Added: 32676 | |
2015-07-23 01:43 | DenisChenu | Relationship added | has duplicate 09658 |
2015-07-24 11:44 | c_schmitz | Note Added: 32777 | |
2015-07-24 11:44 | c_schmitz | Status | resolved => closed |