View Issue Details

This bug affects 1 person(s).
 12
IDProjectCategoryView StatusLast Update
09601Feature requestsTheme editorpublic2015-08-05 10:49
Reportertammo Assigned Toc_schmitz  
PrioritynormalSeverityfeature 
Status closedResolutionfixed 
Summary09601: Font files cannot be uploaded in template upload
Description

In /application/config/config-defaults.php (line 85 in version 2.05, built 150413), only gif,ico,jpg,png,css,js files can be uploaded.

When creating more complex templates, based on Bootstrap/grunt, several other files may be created.

For example a css.map files and font files.

Please include the following extensions in the allowedtemplateuploads:
map, json eot, svg, ttf, woff

TagsNo tags attached.
Bug heat12
Story point estimate
Users affected %

Users monitoring this issue

JanE

Activities

DenisChenu

DenisChenu

2015-04-13 12:39

developer   ~31988

Use application/config/config.php :

https://manual.limesurvey.org/Optional_settings#Note

'config'=>array(
    'debug'=>0,
    'debugsql'=>0,
    'allowedtemplateuploads'=>'gif,ico,jpg,png,css,js,map,json,eot,svg,ttf,woff',
)
tammo

tammo

2015-04-13 12:43

partner   ~31989

Hi Denis, I guess many users will not find this workaround. Is there an objection to add the named extensions to the file?

DenisChenu

DenisChenu

2015-04-13 12:44

developer   ~31990

It's not a workaround : official manual.

Mazi

Mazi

2015-04-13 12:52

updater   ~31991

I see no reason for not allowing these files types to be accepted at template upload. They can do no harm and I have seen several users complaining about not being able to upload e.g. font files.

DenisChenu

DenisChenu

2015-04-13 13:00

developer   ~31992

Then : why not adding : pdf, html, txt, mp3 ...
Just deactivate the settings.

JanE

JanE

2015-04-13 13:13

reporter   ~31993

Font files are nowadays rather common parts of a template. PDF and the like are not.
BTW, a pull request is here: https://github.com/LimeSurvey/LimeSurvey/pull/310

c_schmitz

c_schmitz

2015-04-13 13:25

administrator   ~31994

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15092

c_schmitz

c_schmitz

2015-04-13 13:32

administrator   ~31995

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15093

tammo

tammo

2015-08-05 08:33

partner   ~32883

Please close this bug report, since it was solved.

Related Changesets

LimeSurvey: master 515277bc

2015-04-13 11:25:39

c_schmitz

Details Diff
Merge pull request #310 from Jan-E/master

Fixed issue 09601: Allow uploads of font files
Affected Issues
09601
mod - application/config/config-defaults.php Diff File

LimeSurvey: 2.06 85d72f34

2015-04-13 11:32:37

c_schmitz

Details Diff
Fixed issue 09601: Allow uploads of font files in template editor Affected Issues
09601
mod - application/config/config-defaults.php Diff File

Issue History

Date Modified Username Field Change
2015-04-13 12:11 tammo New Issue
2015-04-13 12:39 DenisChenu Note Added: 31988
2015-04-13 12:39 JanE Issue Monitored: JanE
2015-04-13 12:43 tammo Note Added: 31989
2015-04-13 12:44 DenisChenu Note Added: 31990
2015-04-13 12:52 Mazi Note Added: 31991
2015-04-13 13:00 DenisChenu Note Added: 31992
2015-04-13 13:13 JanE Note Added: 31993
2015-04-13 13:25 c_schmitz Changeset attached => LimeSurvey master 515277bc
2015-04-13 13:25 c_schmitz Note Added: 31994
2015-04-13 13:25 c_schmitz Assigned To => c_schmitz
2015-04-13 13:25 c_schmitz Resolution open => fixed
2015-04-13 13:32 c_schmitz Changeset attached => LimeSurvey 2.06 85d72f34
2015-04-13 13:32 c_schmitz Note Added: 31995
2015-08-05 08:33 tammo Note Added: 32883
2015-08-05 10:49 c_schmitz Status new => assigned
2015-08-05 10:49 c_schmitz Status assigned => closed
2015-08-05 10:49 c_schmitz Fixed in Version => 2.06+
2015-12-11 14:40 c_schmitz Category Templates => Theme editor
2021-08-02 18:37 guest Bug heat 10 => 12