View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
09448Bug reportsSurvey editingpublic2015-01-09 12:252015-05-20 11:11
ReporterDenisChenu Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Fixed in Version2.05+ 
Summary09448: Label set update : can remove existing language
Description

If you use Save as label set / Replace existing label set to replace a label where there are a language not in survey : this delete language in existing label set if language don't exist in survey

Steps To Reproduce
  • Create a label set with EN/DE (for example)
  • Create a EN survey
  • Add a question and used 'Save as label set / replace'
  • Go to the lable set : DE exist but is empty (and can not be updated : trying to udate send notice : Undefined property: stdClass::$text_en )
Additional Information

Actually (i think) we delete ALL lable sets and add it again after. We must use

  • find by code and update
  • add it f not find (and add it in any language in the label).
TagsNo tags attached.
Attached Files
Capture du 2015-01-09 12:16:31.png (56,283 bytes)   
Capture du 2015-01-09 12:16:31.png (56,283 bytes)   
Bug heat4
Complete LimeSurvey version number (& build)150109
I will donate to the project if issue is resolvedNo
BrowserFF
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

Relationship GraphDependency Graph
related to 09449 closedc_schmitz Label set update remove all existing Assessment value 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2015-01-30 15:54

administrator   ~31576

I think what needs to be done is that a warning should be shown if the original label set contains more/different languages then the one being saved.

If the user still decides to save it then it is their decision.

Keeping track what single label might or might not be deleted/added/renamed is not possible.
DenisChenu

DenisChenu

2015-01-30 16:27

developer   ~31577

Last edited: 2015-01-30 16:28

I think :

  • Replace allways code (delete non existing code)
  • For each code : if language exist in new label : replace
  • If not : Use existing label if exist before (keep before delete)

I can take it if needed for improvment of fix.

Here the big problem : i have a label set with 3 language but only 2 language are set. I can not fix the English language
c_schmitz

c_schmitz

2015-05-11 12:58

administrator   ~32165

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15162
c_schmitz

c_schmitz

2015-05-11 13:00

administrator   ~32166

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15163
c_schmitz

c_schmitz

2015-05-20 11:11

administrator   ~32246

Version 2.05+ Build 150520 released.

Related Changesets

LimeSurvey: master f340431c

2015-05-11 12:58

c_schmitz


Details Diff		 Fixed issue 09448: Label set update : can remove existing language
Dev Proper warnings are shown if languages or assessment values might be lost		 Affected Issues
09448
mod - application/controllers/admin/questions.php Diff File
mod - application/views/admin/survey/Question/answerOptions_view.php Diff File
mod - application/views/admin/survey/Question/subQuestion_view.php Diff File
mod - scripts/admin/answers.js Diff File
mod - scripts/admin/subquestions.js Diff File

LimeSurvey: 2.06 8f4f8a29

2015-05-11 13:00

c_schmitz


Details Diff		 Fixed issue 09448: Label set update : can remove existing language
Dev Proper warnings are shown if languages or assessment values might be lost		 Affected Issues
09448
mod - application/controllers/admin/questions.php Diff File
mod - application/views/admin/survey/Question/answerOptions_view.php Diff File
mod - application/views/admin/survey/Question/subQuestion_view.php Diff File
mod - scripts/admin/answers.js Diff File
mod - scripts/admin/subquestions.js Diff File

Issue History

Date Modified Username Field Change
2015-01-09 12:25 DenisChenu New Issue
2015-01-09 12:25 DenisChenu File Added: Capture du 2015-01-09 12:16:31.png
2015-01-09 12:29 DenisChenu Relationship added related to 09449
2015-01-30 15:54 c_schmitz Note Added: 31576
2015-01-30 16:27 DenisChenu Note Added: 31577
2015-01-30 16:28 DenisChenu Note Edited: 31577
2015-02-02 11:23 c_schmitz Assigned To => c_schmitz
2015-02-02 11:23 c_schmitz Status new => assigned
2015-05-11 12:58 c_schmitz Changeset attached => LimeSurvey master f340431c
2015-05-11 12:58 c_schmitz Note Added: 32165
2015-05-11 12:58 c_schmitz Resolution open => fixed
2015-05-11 13:00 c_schmitz Changeset attached => LimeSurvey 2.06 8f4f8a29
2015-05-11 13:00 c_schmitz Note Added: 32166
2015-05-11 13:00 c_schmitz Status assigned => resolved
2015-05-11 13:00 c_schmitz Fixed in Version => 2.05+
2015-05-20 11:11 c_schmitz Note Added: 32246
2015-05-20 11:11 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing