View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 09285 | Bug reports | Survey taking | public | 2014-10-08 10:53 | 2014-11-13 17:11 |
| Reporter | DenisChenu | Assigned To | DenisChenu | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 2.05+ | ||||
| Fixed in Version | 2.05+ | ||||
| Summary | 09285: Index complet + mandatory question :undefined notice | ||||
| Description | With complete index + mandatory array question type (at step > 1) : you can have undefined notice | ||||
| Steps To Reproduce | Set debug > 1 | ||||
| Additional Information | $notanswered get surely only the question, not the subquestion. 2 way to fix it :
| ||||
| Tags | No tags attached. | ||||
| Attached Files | PHP notice.html (21,472 bytes)
<!DOCTYPE html PUBLIC
"-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
<title>PHP notice</title>
<style type="text/css">
/*<![CDATA[*/
html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;}
body{line-height:1;}
ol,ul{list-style:none;}
blockquote,q{quotes:none;}
blockquote:before,blockquote:after,q:before,q:after{content:none;}
:focus{outline:0;}
ins{text-decoration:none;}
del{text-decoration:line-through;}
table{border-collapse:collapse;border-spacing:0;}
body {
font: normal 9pt "Verdana";
color: #000;
background: #fff;
}
h1 {
font: normal 18pt "Verdana";
color: #f00;
margin-bottom: .5em;
}
h2 {
font: normal 14pt "Verdana";
color: #800000;
margin-bottom: .5em;
}
h3 {
font: bold 11pt "Verdana";
}
pre {
font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace;
}
pre span.error {
display: block;
background: #fce3e3;
}
pre span.ln {
color: #999;
padding-right: 0.5em;
border-right: 1px solid #ccc;
}
pre span.error-ln {
font-weight: bold;
}
.container {
margin: 1em 4em;
}
.version {
color: gray;
font-size: 8pt;
border-top: 1px solid #aaa;
padding-top: 1em;
margin-bottom: 1em;
}
.message {
color: #000;
padding: 1em;
font-size: 11pt;
background: #f3f3f3;
-webkit-border-radius: 10px;
-moz-border-radius: 10px;
border-radius: 10px;
margin-bottom: 1em;
line-height: 160%;
}
.source {
margin-bottom: 1em;
}
.code pre {
background-color: #ffe;
margin: 0.5em 0;
padding: 0.5em;
line-height: 125%;
border: 1px solid #eee;
}
.source .file {
margin-bottom: 1em;
font-weight: bold;
}
.traces {
margin: 2em 0;
}
.trace {
margin: 0.5em 0;
padding: 0.5em;
}
.trace.app {
border: 1px dashed #c00;
}
.trace .number {
text-align: right;
width: 2em;
padding: 0.5em;
}
.trace .content {
padding: 0.5em;
}
.trace .plus,
.trace .minus {
display:inline;
vertical-align:middle;
text-align:center;
border:1px solid #000;
color:#000;
font-size:10px;
line-height:10px;
margin:0;
padding:0 1px;
width:10px;
height:10px;
}
.trace.collapsed .minus,
.trace.expanded .plus,
.trace.collapsed pre {
display: none;
}
.trace-file {
cursor: pointer;
padding: 0.2em;
}
.trace-file:hover {
background: #f0ffff;
}
/*]]>*/
</style>
</head>
<body>
<div class="container">
<h1>PHP notice</h1>
<p class="message">
Undefined index: 696427X1932X42024SQ001 </p>
<div class="source">
<p class="file">/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/helpers/qanda_helper.php(4659)</p>
<div class="code"><pre><span class="ln">4647</span> $answertext = $ansrow['question'];
<span class="ln">4648</span> $answertextsave=$answertext;
<span class="ln">4649</span> if (strpos($answertext,'|'))
<span class="ln">4650</span> {
<span class="ln">4651</span> $answertext=substr($answertext,0, strpos($answertext,'|'));
<span class="ln">4652</span> }
<span class="ln">4653</span> /* Check if this item has not been answered: the 'notanswered' variable must be an array,
<span class="ln">4654</span> containing a list of unanswered questions, the current question must be in the array,
<span class="ln">4655</span> and there must be no answer available for the item in this session. */
<span class="ln">4656</span>
<span class="ln">4657</span> if (strpos($answertext,'|')) {$answerwidth=$answerwidth/2;}
<span class="ln">4658</span>
<span class="error"><span class="ln error-ln">4659</span> if ($ia[6]=='Y' && (is_array($notanswered)) && (array_search($myfname, $notanswered) !== FALSE) && ($_SESSION['survey_'.Yii::app()->getConfig('surveyID')][$myfname] == '') ) {
</span><span class="ln">4660</span> $answertext = '<span class="errormandatory">'.$answertext.'</span>';
<span class="ln">4661</span> }
<span class="ln">4662</span> // Get array_filter stuff
<span class="ln">4663</span> //
<span class="ln">4664</span> // TMSW - is this correct?
<span class="ln">4665</span> $trbc = alternation($trbc , 'row');
<span class="ln">4666</span> list($htmltbody2, $hiddenfield)=return_array_filter_strings($ia, $aQuestionAttributes, $thissurvey, $ansrow, $myfname, $trbc, $myfname,"tr","$trbc answers-list radio-list");
<span class="ln">4667</span> $fn++;
<span class="ln">4668</span> $answer .= $htmltbody2;
<span class="ln">4669</span>
<span class="ln">4670</span> $answer .= "\t<th class=\"answertext\">\n$answertext"
<span class="ln">4671</span> . $hiddenfield
</pre></div> </div>
<div class="traces">
<h2>Stack Trace</h2>
<table style="width:100%;">
<tr class="trace app expanded">
<td class="number">
#0 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/helpers/qanda_helper.php(265): <strong>do_array</strong>(array("42024", "696427X1932X42024", "ARRAY", "An array : this launch undefined notice with index", ...)) </div>
<div class="code"><pre><span class="ln">260</span> break;
<span class="ln">261</span> case 'E': //ARRAY (Increase/Same/Decrease) radio-buttons
<span class="ln">262</span> $values=do_array_increasesamedecrease($ia);
<span class="ln">263</span> break;
<span class="ln">264</span> case 'F': //ARRAY (Flexible) - Row Format
<span class="error"><span class="ln error-ln">265</span> $values=do_array($ia);
</span><span class="ln">266</span> break;
<span class="ln">267</span> case 'H': //ARRAY (Flexible) - Column Format
<span class="ln">268</span> $values=do_arraycolumns($ia);
<span class="ln">269</span> break;
<span class="ln">270</span> case ':': //ARRAY (Multi Flexi) 1 to 10
</pre></div> </td>
</tr>
<tr class="trace app expanded">
<td class="number">
#1 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/helpers/SurveyRuntimeHelper.php(860): <strong>retrieveAnswers</strong>(array("42024", "696427X1932X42024", "ARRAY", "An array : this launch undefined notice with index", ...), "696427") </div>
<div class="code"><pre><span class="ln">855</span> }
<span class="ln">856</span>
<span class="ln">857</span> //Get the answers/inputnames
<span class="ln">858</span> // TMSW - can content of retrieveAnswers() be provided by LEM? Review scope of what it provides.
<span class="ln">859</span> // TODO - retrieveAnswers is slow - queries database separately for each question. May be fixed in _CI or _YII ports, so ignore for now
<span class="error"><span class="ln error-ln">860</span> list($plus_qanda, $plus_inputnames) = retrieveAnswers($ia, $surveyid);
</span><span class="ln">861</span> if ($plus_qanda)
<span class="ln">862</span> {
<span class="ln">863</span> $plus_qanda[] = $ia[4];
<span class="ln">864</span> $plus_qanda[] = $ia[6]; // adds madatory identifyer for adding mandatory class to question wrapping div
<span class="ln">865</span> // Add a finalgroup in qa array , needed for random attribute : TODO: find a way to have it in new quanda_helper in 2.1
</pre></div> </td>
</tr>
<tr class="trace app expanded">
<td class="number">
#2 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/controllers/survey/index.php(571): <strong>SurveyRuntimeHelper</strong>-><strong>run</strong>("696427", array("surveyid" => "696427", "thissurvey" => array("sid" => "696427", "owner_id" => "1", "admin" => "Denis Chenu", "active" => "Y", ...), "thisstep" => "1", "tokensexist" => 0, ...)) </div>
<div class="code"><pre><span class="ln">566</span> //Send local variables to the appropriate survey type
<span class="ln">567</span> unset($redata);
<span class="ln">568</span> $redata = compact(array_keys(get_defined_vars()));
<span class="ln">569</span> Yii::import('application.helpers.SurveyRuntimeHelper');
<span class="ln">570</span> $tmp = new SurveyRuntimeHelper();
<span class="error"><span class="ln error-ln">571</span> $tmp->run($surveyid,$redata);
</span><span class="ln">572</span>
<span class="ln">573</span> if (isset($_POST['saveall']) || isset($flashmessage))
<span class="ln">574</span> {
<span class="ln">575</span> echo "<script type='text/javascript'> $(document).ready( function() { alert('".$clang->gT("Your responses were successfully saved.","js")."');}) </script>";
<span class="ln">576</span> }
</pre></div> </td>
</tr>
<tr class="trace app collapsed">
<td class="number">
#3 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/controllers/survey/index.php(46): <strong>index</strong>-><strong>action</strong>() </div>
<div class="code"><pre><span class="ln">41</span> App()->getClientScript()->render($buffer);
<span class="ln">42</span> App()->getClientScript()->reset();
<span class="ln">43</span> return $buffer;
<span class="ln">44</span> });
<span class="ln">45</span> ob_implicit_flush(false);
<span class="error"><span class="ln error-ln">46</span> $this->action();
</span><span class="ln">47</span> ob_flush();
<span class="ln">48</span> }
<span class="ln">49</span>
<span class="ln">50</span> function action()
<span class="ln">51</span> {
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#4 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/actions/CAction.php(76): <strong>index</strong>-><strong>run</strong>() </div>
<div class="code"><pre><span class="ln">71</span> {
<span class="ln">72</span> $method=new ReflectionMethod($this, 'run');
<span class="ln">73</span> if($method->getNumberOfParameters()>0)
<span class="ln">74</span> return $this->runWithParamsInternal($this, $method, $params);
<span class="ln">75</span> else
<span class="error"><span class="ln error-ln">76</span> return $this->run();
</span><span class="ln">77</span> }
<span class="ln">78</span>
<span class="ln">79</span> /**
<span class="ln">80</span> * Executes a method of an object with the supplied named parameters.
<span class="ln">81</span> * This method is internally used.
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#5 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CController.php(308): <strong>CAction</strong>-><strong>runWithParams</strong>(array()) </div>
<div class="code"><pre><span class="ln">303</span> {
<span class="ln">304</span> $priorAction=$this->_action;
<span class="ln">305</span> $this->_action=$action;
<span class="ln">306</span> if($this->beforeAction($action))
<span class="ln">307</span> {
<span class="error"><span class="ln error-ln">308</span> if($action->runWithParams($this->getActionParams())===false)
</span><span class="ln">309</span> $this->invalidActionParams($action);
<span class="ln">310</span> else
<span class="ln">311</span> $this->afterAction($action);
<span class="ln">312</span> }
<span class="ln">313</span> $this->_action=$priorAction;
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#6 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CController.php(286): <strong>CController</strong>-><strong>runAction</strong>(index) </div>
<div class="code"><pre><span class="ln">281</span> * @see runAction
<span class="ln">282</span> */
<span class="ln">283</span> public function runActionWithFilters($action,$filters)
<span class="ln">284</span> {
<span class="ln">285</span> if(empty($filters))
<span class="error"><span class="ln error-ln">286</span> $this->runAction($action);
</span><span class="ln">287</span> else
<span class="ln">288</span> {
<span class="ln">289</span> $priorAction=$this->_action;
<span class="ln">290</span> $this->_action=$action;
<span class="ln">291</span> CFilterChain::create($this,$action,$filters)->run();
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#7 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>(index, array()) </div>
<div class="code"><pre><span class="ln">260</span> {
<span class="ln">261</span> if(($parent=$this->getModule())===null)
<span class="ln">262</span> $parent=Yii::app();
<span class="ln">263</span> if($parent->beforeControllerAction($this,$action))
<span class="ln">264</span> {
<span class="error"><span class="ln error-ln">265</span> $this->runActionWithFilters($action,$this->filters());
</span><span class="ln">266</span> $parent->afterControllerAction($this,$action);
<span class="ln">267</span> }
<span class="ln">268</span> }
<span class="ln">269</span> else
<span class="ln">270</span> $this->missingAction($actionID);
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#8 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CWebApplication.php(282): <strong>CController</strong>-><strong>run</strong>("index") </div>
<div class="code"><pre><span class="ln">277</span> {
<span class="ln">278</span> list($controller,$actionID)=$ca;
<span class="ln">279</span> $oldController=$this->_controller;
<span class="ln">280</span> $this->_controller=$controller;
<span class="ln">281</span> $controller->init();
<span class="error"><span class="ln error-ln">282</span> $controller->run($actionID);
</span><span class="ln">283</span> $this->_controller=$oldController;
<span class="ln">284</span> }
<span class="ln">285</span> else
<span class="ln">286</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".',
<span class="ln">287</span> array('{route}'=>$route===''?$this->defaultController:$route)));
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#9 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>("survey/index") </div>
<div class="code"><pre><span class="ln">136</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value)
<span class="ln">137</span> $_GET[$name]=$value;
<span class="ln">138</span> }
<span class="ln">139</span> else
<span class="ln">140</span> $route=$this->getUrlManager()->parseUrl($this->getRequest());
<span class="error"><span class="ln error-ln">141</span> $this->runController($route);
</span><span class="ln">142</span> }
<span class="ln">143</span>
<span class="ln">144</span> /**
<span class="ln">145</span> * Registers the core application components.
<span class="ln">146</span> * This method overrides the parent implementation by registering additional core components.
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#10 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/base/CApplication.php(180): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div>
<div class="code"><pre><span class="ln">175</span> public function run()
<span class="ln">176</span> {
<span class="ln">177</span> if($this->hasEventHandler('onBeginRequest'))
<span class="ln">178</span> $this->onBeginRequest(new CEvent($this));
<span class="ln">179</span> register_shutdown_function(array($this,'end'),0,false);
<span class="error"><span class="ln error-ln">180</span> $this->processRequest();
</span><span class="ln">181</span> if($this->hasEventHandler('onEndRequest'))
<span class="ln">182</span> $this->onEndRequest(new CEvent($this));
<span class="ln">183</span> }
<span class="ln">184</span>
<span class="ln">185</span> /**
</pre></div> </td>
</tr>
<tr class="trace app collapsed">
<td class="number">
#11 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/index.php(200): <strong>CApplication</strong>-><strong>run</strong>() </div>
<div class="code"><pre><span class="ln">195</span> die (sprintf('%s should be writable by the webserver (755 or 775).', $runtimePath));
<span class="ln">196</span> }
<span class="ln">197</span> }
<span class="ln">198</span>
<span class="ln">199</span>
<span class="error"><span class="ln error-ln">200</span> Yii::createApplication('LSYii_Application', $config)->run();
</span><span class="ln">201</span>
<span class="ln">202</span> /* End of file index.php */
<span class="ln">203</span> /* Location: ./index.php */
</pre></div> </td>
</tr>
</table>
</div>
<div class="version">
2014-10-08 10:48:38 Apache/2.2.22 (Debian) <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.15 </div>
</div>
<script type="text/javascript">
/*<![CDATA[*/
var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)");
var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)");
var e = document.getElementsByTagName("div");
for(var j=0,len=e.length;j<len;j++){
if(traceReg.test(e[j].className)){
e[j].onclick = function(){
var trace = this.parentNode.parentNode;
if(collapsedReg.test(trace.className))
trace.className = trace.className.replace("collapsed", "expanded");
else
trace.className = trace.className.replace("expanded", "collapsed");
}
}
}
/*]]>*/
</script>
</body>
</html>
| ||||
| Bug heat | 4 | ||||
| Complete LimeSurvey version number (& build) | 141008 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | not relevant | ||||
| Database type & version | mysql | ||||
| Server OS (if known) | debian/linux | ||||
| Webserver software & version (if known) | apache | ||||
| PHP Version | PHP Version 5.4.4 | ||||
| related to | 09198 | closed | DenisChenu | complete group's navigation can stop before clicked group |
 |
With debug=0 : all sub question seems invalid |
|
|
OK, got it. The index validate all the group, then ending to the last group : $stepInfo = LimeExpressionManager::singleton()->_ValidateGroup($key); Then somewhere $moveResult = LimeExpressionManager::GetLastMoveResult(true); get the moveresult of all survey (or the last group ? not sure). Then we msut somewhere set $moveResult to array() if index==2 and move!=movenext/movesubmit. |
|
|
... |
|
|
Please try and do a lot of different test with https://github.com/LimeSurvey/LimeSurvey/pull/227 |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14620 |
 |
Version 2.05 Build 141113 released |
|
LimeSurvey: master be983708 2014-11-01 17:47 Details Diff |
Fixed issue 09328: Language changer causes warning for mandatory questions Fixed issue 09285: Index complet + mandatory question :undefined notice Fixed issue 09198: complete group's navigation can stop before clicked group Fixed issue 08806: questionindex to 2 allow invalid survey submitted Dev: use $force in _validateGroup and _validateQuestion Dev: this allow save value in DB for equation and some other, but never return error. Dev: update EM, then need testing |
Affected Issues 08806, 09198, 09285, 09328 |
|
| mod - application/helpers/SurveyRuntimeHelper.php | Diff File | ||
| mod - application/helpers/expressions/em_manager_helper.php | Diff File | ||
|
LimeSurvey: master 3f5fbf78 2014-11-10 17:34 Details Diff |
Dev: refix 09285 2 : condition : go after, do to : broke Dev: Adding $_SESSION[$LEM->sessid][$answer]=null in _validateQuestion , this ensure using $_SESSION[$LEM->sessid][$answer] Dev: then remove the quick fix at qanda_helper only for $ia[1] (without sub question) Dev: remove global $notanswered at each do_ function, get it by GetLastMoveResult |
Affected Issues 09285 |
|
| mod - application/helpers/SurveyRuntimeHelper.php | Diff File | ||
| mod - application/helpers/expressions/em_manager_helper.php | Diff File | ||
| mod - application/helpers/qanda_helper.php | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-10-08 10:53 | DenisChenu | New Issue | |
| 2014-10-08 10:53 | DenisChenu | File Added: PHP notice.html | |
| 2014-10-08 10:53 | DenisChenu | File Added: limesurvey_survey_brokenindex.lss | |
| 2014-10-08 11:29 | DenisChenu | Note Added: 30749 | |
| 2014-10-09 16:37 | DenisChenu | Relationship added | related to 09198 |
| 2014-10-10 10:07 | DenisChenu | Note Added: 30758 | |
| 2014-10-10 14:05 | c_schmitz | Assigned To | => DenisChenu |
| 2014-10-10 14:05 | c_schmitz | Status | new => assigned |
| 2014-10-14 09:51 | DenisChenu | Note Added: 30796 | |
| 2014-10-17 08:18 | DenisChenu | Note Added: 30805 | |
| 2014-11-13 16:33 | DenisChenu | Changeset attached | => LimeSurvey master be983708 |
| 2014-11-13 16:33 | DenisChenu | Changeset attached | => LimeSurvey master 3f5fbf78 |
| 2014-11-13 16:33 | DenisChenu | Note Added: 30975 | |
| 2014-11-13 16:33 | DenisChenu | Resolution | open => fixed |
| 2014-11-13 16:37 | DenisChenu | Status | assigned => resolved |
| 2014-11-13 16:37 | DenisChenu | Fixed in Version | => 2.05+ |
| 2014-11-13 17:11 | c_schmitz | Note Added: 30981 | |
| 2014-11-13 17:11 | c_schmitz | Status | resolved => closed |
