View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
09140Bug reportsSurvey takingpublic2014-07-09 22:352015-02-12 10:57
Reporterronny_todgers Assigned Toc_schmitz  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.05+ 
Fixed in Version2.05+ 
Summary09140: end users shown that a survey has been saved even if it hasn't - no useful error logs
Description

The VV export and import is a fantastic utility for preserving data between minor tweaks to a survey. Frequently I have had to add a question to a live survey and the technique I have used is to run a vv export, disable, make the change and reimport the data. It works great - except in 2.05 what now happens is that adding a new question and re enabling the survey generates a new id_seq ( eg id_seq1,2 etc.)

This means that my technique no longer works and I'm 99% sure it did work in 2.00

So recently I did this and then the got reports that data wan't getting saved - I noticed Postgres errors saying that inserts had failed as the ID already existed - however on doing the survey myself I found that the end page said thank you your responses have been saved.

In other words even though there was a major error which prevented saving the data - the end user didn't see this ( at which point they would have alerted the admin and there seems to be no attempt to preserve the data in such a situation - raise an error and dump it to the log?

Steps To Reproduce

create a simple survey - eg the one attached, activate it
make some data
do a vv export
deactivate and add a question then reactivate
do a vv import
everything looks great!
do the survey - success reported at the end
check for the data, the new record isn't there
check your error logs

Additional Information

Perhaps my use in this fashion is unsupported and that's fine I obviously takes my chances however it seems that Limesurvey hasn't behaved impeccably either given the critical error

TagsNo tags attached.
Attached Files
survey_archive_135891.lsa (3,178 bytes)
vvexport_213695.csv (339 bytes)    
Response ID	token	Date submitted	Last page	Start language		some text	content of above is {text}	its a new un	
id	token	submitdate	lastpage	startlanguage	testage	text	text2	extraQ	
1	{question_not_shown}	1980-01-01 00:00:00	1	en	Y	blah		{question_not_shown}
2	{question_not_shown}	1980-01-01 00:00:00	1	en	N	otherblah		{question_not_shown}
vvexport_213695.csv (339 bytes)   
vvexport_135891.csv (9,822 bytes)    
Response ID	token	Date submitted	Last page	Start language		some text	content of above is {text}	its a new un	
id	token	submitdate	lastpage	startlanguage	testage	text	text2	extraQ	NewOne
4	{question_not_shown}	1980-01-01 00:00:00	1	en	Y			{question_not_shown}	
5	{question_not_shown}	1980-01-01 00:00:00	1	en	N			{question_not_shown}	
6	{question_not_shown}	1980-01-01 00:00:00	1	en	Y				
7	{question_not_shown}	1980-01-01 00:00:01	2	en	Y				
8	{question_not_shown}	1980-01-01 00:00:02	3	en	Y				
9	{question_not_shown}	1980-01-01 00:00:03	4	en	Y				
10	{question_not_shown}	1980-01-01 00:00:04	5	en	Y				
11	{question_not_shown}	1980-01-01 00:00:05	6	en	Y				
12	{question_not_shown}	1980-01-01 00:00:06	7	en	Y				
13	{question_not_shown}	1980-01-01 00:00:07	8	en	Y				
14	{question_not_shown}	1980-01-01 00:00:08	9	en	Y				
15	{question_not_shown}	1980-01-01 00:00:09	10	en	Y				
16	{question_not_shown}	1980-01-01 00:00:10	11	en	Y				
17	{question_not_shown}	1980-01-01 00:00:11	12	en	Y				
18	{question_not_shown}	1980-01-01 00:00:12	13	en	Y				
19	{question_not_shown}	1980-01-01 00:00:13	14	en	Y				
20	{question_not_shown}	1980-01-01 00:00:14	15	en	Y				
21	{question_not_shown}	1980-01-01 00:00:15	16	en	Y				
22	{question_not_shown}	1980-01-01 00:00:16	17	en	Y				
23	{question_not_shown}	1980-01-01 00:00:17	18	en	Y				
24	{question_not_shown}	1980-01-01 00:00:18	19	en	Y				
25	{question_not_shown}	1980-01-01 00:00:19	20	en	Y				
26	{question_not_shown}	1980-01-01 00:00:20	21	en	Y				
27	{question_not_shown}	1980-01-01 00:00:21	22	en	Y				
28	{question_not_shown}	1980-01-01 00:00:22	23	en	Y				
29	{question_not_shown}	1980-01-01 00:00:23	24	en	Y				
30	{question_not_shown}	1980-01-01 00:00:24	25	en	Y				
31	{question_not_shown}	1980-01-01 00:00:25	26	en	Y				
32	{question_not_shown}	1980-01-01 00:00:26	27	en	Y				
33	{question_not_shown}	1980-01-01 00:00:27	28	en	Y				
34	{question_not_shown}	1980-01-01 00:00:28	29	en	Y				
35	{question_not_shown}	1980-01-01 00:00:29	30	en	Y				
36	{question_not_shown}	1980-01-01 00:00:30	31	en	Y				
37	{question_not_shown}	1980-01-01 00:00:31	32	en	Y				
38	{question_not_shown}	1980-01-01 00:00:32	33	en	Y				
39	{question_not_shown}	1980-01-01 00:00:33	34	en	Y				
40	{question_not_shown}	1980-01-01 00:00:34	35	en	Y				
41	{question_not_shown}	1980-01-01 00:00:35	36	en	Y				
42	{question_not_shown}	1980-01-01 00:00:36	37	en	Y				
43	{question_not_shown}	1980-01-01 00:00:37	38	en	Y				
44	{question_not_shown}	1980-01-01 00:00:38	39	en	Y				
45	{question_not_shown}	1980-01-01 00:00:39	40	en	Y				
46	{question_not_shown}	1980-01-01 00:00:40	41	en	Y				
47	{question_not_shown}	1980-01-01 00:00:41	42	en	Y				
48	{question_not_shown}	1980-01-01 00:00:42	43	en	Y				
49	{question_not_shown}	1980-01-01 00:00:43	44	en	Y				
50	{question_not_shown}	1980-01-01 00:00:44	45	en	Y				
51	{question_not_shown}	1980-01-01 00:00:45	46	en	Y				
52	{question_not_shown}	1980-01-01 00:00:46	47	en	Y				
53	{question_not_shown}	1980-01-01 00:00:47	48	en	Y				
54	{question_not_shown}	1980-01-01 00:00:48	49	en	Y				
55	{question_not_shown}	1980-01-01 00:00:49	50	en	Y				
56	{question_not_shown}	1980-01-01 00:00:50	51	en	Y				
57	{question_not_shown}	1980-01-01 00:00:51	52	en	Y				
58	{question_not_shown}	1980-01-01 00:00:52	53	en	Y				
59	{question_not_shown}	1980-01-01 00:00:53	54	en	Y				
60	{question_not_shown}	1980-01-01 00:00:54	55	en	Y				
61	{question_not_shown}	1980-01-01 00:00:55	56	en	Y				
62	{question_not_shown}	1980-01-01 00:00:56	57	en	Y				
63	{question_not_shown}	1980-01-01 00:00:57	58	en	Y				
64	{question_not_shown}	1980-01-01 00:00:58	59	en	Y				
65	{question_not_shown}	1980-01-01 00:00:59	60	en	Y				
66	{question_not_shown}	1980-01-01 00:00:60	61	en	Y				
67	{question_not_shown}	1980-01-01 00:00:61	62	en	Y				
68	{question_not_shown}	1980-01-01 00:00:62	63	en	Y				
69	{question_not_shown}	1980-01-01 00:00:63	64	en	Y				
70	{question_not_shown}	1980-01-01 00:00:64	65	en	Y				
71	{question_not_shown}	1980-01-01 00:00:65	66	en	Y				
72	{question_not_shown}	1980-01-01 00:00:66	67	en	Y				
73	{question_not_shown}	1980-01-01 00:00:67	68	en	Y				
74	{question_not_shown}	1980-01-01 00:00:68	69	en	Y				
75	{question_not_shown}	1980-01-01 00:00:69	70	en	Y				
76	{question_not_shown}	1980-01-01 00:00:70	71	en	Y				
77	{question_not_shown}	1980-01-01 00:00:71	72	en	Y				
78	{question_not_shown}	1980-01-01 00:00:72	73	en	Y				
79	{question_not_shown}	1980-01-01 00:00:73	74	en	Y				
80	{question_not_shown}	1980-01-01 00:00:74	75	en	Y				
81	{question_not_shown}	1980-01-01 00:00:75	76	en	Y				
82	{question_not_shown}	1980-01-01 00:00:76	77	en	Y				
83	{question_not_shown}	1980-01-01 00:00:77	78	en	Y				
84	{question_not_shown}	1980-01-01 00:00:78	79	en	Y				
85	{question_not_shown}	1980-01-01 00:00:79	80	en	Y				
86	{question_not_shown}	1980-01-01 00:00:80	81	en	Y				
87	{question_not_shown}	1980-01-01 00:00:81	82	en	Y				
88	{question_not_shown}	1980-01-01 00:00:82	83	en	Y				
89	{question_not_shown}	1980-01-01 00:00:83	84	en	Y				
90	{question_not_shown}	1980-01-01 00:00:84	85	en	Y				
91	{question_not_shown}	1980-01-01 00:00:85	86	en	Y				
92	{question_not_shown}	1980-01-01 00:00:86	87	en	Y				
93	{question_not_shown}	1980-01-01 00:00:87	88	en	Y				
94	{question_not_shown}	1980-01-01 00:00:88	89	en	Y				
95	{question_not_shown}	1980-01-01 00:00:89	90	en	Y				
96	{question_not_shown}	1980-01-01 00:00:90	91	en	Y				
97	{question_not_shown}	1980-01-01 00:00:91	92	en	Y				
98	{question_not_shown}	1980-01-01 00:00:92	93	en	Y				
99	{question_not_shown}	1980-01-01 00:00:93	94	en	Y				
100	{question_not_shown}	1980-01-01 00:00:94	95	en	Y				
101	{question_not_shown}	1980-01-01 00:00:95	96	en	Y				
102	{question_not_shown}	1980-01-01 00:00:96	97	en	Y				
103	{question_not_shown}	1980-01-01 00:00:97	98	en	Y				
104	{question_not_shown}	1980-01-01 00:00:98	99	en	Y				
105	{question_not_shown}	1980-01-01 00:00:99	100	en	Y				
106	{question_not_shown}	1980-01-01 00:00:100	101	en	Y				
107	{question_not_shown}	1980-01-01 00:00:101	102	en	Y				
108	{question_not_shown}	1980-01-01 00:00:102	103	en	Y				
109	{question_not_shown}	1980-01-01 00:00:103	104	en	Y				
110	{question_not_shown}	1980-01-01 00:00:104	105	en	Y				
111	{question_not_shown}	1980-01-01 00:00:105	106	en	Y				
112	{question_not_shown}	1980-01-01 00:00:106	107	en	Y				
113	{question_not_shown}	1980-01-01 00:00:107	108	en	Y				
114	{question_not_shown}	1980-01-01 00:00:108	109	en	Y				
115	{question_not_shown}	1980-01-01 00:00:109	110	en	Y				
116	{question_not_shown}	1980-01-01 00:00:110	111	en	Y				
117	{question_not_shown}	1980-01-01 00:00:111	112	en	Y				
118	{question_not_shown}	1980-01-01 00:00:112	113	en	Y				
119	{question_not_shown}	1980-01-01 00:00:113	114	en	Y				
120	{question_not_shown}	1980-01-01 00:00:114	115	en	Y				
121	{question_not_shown}	1980-01-01 00:00:115	116	en	Y				
122	{question_not_shown}	1980-01-01 00:00:116	117	en	Y				
123	{question_not_shown}	1980-01-01 00:00:117	118	en	Y				
124	{question_not_shown}	1980-01-01 00:00:118	119	en	Y				
125	{question_not_shown}	1980-01-01 00:00:119	120	en	Y				
126	{question_not_shown}	1980-01-01 00:00:120	121	en	Y				
127	{question_not_shown}	1980-01-01 00:00:121	122	en	Y				
128	{question_not_shown}	1980-01-01 00:00:122	123	en	Y				
129	{question_not_shown}	1980-01-01 00:00:123	124	en	Y				
130	{question_not_shown}	1980-01-01 00:00:124	125	en	Y				
131	{question_not_shown}	1980-01-01 00:00:125	126	en	Y				
132	{question_not_shown}	1980-01-01 00:00:126	127	en	Y				
133	{question_not_shown}	1980-01-01 00:00:127	128	en	Y				
134	{question_not_shown}	1980-01-01 00:00:128	129	en	Y				
135	{question_not_shown}	1980-01-01 00:00:129	130	en	Y				
136	{question_not_shown}	1980-01-01 00:00:130	131	en	Y				
137	{question_not_shown}	1980-01-01 00:00:131	132	en	Y				
138	{question_not_shown}	1980-01-01 00:00:132	133	en	Y				
139	{question_not_shown}	1980-01-01 00:00:133	134	en	Y				
140	{question_not_shown}	1980-01-01 00:00:134	135	en	Y				
141	{question_not_shown}	1980-01-01 00:00:135	136	en	Y				
142	{question_not_shown}	1980-01-01 00:00:136	137	en	Y				
143	{question_not_shown}	1980-01-01 00:00:137	138	en	Y				
144	{question_not_shown}	1980-01-01 00:00:138	139	en	Y				
145	{question_not_shown}	1980-01-01 00:00:139	140	en	Y				
146	{question_not_shown}	1980-01-01 00:00:140	141	en	Y				
147	{question_not_shown}	1980-01-01 00:00:141	142	en	Y				
148	{question_not_shown}	1980-01-01 00:00:142	143	en	Y				
149	{question_not_shown}	1980-01-01 00:00:143	144	en	Y				
150	{question_not_shown}	1980-01-01 00:00:144	145	en	Y				
151	{question_not_shown}	1980-01-01 00:00:145	146	en	Y				
152	{question_not_shown}	1980-01-01 00:00:146	147	en	Y				
153	{question_not_shown}	1980-01-01 00:00:147	148	en	Y				
154	{question_not_shown}	1980-01-01 00:00:148	149	en	Y				
155	{question_not_shown}	1980-01-01 00:00:149	150	en	Y				
156	{question_not_shown}	1980-01-01 00:00:150	151	en	Y				
157	{question_not_shown}	1980-01-01 00:00:151	152	en	Y				
158	{question_not_shown}	1980-01-01 00:00:152	153	en	Y				
159	{question_not_shown}	1980-01-01 00:00:153	154	en	Y				
160	{question_not_shown}	1980-01-01 00:00:154	155	en	Y				
161	{question_not_shown}	1980-01-01 00:00:155	156	en	Y				
162	{question_not_shown}	1980-01-01 00:00:156	157	en	Y				
163	{question_not_shown}	1980-01-01 00:00:157	158	en	Y				
164	{question_not_shown}	1980-01-01 00:00:158	159	en	Y				
165	{question_not_shown}	1980-01-01 00:00:159	160	en	Y				
166	{question_not_shown}	1980-01-01 00:00:160	161	en	Y				
167	{question_not_shown}	1980-01-01 00:00:161	162	en	Y				
168	{question_not_shown}	1980-01-01 00:00:162	163	en	Y				
169	{question_not_shown}	1980-01-01 00:00:163	164	en	Y				
170	{question_not_shown}	1980-01-01 00:00:164	165	en	Y				
171	{question_not_shown}	1980-01-01 00:00:165	166	en	Y
vvexport_135891.csv (9,822 bytes)   
Bug heat10
Complete LimeSurvey version number (& build)140422
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionPostgres 9.1.13
Server OS (if known)Debian 7.4
Webserver software & version (if known)Apache/2.2.22
PHP VersionVersion 5.4.4-14+deb7u9

Relationships

Relationship GraphDependency Graph
related to 09491 closedc_schmitz Id column and Primary key is not generated when the survey is re-activated. 

Users monitoring this issue

DenisChenu, mfaber

Activities

DenisChenu

DenisChenu

2014-07-10 09:14

developer   ~30286

Hi Ronny,

Seems there are 2 issue here:

I take the bug for VV first , but can work on it before end of july
DenisChenu

DenisChenu

2014-07-10 09:20

developer   ~30287

<quote> So recently I did this and then the got reports that data wan't getting saved - I noticed Postgres errors saying that inserts had failed as the ID already existed - however on doing the survey myself I found that the end page said thank you your responses have been saved. </quote>
Did you start survey with newtest=Y or newtest/Y ? Maybe some session issue here : if you stay with same page
ronny_todgers

ronny_todgers

2014-07-10 10:58

reporter   ~30288

Hi Dennis - the problem could be fixed by altering the vv import procedure to update the CORRECT survey_id_seq.

However the bigger problem in my mind is that you can get a critical data losing error - and there is no log and no message displayed to the user - that's a bad thing.

Its nothing to do with sessions and I haven't altered the vv file at all. What I have done is to add a question to the dectivated survey and then imported the original vv file. This succeeds fine and you get a perfect data table with the nex question appropriately empty ( they didn't see it cos it didn't exist )

The vv problem if you want to think of it like that is that it makes no attempt to update the id_seq in the database and so the id_seq has a nextval of 1 but the response table has data in it - in my case 70 records. Which means the next 70 people to do it lose their data without any error messages.

Perhaps the vv file is trying to update the id_seq (I haven't rooted around in the code) in which case the problem is that after you add the question to the sruvey you get a new id_seq (eg id_seq2) and so it is updating the wrong sequence.

I can however see that this might be a significant feature request and maybe the vv import shouldn't be used in this way, my bad and lesson learnt the hard way - that would be fine but the much more significant issue in my mind is that you can have critical data loss with no error messages - that certainly needs to be fixed.
DenisChenu

DenisChenu

2014-07-10 12:02

developer   ~30289

Oh yes, mysql AUTO_INCREMENT work good, but not PGSQL.

Understand :)
DenisChenu

DenisChenu

2014-07-10 12:45

developer   ~30290

Last edited: 2014-07-10 12:54

Yii use SERIAL when create table with PK : no problem here.

Adn :
Can not reproduce on PostgreSQL 8.4.20
ronny_todgers

ronny_todgers

2014-07-10 13:00

reporter   ~30291

Limesurvey is making sequences in postgres by some process - new ones every-time you alter the survey - but the vv import doesn't seem to effect them in any way.

While I think it would be great to make behaviour consistent regardless of the db backend as this is a really handy usage case that comes up quite often. I do really think that the bigger problem here is related to the fact that the first I knew of this was when we discovered the missing data. The survey should not be reported as successfully saved when that isn't actually the case.
ronny_todgers

ronny_todgers

2014-07-10 13:02

reporter   ~30292

Did you follow all my steps when trying to reproduce? you have to alter the survey otherwise the id_seq remains the same
DenisChenu

DenisChenu

2014-07-10 14:18

developer   ~30293

Yes ...
VV import is done in CSVImportResponses

And we use only Yii way.

Can not reproduce on PostgreSQL 9.1.13 too , trying different combination.

Denis
ronny_todgers

ronny_todgers

2014-07-10 14:48

reporter   ~30294

How many _id_seq do you have in your db for the survey after you re-enable with the additional question?

I get two every time i do this and the active one has a nextval of 1.
DenisChenu

DenisChenu

2014-07-23 10:06

developer   ~30318

ronny,

Have some time to test again.

Please : can you provide:
1st :the lsa file before VV import
2nd : the VV foile to be imported : and the checkox checked/unechecked when you import.

Thanks
ronny_todgers

ronny_todgers

2014-07-23 10:16

reporter   ~30319

the lsa file is the one attached already - it includes the responses as well so you just need to hit export as vv file to get it but as you have asked here is the file as well :)

So remember to get the problem you need to:
deactivate the survey
add a new question
then import the vv file

Everything looks good - but do the survey and while it says its been saved - it hasnt - you still have hte two records you had before - look in your db logs and you see the error and the cause (the nextval of the id_seq1)
ronny_todgers

ronny_todgers

2014-07-23 10:18

reporter   ~30320

Would be interesting to know whether you get any php errors from limesurvey in response - I get none but that could be a fault with my logging config.

thanks for looking into this!
DenisChenu

DenisChenu

2014-07-23 10:19

developer   ~30321

Oh yes, please set config to 2 :)
ronny_todgers

ronny_todgers

2014-08-02 11:44

reporter   ~30393

Hi Denis did you manage to reproduce the issue?
DenisChenu

DenisChenu

2014-09-03 11:32

developer   ~30466

@ronny : no, i try to : start the survey, import VV, continue survey. A new survey id is created

Really don't find a way to reproduce issue .

SERIAL is the same than AUTO_INCREMENT.
ronny_todgers

ronny_todgers

2014-09-03 12:13

reporter   ~30469

Hi Denis,
Sorry what do you mean by new survey ID? if you deactivate and reactivate a survey then you shouldn't be getting a new survey ID?

In any case the problem is with the response ID which has a nextval of 1 even after the vv import has added the old records.

Are you saying that you reactivate the survey (it then has 0 responses) then import the VV and you get a nextval bigger than 1? What is your nextval after the import?

I see nothing in CSVImportResponses which attempts to update the responseID nextval with either mysql or postgres backends.

Perhaps it is automatically handled either by Yii or the database as it does work correctly if you do not deactivate the survey and simply import the VV asking it to ignore responseIDs - the nextval is appropriately updated in this case.

However it fails 100% of the time I do I import after deactivating and reactivating the survey - after further testing i see that infact the adding of a new question is not even necessary - the nextval remains on 1 even if you simply deactivate, reactivate and then importVV.

What is your nextval - how are you assessing that you are not getting the problem? It is subtle and everything looks fine - except for the fact that the subsequent attempts are not recorded - even though the end user is shown a message stating that they are.

The only error messages I get are in the postgres logs after making an attempt on the survey after deactivating - reactivating and then importing.

eg
2014-09-03 10:08:54 UTC ERROR: duplicate key value violates unique constraint "lime_survey_135891_pkey7"
2014-09-03 10:08:54 UTC DETAIL: Key (id)=(1) already exists.
2014-09-03 10:08:54 UTC STATEMENT: INSERT INTO "lime_survey_135891" ("startlanguage") VALUES ('en')
2014-09-03 10:09:00 UTC ERROR: duplicate key value violates unique constraint "lime_survey_135891_pkey7"
2014-09-03 10:09:00 UTC DETAIL: Key (id)=(2) already exists.
2014-09-03 10:09:00 UTC STATEMENT: INSERT INTO "lime_survey_135891" ("startlanguage") VALUES ('en')
DenisChenu

DenisChenu

2014-09-04 11:28

developer   ~30475

Last edited: 2014-09-04 18:22

Yes, when i put survey id, i think of id of answer. Not the sSurveyId ;).

But no, i don't found a way to reproduce it .... id seems allway OK with pgsql

==========================
I think we can have a global fix fo whole answer id : move to transaction.

I can not be sure it fix this issue : @c_schmitz : if you don't found a better solution or if you don't reproduce too : reassign it to me. I move to transaction for vv import with some TRANSACTION LEVEL to SERIALIZABLE
c_schmitz

c_schmitz

2014-09-09 15:14

administrator   ~30513

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14464
c_schmitz

c_schmitz

2014-09-09 15:28

administrator   ~30514

I fixed all issues - including the missing notification if something goes wrong.
ronny_todgers

ronny_todgers

2014-09-09 15:29

reporter   ~30515

Great! - thank you :)
DenisChenu

DenisChenu

2014-09-10 15:14

developer   ~30531

Still broken with VV import.

It's more a PG bug.
even phpPgAmdin have same issue.

We need to update survey_XXXX_id_seq1 if forced id it's the same.
DenisChenu

DenisChenu

2014-09-10 16:49

developer   ~30533

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14470
DenisChenu

DenisChenu

2014-09-10 16:51

developer   ~30534

Carsten : can you see if we need same for mssql and VV import

https://github.com/LimeSurvey/LimeSurvey/commit/55244859fad6a36e8f9c492035f275ea97098391#diff-8671e17280c5c88335251c02a4d16347R4622

You can try with vvexport_135891.csv : i add a lot of id.

Thanks,
Denis
c_schmitz

c_schmitz

2014-11-24 16:26

administrator   ~31081

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14656
c_schmitz

c_schmitz

2014-11-24 16:27

administrator   ~31082

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14657
DenisChenu

DenisChenu

2014-11-24 18:55

developer   ~31088

Thanks :)
c_schmitz

c_schmitz

2014-11-26 10:29

administrator   ~31096

Version 2.05 Build 141126 released
ronny_todgers

ronny_todgers

2015-02-03 14:24

reporter   ~31619

I'm afraid this fix for this bug has a typo in the 2.05+ branch - it has been corrected in the 2.06 and 2.1, 2.2 branches by the look of it.

the critical line is
$sSequenceName=Yii::app()->db->getSchema()->getTable("{{survey_{$iSurveyId}}}")->sequenceName;

In teh 2.05+ branch this is
$sSequenceName=Yii::app()->db->getSchema()->getTable("{{survey_{$iSurveyID}}}")->sequenceName;

ID instead of Id

Can that correction be added to the 2.05 branch please?
ronny_todgers

ronny_todgers

2015-02-03 14:25

reporter   ~31620

I should add though - other than the typo - an awesome fix :)

Related Changesets

LimeSurvey: master ea2d73bb

2014-09-09 15:14

c_schmitz


Details Diff		 Fixed issue 09140: No error message if data is not inserted on first page
Fixed issue 09140: Auto ID is not set properly when using Postgres and deactivating and reactivating the survey		 Affected Issues
09140
mod - application/controllers/admin/surveyadmin.php Diff File
mod - application/helpers/admin/activate_helper.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/views/admin/survey/deactivateSurvey_view.php Diff File

LimeSurvey: master 55244859

2014-09-10 16:49

DenisChenu


Details Diff		 Fixed issue 09140: Auto ID is not set properly when using Postgres and insert new id with VV import
Dev: Needed for mysql too ?
Dev: Need a model function ? modelSurveyDynamic::model($surveyId)->fixPk($iNewId);		 Affected Issues
09140
mod - application/helpers/admin/import_helper.php Diff File

LimeSurvey: master dbc26a8d

2014-09-10 17:07

DenisChenu


Details Diff		 Dev: better fix for issue 09140
Dev: https://github.com/LimeSurvey/LimeSurvey/commit/55244859fad6a36e8f9c492035f275ea97098391 child		 Affected Issues
09140
mod - application/helpers/admin/import_helper.php Diff File

LimeSurvey: master 6d85b901

2014-11-24 16:25

c_schmitz


Details Diff		 Fixed issue 09140: VV-Import not working with MSSQL Affected Issues
09140
mod - application/helpers/admin/import_helper.php Diff File

LimeSurvey: 2.06 bedcc30f

2014-11-24 16:25

c_schmitz


Details Diff		 Fixed issue 09140: VV-Import not working with MSSQL Affected Issues
09140
mod - application/helpers/admin/import_helper.php Diff File

Issue History

Date Modified Username Field Change
2014-07-09 22:35 ronny_todgers New Issue
2014-07-09 22:36 ronny_todgers File Added: survey_archive_135891.lsa
2014-07-10 00:52 mfaber Issue Monitored: mfaber
2014-07-10 09:14 DenisChenu Note Added: 30286
2014-07-10 09:14 DenisChenu Issue Monitored: DenisChenu
2014-07-10 09:20 DenisChenu Note Added: 30287
2014-07-10 10:58 ronny_todgers Note Added: 30288
2014-07-10 12:02 DenisChenu Note Added: 30289
2014-07-10 12:45 DenisChenu Note Added: 30290
2014-07-10 12:54 DenisChenu Note Edited: 30290
2014-07-10 13:00 ronny_todgers Note Added: 30291
2014-07-10 13:02 ronny_todgers Note Added: 30292
2014-07-10 14:18 DenisChenu Note Added: 30293
2014-07-10 14:48 ronny_todgers Note Added: 30294
2014-07-23 10:06 DenisChenu Note Added: 30318
2014-07-23 10:16 ronny_todgers Note Added: 30319
2014-07-23 10:16 ronny_todgers File Added: vvexport_213695.csv
2014-07-23 10:18 ronny_todgers Note Added: 30320
2014-07-23 10:19 DenisChenu Note Added: 30321
2014-07-24 10:17 DenisChenu Assigned To => DenisChenu
2014-07-24 10:17 DenisChenu Status new => assigned
2014-08-02 11:44 ronny_todgers Note Added: 30393
2014-09-03 11:32 DenisChenu Note Added: 30466
2014-09-03 12:13 ronny_todgers Note Added: 30469
2014-09-04 11:27 DenisChenu Assigned To DenisChenu => c_schmitz
2014-09-04 11:28 DenisChenu Note Added: 30475
2014-09-04 18:22 DenisChenu Note Edited: 30475
2014-09-09 15:14 c_schmitz Changeset attached => LimeSurvey master ea2d73bb
2014-09-09 15:14 c_schmitz Note Added: 30513
2014-09-09 15:14 c_schmitz Resolution open => fixed
2014-09-09 15:28 c_schmitz Note Added: 30514
2014-09-09 15:28 c_schmitz Status assigned => resolved
2014-09-09 15:28 c_schmitz Fixed in Version => 2.05+
2014-09-09 15:29 ronny_todgers Note Added: 30515
2014-09-10 15:14 DenisChenu Assigned To c_schmitz => DenisChenu
2014-09-10 15:14 DenisChenu Note Added: 30531
2014-09-10 15:14 DenisChenu Status resolved => feedback
2014-09-10 15:14 DenisChenu Resolution fixed => reopened
2014-09-10 15:14 DenisChenu Status feedback => assigned
2014-09-10 16:43 DenisChenu File Added: vvexport_135891.csv
2014-09-10 16:44 DenisChenu File Deleted: vvexport_135891.csv
2014-09-10 16:44 DenisChenu File Added: vvexport_135891.csv
2014-09-10 16:49 DenisChenu Changeset attached => LimeSurvey master 55244859
2014-09-10 16:49 DenisChenu Note Added: 30533
2014-09-10 16:51 DenisChenu Note Added: 30534
2014-09-10 16:51 DenisChenu Assigned To DenisChenu => c_schmitz
2014-09-10 16:51 DenisChenu Status assigned => feedback
2014-09-10 17:07 DenisChenu Changeset attached => LimeSurvey master dbc26a8d
2014-11-23 20:46 c_schmitz Status feedback => assigned
2014-11-24 16:26 c_schmitz Changeset attached => LimeSurvey master 6d85b901
2014-11-24 16:26 c_schmitz Note Added: 31081
2014-11-24 16:27 c_schmitz Changeset attached => LimeSurvey 2.06 bedcc30f
2014-11-24 16:27 c_schmitz Note Added: 31082
2014-11-24 16:28 c_schmitz Status assigned => resolved
2014-11-24 16:28 c_schmitz Resolution reopened => fixed
2014-11-24 18:55 DenisChenu Note Added: 31088
2014-11-26 10:29 c_schmitz Note Added: 31096
2014-11-26 10:29 c_schmitz Status resolved => closed
2015-02-03 14:24 ronny_todgers Note Added: 31619
2015-02-03 14:24 ronny_todgers Status closed => feedback
2015-02-03 14:24 ronny_todgers Resolution fixed => reopened
2015-02-03 14:25 ronny_todgers Note Added: 31620
2015-02-03 14:25 ronny_todgers Status feedback => assigned
2015-02-04 09:27 DenisChenu Relationship added related to 09491
2015-02-12 10:57 c_schmitz Status assigned => closed
2015-02-12 10:57 c_schmitz Resolution reopened => fixed
2021-08-03 03:02 guest Bug heat 6 => 10