View Issue Details

Related ChangesetsJump to NotesJump to History
This issue affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
09105Bug reportsSurvey editingpublic2014-06-20 10:132014-07-30 16:18
ReporterDenisChenu Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Fixed in Version2.05+ 
Summary09105: Unable to open popup email for administrator in French
Description

In admin french, when trying to open popup HTML editor for admin notification : javascript error.

Steps To Reproduce

Set your user language to french
Set your HTML editor to popup
Go to survey settings/ edit eamil template
Got to "Notification simple à l'administrateur" tab
Click on button

Javascript Error:
SyntaxError: missing ) after argument list
javascript:start_popup_editor('email_admin_notification_fr','Courriel%20de%20notification%20simple%20%C3%A0%20l'administrateur%20:(fr)','184133','','','email-admin_notification','editemailtemplates')
Line 1

Additional Information

Strangely ' is already ' in HTML source.

Translation already updated to fix it : ' to ’ (in next release after translation update) but maybe have to fix for other language.

http://translate.limesurvey.org/projects/limesurvey2/fr/default?filters[term]=&filters[user_login]=&filters[status]=current_or_waiting_or_fuzzy_or_untranslated&sort[by]=translation_date_added&sort[how]=desc&sorts=Sort

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)140620
I will donate to the project if issue is resolvedNo
BrowserFF30
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant
Git branch / Pull Request URL

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2014-06-20 13:43

administrator   ~30185

Denis, the fix should not be to amend the translation but properly quote the single quote.
c_schmitz

c_schmitz

2014-06-20 14:06

administrator   ~30187

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14286
DenisChenu

DenisChenu

2014-06-20 14:31

developer   ~30188

Hi Cartsen, sorry this won't fix ...

Html show: (i add space in& #039 ;)
<a href="javascript:start_popup_editor('email_admin_detailed_notification_en','Courriel de notification détaillée à l& #039 ;administrateur :(en)','442251','','','email-admin_detailed_notification','editemailtemplates')" id='email_admin_detailed_notification_en_ctrl' class='editorLink'>

Then addslashes do nothing, i tested before with htmlentities : and then the title are
"Courriel de notification détaillée à l&" but it work ;)
DenisChenu

DenisChenu

2014-06-20 14:31

developer   ~30189

Reopened after last fix
DenisChenu

DenisChenu

2014-06-23 18:05

developer   ~30213

Bug not happen for french since language update, but still the issue of single quote are in some language :)
DenisChenu

DenisChenu

2014-07-05 17:35

developer   ~30279

OK for french, see for another language
c_schmitz

c_schmitz

2014-07-24 10:31

administrator   ~30337

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14337
c_schmitz

c_schmitz

2014-07-30 16:18

administrator   ~30375

2.05+ Build 140730 released

Related Changesets

LimeSurvey: master 90cdbe27

2014-06-20 14:06

c_schmitz


Details Diff		 Fixed issue 09105: Unable to open popup email editor in French Affected Issues
09105
mod - application/helpers/admin/htmleditor_helper.php Diff File

LimeSurvey: master 4034d2a4

2014-07-24 10:31

c_schmitz


Details Diff		 Fixed issue 09105: Unable to open popup email for administrator in French Affected Issues
09105
mod - application/helpers/admin/htmleditor_helper.php Diff File

Issue History

Date Modified Username Field Change
2014-06-20 10:13 DenisChenu New Issue
2014-06-20 10:13 DenisChenu Description Updated
2014-06-20 10:13 DenisChenu Additional Information Updated
2014-06-20 13:43 c_schmitz Note Added: 30185
2014-06-20 14:05 c_schmitz Assigned To => c_schmitz
2014-06-20 14:05 c_schmitz Status new => assigned
2014-06-20 14:06 c_schmitz Status assigned => resolved
2014-06-20 14:06 c_schmitz Fixed in Version => 2.06+
2014-06-20 14:06 c_schmitz Resolution open => fixed
2014-06-20 14:06 c_schmitz Changeset attached => LimeSurvey master 90cdbe27
2014-06-20 14:06 c_schmitz Note Added: 30187
2014-06-20 14:31 DenisChenu Note Added: 30188
2014-06-20 14:31 DenisChenu Note Added: 30189
2014-06-20 14:31 DenisChenu Status resolved => assigned
2014-06-23 18:05 DenisChenu Note Added: 30213
2014-06-23 18:05 DenisChenu Status assigned => acknowledged
2014-06-23 18:05 DenisChenu Status acknowledged => resolved
2014-06-23 18:06 DenisChenu Fixed in Version 2.06+ => 2.05+
2014-06-23 21:56 c_schmitz Status resolved => assigned
2014-07-05 17:35 DenisChenu Note Added: 30279
2014-07-05 17:35 DenisChenu Status assigned => acknowledged
2014-07-05 17:39 c_schmitz Status acknowledged => assigned
2014-07-24 10:31 c_schmitz Changeset attached => LimeSurvey master 4034d2a4
2014-07-24 10:31 c_schmitz Note Added: 30337
2014-07-24 10:31 c_schmitz Status assigned => resolved
2014-07-30 16:18 c_schmitz Note Added: 30375
2014-07-30 16:18 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing