View Issue Details

This bug affects 1 person(s).
 26
IDProjectCategoryView StatusLast Update
08976Bug reportsPluginspublic2016-08-24 15:26
Reporterdrosien Assigned Tosammousa  
PrioritynormalSeveritycrash 
Status closedResolutionopen 
Summary08976: Plugin Settings 'type' => 'list' are not stored
Description

When defining a setting-element of type 'list', entering settings works fine, but settings are not saved when hitting the button.

TagsNo tags attached.
Bug heat26
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version

Relationships

has duplicate 10023 closed Bug reports Plugin settings - list view from example 

Users monitoring this issue

DenisChenu

Activities

drosien

drosien

2014-04-17 10:25

reporter   ~29825

sorry, this should have been a bug report.
I'm not allowed to change it, am I?

mdekker

mdekker

2014-07-01 14:10

reporter   ~30252

What plugin are you using?

drosien

drosien

2014-07-02 09:13

reporter   ~30255

The 'Example'-plugin in 'Demo' folder is using type 'list' for settings.

To reproduce you have to move the 'Example'-plugin into 'plugins'-folder.

mdekker

mdekker

2014-07-03 12:57

reporter   ~30260

@sammousa: This is only in the example plugin, not really sure what it was supposed to do. Maybe you can have a look.

DenisChenu

DenisChenu

2015-02-17 09:19

developer   ~31686

Last edited: 2015-02-24 15:18

@sammousa : Plugin can use own function to save the plugin setting (in array, in json etc ...)
but the real probem is in renderList : it can do only one line.

Did renderList receive current in array or in json ? Did you use renderList in one of your plugin ?
If yes : we must use same than your plugin, if not : we can update renderList for an array of current (i think it's the better solution : it's a list then we have an array,). Alternative is to directly use a json.

PS: we can test if current is array or not too.
Maybe $setting['currents'] for array and $setting['current'] for json

DenisChenu

DenisChenu

2015-03-19 08:24

developer   ~31857

@sammousa : i can take it, but OK to use $setting['currents'] for array and $setting['current'] for json ?

sammousa

sammousa

2015-06-22 11:59

reporter   ~32478

Last edited: 2015-06-22 12:01

In my opinion, current should reflect the current value.
So if this is a list setting then the current value should be an array.

Serialization should be transparent / invisible to the end user (which is a developer in this case).

DenisChenu

DenisChenu

2015-06-22 12:15

developer   ~32479

Last edited: 2015-06-22 12:16

Yes, sure for Serialization for current user. But for dev :).

OK, array is better see my comment : "(i think it's the better solution : it's a list then we have an array,)"

DenisChenu

DenisChenu

2016-03-15 11:32

developer   ~36501

2.06 and 2.5 version. Target is 3.0 (or before if we have external dev who made the fix)

Issue History

Date Modified Username Field Change
2014-04-17 10:19 drosien New Issue
2014-04-17 10:25 drosien Note Added: 29825
2014-06-21 15:01 DenisChenu Project Feature requests => Bug reports
2014-06-21 17:34 c_schmitz Severity feature => crash
2014-07-01 14:09 mdekker Assigned To => mdekker
2014-07-01 14:09 mdekker Status new => assigned
2014-07-01 14:10 mdekker Note Added: 30252
2014-07-02 09:13 drosien Note Added: 30255
2014-07-03 12:57 mdekker Assigned To mdekker => sammousa
2014-07-03 12:57 mdekker Note Added: 30260
2015-02-17 09:19 DenisChenu Note Added: 31686
2015-02-17 09:19 DenisChenu Note Edited: 31686
2015-02-17 09:20 DenisChenu Issue Monitored: DenisChenu
2015-02-24 15:18 DenisChenu Note Edited: 31686
2015-03-19 08:24 DenisChenu Note Added: 31857
2015-06-22 10:17 sammousa Target Version => 3.0
2015-06-22 11:59 sammousa Note Added: 32478
2015-06-22 12:01 sammousa Note Edited: 32478
2015-06-22 12:15 DenisChenu Note Added: 32479
2015-06-22 12:16 DenisChenu Note Edited: 32479
2015-11-06 15:07 DenisChenu Relationship added has duplicate 10023
2016-03-15 11:29 LouisGac Product Version => 3.0
2016-03-15 11:32 DenisChenu Note Added: 36501
2016-08-24 15:26 c_schmitz Status assigned => closed
2021-08-03 11:09 guest Bug heat 24 => 26