View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
08910Bug reportsRemoteControlpublic2014-11-04 14:30
Reporterravi4957 Assigned Toc_schmitz  
PriorityurgentSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.05+ 
Fixed in Version2.05+ 
Summary08910: XMLRPC call for export_responses and export_responses_by_token returns blank result
Description

XMLRPC call for export_responses returning blank string, while the other function is adopting the export_responses, so even that returns blank string in response,

While some points found when compared with the version 2.0

1) Previously in 2.0 the data returned was base64encoded string, but that was without <base64> tag and type was string in the response xml, so at that time response was needed to be decoded when retrieved by xmlrpc client, While in the new version, the encoded data is returned in <base64> tag, so xmlclient will automatically decode the response and return binary data of file. So basically the users should know that they should have to change something decoding of response in their own codebase

Additional Information

To solve the issue, i can propose below solution in the bigdata.php file below function

protected static function xmlrpc_echo_stream($data)
{
echo '<base64>';
$data->render();
echo '</base64>';
}

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)Version 2.05+ Build 140302
I will donate to the project if issue is resolvedNo
Browser
Database type & versionmysql 5.5.34
Server OS (if known)Linux
Webserver software & version (if known)apache
PHP Version5.5

Users monitoring this issue

There are no users monitoring this issue.

Activities

ravi4957

ravi4957

2014-03-27 09:56

reporter   ~29557

Please let me know if u agree with the proposed changes then i can add a PR for this bug

c_schmitz

c_schmitz

2014-03-29 18:46

administrator   ~29612

CAn you explain a bit more what render() does? I can't find it aynwhere.

ravi4957

ravi4957

2014-03-31 12:42

reporter   ~29619

https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/remotecontrol/remotecontrol_handle.php

Please check line 2342 inside export_responses routine, which returns object of BigFile class located at below link of BigData.php file

https://github.com/LimeSurvey/LimeSurvey/blob/master/application/libraries/BigData.php

Which has render function, which is already setting up default encryption type if not available to base64, and then converts the data to base64encode, and outputs all data to a file pointer.

c_schmitz

c_schmitz

2014-03-31 14:43

administrator   ~29623

Please create a pull request, then. Thank you!

ravi4957

ravi4957

2014-03-31 14:45

reporter   ~29624

http://bugs.limesurvey.org/view.php?id=8911

Can you please have a look at the above issue too please.

c_schmitz

c_schmitz

2014-03-31 15:01

administrator   ~29626

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=14095

c_schmitz

c_schmitz

2014-03-31 17:12

administrator   ~29629

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=14101

Related Changesets

LimeSurvey: master 1fecfe31

2014-03-31 12:48:30

ravi4957

Details Diff
Fixed issue 08910: Fixed added to output/render output of file data, using render routine of Bigfile class Affected Issues
08910
mod - application/libraries/BigData.php Diff File

LimeSurvey: master 69478241

2014-03-31 13:00:56

c_schmitz

Details Diff
Merge pull request #187 from ravindrakhokharia/master

Fixed issue 08910: Fixed added to output/render output of file data
Affected Issues
08910
mod - application/libraries/BigData.php Diff File

LimeSurvey: master fe593634

2014-03-31 13:11:03

ravi4957

Details Diff
Fixed issue 08910: Fixed added to output/render output of file data, using render routine of Bigfile class Affected Issues
08910
mod - application/libraries/BigData.php Diff File

LimeSurvey: master 62b5d779

2014-03-31 15:12:18

c_schmitz

Details Diff
Merge pull request #188 from ravindrakhokharia/master

Fixed issue 08910: Updated encoding
Affected Issues
08910
mod - application/libraries/BigData.php Diff File

Issue History

Date Modified Username Field Change
2014-03-27 08:54 ravi4957 New Issue
2014-03-27 09:56 ravi4957 Note Added: 29557
2014-03-29 18:46 c_schmitz Note Added: 29612
2014-03-31 12:42 ravi4957 Note Added: 29619
2014-03-31 14:43 c_schmitz Note Added: 29623
2014-03-31 14:43 c_schmitz Assigned To => c_schmitz
2014-03-31 14:43 c_schmitz Status new => assigned
2014-03-31 14:45 ravi4957 Note Added: 29624
2014-03-31 15:01 ravi4957 Changeset attached => LimeSurvey master 1fecfe31
2014-03-31 15:01 c_schmitz Changeset attached => LimeSurvey master 69478241
2014-03-31 15:01 c_schmitz Note Added: 29626
2014-03-31 15:01 c_schmitz Resolution open => fixed
2014-03-31 17:12 ravi4957 Changeset attached => LimeSurvey master fe593634
2014-03-31 17:12 c_schmitz Changeset attached => LimeSurvey master 62b5d779
2014-03-31 17:12 c_schmitz Note Added: 29629
2014-04-04 17:41 c_schmitz Status assigned => closed
2014-04-04 17:41 c_schmitz Fixed in Version => 2.05+
2014-11-04 14:30 user36100 Issue Monitored: user36100