View Issue Details

Related ChangesetsJump to NotesJump to History
This issue affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
08908Bug reportsSurvey participants (Tokens)public2014-03-26 19:042014-04-14 23:02
ReporterDenisChenu Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Summary08908: Javascript error in some token page
Description

When go to import token, habe a javascript error in console
ReferenceError: sLoadText is not defined
./scripts/admin/tokens.js
Line 123

Steps To Reproduce

Go to export token and look at console

Additional Information

This don't break javascript actually, but if we add a even after this : all is broken.

2 solution:

  • Add all javascript language var to all token view : bad idea : why do something we don't need
  • Move all jqgrid system in a function and launch this function only if $("#displaytokens") exist
TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)140326
I will donate to the project if issue is resolvedNo
Browsernot relevant (FF27)
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant
Git branch / Pull Request URL

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2014-03-29 17:39

administrator   ~29605

I don't see a reason why the script is included at import, do you?
DenisChenu

DenisChenu

2014-03-29 20:10

developer   ~29613

Last edited: 2014-03-29 20:11

tokenss.js need at import too

Just for this line : https://github.com/LimeSurvey/LimeSurvey/blob/master/scripts/admin/tokens.js#L69 and maybe other

Personnaly, i think controllers/token.php => token.js : it's better to find : where is this Fu... script broke my really good system ;)
c_schmitz

c_schmitz

2014-04-04 16:12

administrator   ~29677

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14107
c_schmitz

c_schmitz

2014-04-14 23:02

administrator   ~29764

2.05+ Build 140414 released

Related Changesets

LimeSurvey: master 7a7bf29c

2014-04-04 16:12

c_schmitz


Details Diff		 Fixed issue 08908: Javascript error in import tokens page Affected Issues
08908
mod - application/controllers/admin/tokens.php Diff File
mod - scripts/admin/listsurvey.js Diff File
mod - scripts/admin/tokens.js Diff File
add - scripts/admin/tokensimport.js Diff File

Issue History

Date Modified Username Field Change
2014-03-26 19:04 DenisChenu New Issue
2014-03-29 17:39 c_schmitz Note Added: 29605
2014-03-29 17:39 c_schmitz Assigned To => c_schmitz
2014-03-29 17:39 c_schmitz Status new => feedback
2014-03-29 20:10 DenisChenu Note Added: 29613
2014-03-29 20:10 DenisChenu Status feedback => assigned
2014-03-29 20:11 DenisChenu Note Edited: 29613
2014-04-04 16:12 c_schmitz Changeset attached => LimeSurvey master 7a7bf29c
2014-04-04 16:12 c_schmitz Note Added: 29677
2014-04-04 16:12 c_schmitz Resolution open => fixed
2014-04-04 16:12 c_schmitz Status assigned => resolved
2014-04-14 23:02 c_schmitz Note Added: 29764
2014-04-14 23:02 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)