View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
08857Bug reportsRemoteControlpublic2014-03-14 10:072014-04-04 10:26
Reporterravi4957 Assigned Toc_schmitz  
PriorityurgentSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.05+ 
Fixed in Version2.05+ 
Summary08857: When XML RPC Call to add_participants, tid not returned in the response using POST MAN rest client
Description

Added xml response from POSTMAN REST Client, please check the "tid" value is blank in the xml call, this is happening because,
application/libraries/BigData.php - function name - xmlrpc_echo_number()

the data passed to this function is STRING value and its sending because is_numeric php function is returning true, if the string is number, but inside xmlrpc_echo_number function its checking for is_float or is_int which will not true when passed string int value, i.e '1.0' or '1'

So value for 'tid' is not mapped in the response

Additional Information

<methodResponse>
<params>
<param>
<value>
<struct>
<member>
<name>
<string>
<![CDATA[participantData]]>
</string>
</name>
<value>
<struct>
<member>
<name>
<string>
<![CDATA[sent]]>
</string>
</name>
<value>
<string>
<![CDATA[N]]>
</string>
</value>
</member>
<member>
<name>
<string>
<![CDATA[remindersent]]>
</string>
</name>
<value>
<string>
<![CDATA[N]]>
</string>
</value>
</member>
<member>
<name>
<string>
<![CDATA[remindercount]]>
</string>
</name>
<value>
<int>0</int>
</value>
</member>
<member>
<name>
<string>
<![CDATA[completed]]>
</string>
</name>
<value>
<string>
<![CDATA[N]]>
</string>
</value>
</member>
<member>
<name>
<string>
<![CDATA[usesleft]]>
</string>
</name>
<value>
<int>1</int>
</value>
</member>
<member>
<name>
<string>
<![CDATA[firstname]]>
</string>
</name>
<value>
<string>
<![CDATA[hardik]]>
</string>
</value>
</member>
<member>
<name>
<string>
<![CDATA[lastname]]>
</string>
</name>
<value>
<string>
<![CDATA[kotak]]>
</string>
</value>
</member>
<member>
<name>
<string>
<![CDATA[email]]>
</string>
</name>
<value>
<string>
![CDATA[hardikkotak@tts-talent.com]]
</string>
</value>
</member>
<member>
<name>
<string>
<![CDATA[language]]>
</string>
</name>
<value>
<string>
<![CDATA[en]]>
</string>
</value>
</member>
<member>
<name>
<string>
<![CDATA[token]]>
</string>
</name>
<value>
<string>
<![CDATA[7828exejnuvds94]]>
</string>
</value>
</member>
<member>
<name>
<string>
<![CDATA[tid]]>
</string>
</name>
<value></value>
</member>
<member>
<name>
<string>
<![CDATA[participant_id]]>
</string>
</name>
<value></value>
</member>
<member>
<name>
<string>
<![CDATA[emailstatus]]>
</string>
</name>
<value></value>
</member>
<member>
<name>
<string>
<![CDATA[blacklisted]]>
</string>
</name>
<value></value>
</member>
<member>
<name>
<string>
<![CDATA[validfrom]]>
</string>
</name>
<value></value>
</member>
<member>
<name>
<string>
<![CDATA[validuntil]]>
</string>
</name>
<value></value>
</member>
<member>
<name>
<string>
<![CDATA[mpid]]>
</string>
</name>
<value></value>
</member>
</struct>
</value>
</member>
</struct>
</value>
</param>
</params>
</methodResponse>

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)Version 2.05+ Build 140302
I will donate to the project if issue is resolvedNo
Browser
Database type & versionmysql 5.5.34
Server OS (if known)Linux
Webserver software & version (if known)apache
PHP Version5.5

Users monitoring this issue

There are no users monitoring this issue.

Activities

ravi4957

ravi4957

2014-03-14 10:10

reporter   ~29260

Rather we can do fix this issue by replacing the function with below function code, Please do check and let me know if that looks good then i can do a commit and request a pull

/**

  • Prints XMLRPC numeric types.
  • @param type $data
    */
    protected static function xmlrpc_echo_number($data)
    {
    if (floor($data) == $data){
    self::tag('int', $data);
    }
    else {
    self::tag('double', $data);
    }
    }
c_schmitz

c_schmitz

2014-03-19 10:23

administrator   ~29388

The fix looks fine. Please create a pull request.
c_schmitz

c_schmitz

2014-03-22 18:30

administrator   ~29508

Pretty please?
ravi4957

ravi4957

2014-03-24 12:59

reporter   ~29516

Created pull request at https://github.com/LimeSurvey/LimeSurvey/pull/184
c_schmitz

c_schmitz

2014-03-24 14:00

administrator   ~29519

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14064
c_schmitz

c_schmitz

2014-04-04 10:26

administrator   ~29667

2.05+ Build 140404 released.

Related Changesets

LimeSurvey: master f22c58b4

2014-03-24 05:59

ravi4957


Details Diff		 Fixed issue 08857: Fixed issue of type casting and return number value Affected Issues
08857
mod - application/libraries/BigData.php Diff File

LimeSurvey: master bf7fb091

2014-03-24 14:00

c_schmitz


Details Diff		 Merge pull request #184 from ravindrakhokharia/master

Fixed issue 08857: Fixed issue of type casting and return number value		 Affected Issues
08857
mod - application/libraries/BigData.php Diff File

Issue History

Date Modified Username Field Change
2014-03-14 10:07 ravi4957 New Issue
2014-03-14 10:10 ravi4957 Note Added: 29260
2014-03-19 10:23 c_schmitz Note Added: 29388
2014-03-19 10:23 c_schmitz Assigned To => c_schmitz
2014-03-19 10:23 c_schmitz Status new => feedback
2014-03-22 18:30 c_schmitz Note Added: 29508
2014-03-24 12:59 ravi4957 Note Added: 29516
2014-03-24 12:59 ravi4957 Status feedback => assigned
2014-03-24 14:00 ravi4957 Changeset attached => LimeSurvey master f22c58b4
2014-03-24 14:00 c_schmitz Changeset attached => LimeSurvey master bf7fb091
2014-03-24 14:00 c_schmitz Note Added: 29519
2014-03-24 14:00 c_schmitz Resolution open => fixed
2014-03-24 14:01 c_schmitz Status assigned => resolved
2014-03-24 14:01 c_schmitz Fixed in Version => 2.05+
2014-04-04 10:26 c_schmitz Note Added: 29667
2014-04-04 10:26 c_schmitz Status resolved => closed