View Issue Details

Related ChangesetsJump to NotesJump to History
This issue affects 1 person(s).
 2
IDProjectCategoryView StatusDate SubmittedLast Update
08530Bug reportsOtherpublic2014-01-12 12:192014-01-25 17:22
Reporterdkep Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Fixed in Version2.05+ 
Summary08530: "Return to label set administration" button not working properly
Description

The "Return to label set administration" button on the page that displays after label sets are imported links to the resource "admin/labels/view" instead of "admin/labels/sa/view" and thus displayes a "Bad Request" error.
While fixing the bug I encountered the same wrong link in the file "importlabelresources_view.php", so I fixed that as well.

Steps To Reproduce

) Go to the admin panel
) Click "Edit label sets"
) Click on the plus sign ("Create or import new label set(s)")
) Go to the tab "Import label set(s)" and upload a label set
*) Click the button "Return to label set administration"

TagsNo tags attached.
Attached Files
LabelSets-links.diff (1,822 bytes)    
From 83a1f37367139cf3efe6908675b13bae05fdc1e6 Mon Sep 17 00:00:00 2001
From: David K <code@rotinaj.org>
Date: Sun, 12 Jan 2014 12:14:24 +0100
Subject: [PATCH] Fix label sets view links

---
 application/views/admin/labels/import_view.php               | 4 ++--
 application/views/admin/labels/importlabelresources_view.php | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/application/views/admin/labels/import_view.php b/application/views/admin/labels/import_view.php
index dcaa3ac..1f2ed3c 100644
--- a/application/views/admin/labels/import_view.php
+++ b/application/views/admin/labels/import_view.php
@@ -46,5 +46,5 @@
         <?php
         }
     ?>
-    <input type='submit' value='<?php $clang->eT("Return to label set administration"); ?>' onclick="window.open('<?php echo $this->createUrl('admin/labels/view') ?>', '_top')" />
-</div><br />
\ No newline at end of file
+    <input type='submit' value='<?php $clang->eT("Return to label set administration"); ?>' onclick="window.open('<?php echo $this->createUrl('admin/labels/sa/view') ?>', '_top')" />
+</div><br />
diff --git a/application/views/admin/labels/importlabelresources_view.php b/application/views/admin/labels/importlabelresources_view.php
index aa42c1b..f4a0e22 100644
--- a/application/views/admin/labels/importlabelresources_view.php
+++ b/application/views/admin/labels/importlabelresources_view.php
@@ -68,5 +68,5 @@
 <?php
     }
 ?>
-    <input type='submit' value='<?php $clang->eT("Back") ?>' onclick="window.open('<?php echo $this->createUrl('admin/labels/view/lid/' . $lid) ?>', '_top')" />
-</div>
\ No newline at end of file
+    <input type='submit' value='<?php $clang->eT("Back") ?>' onclick="window.open('<?php echo $this->createUrl('admin/labels/sa/view/lid/' . $lid) ?>', '_top')" />
+</div>
-- 
1.8.4.2
LabelSets-links.diff (1,822 bytes)   
Bug heat2
Complete LimeSurvey version number (& build)140109
I will donate to the project if issue is resolvedNo
BrowserGoogle Chrome 31.0.1650.63 on Mac OS 10.9.1
Database type & versionPostgresql 9.2.4
Server OS (if known)Debian 6.0.8
Webserver software & version (if known)lighttpd 1.5 SVN
PHP Version5.4.15
Git branch / Pull Request URL

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2014-01-17 14:16

administrator   ~27957

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13705
c_schmitz

c_schmitz

2014-01-17 14:16

administrator   ~27958

Thank you. If possible always use gitHub pull requests instead of patches.
c_schmitz

c_schmitz

2014-01-25 17:22

administrator   ~28165

2.05+ Build 140125 released

Related Changesets

LimeSurvey: master af09bf8d

2014-01-17 14:16

c_schmitz


Details Diff		 Fixed issue 08530: "Return to label set administration" button not working properly - patch by dkep Affected Issues
08530
mod - application/views/admin/labels/import_view.php Diff File
mod - application/views/admin/labels/importlabelresources_view.php Diff File

Issue History

Date Modified Username Field Change
2014-01-12 12:19 dkep New Issue
2014-01-12 12:19 dkep File Added: LabelSets-links.diff
2014-01-17 14:15 c_schmitz Assigned To => c_schmitz
2014-01-17 14:15 c_schmitz Status new => assigned
2014-01-17 14:16 c_schmitz Changeset attached => LimeSurvey master af09bf8d
2014-01-17 14:16 c_schmitz Note Added: 27957
2014-01-17 14:16 c_schmitz Resolution open => fixed
2014-01-17 14:16 c_schmitz Note Added: 27958
2014-01-17 14:16 c_schmitz Status assigned => resolved
2014-01-17 14:16 c_schmitz Fixed in Version => 2.05+
2014-01-25 17:22 c_schmitz Note Added: 28165
2014-01-25 17:22 c_schmitz Status resolved => closed