View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 08515 | Bug reports | [All Projects] Survey taking | public | 2014-01-07 13:19 | 2014-01-09 23:31 |
| Reporter | tpartner | ||||
| Assigned To | DenisChenu | ||||
| Priority | normal | Severity | major | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 2.05+ | ||||
| Target Version | 2.05+ | Fixed in Version | 2.05+ | ||
| Summary | 08515: Language switcher does not work in token registration form | ||||
| Description | Language switcher does not work in token registration form | ||||
| Steps To Reproduce | Upload attached survey Test survey and try to switch language in the registration screen | ||||
| Additional Information | This was broken in 1.92, fixed in 2.0 and is now broken again. Can anyone shed some light on why the functionality of the language switcher select was changed? | ||||
| Tags | No tags attached. | ||||
| Complete LimeSurvey version number (& build) | 769eca5f993cb7ba0a896fc36f03 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | FF | ||||
| Database & DB-Version | N/A | ||||
| Operating System (Server) | N/A | ||||
| Webserver software & version | N/A | ||||
| PHP Version | N/A | ||||
|
|
limesurvey_survey_926833.lss (21,500 bytes) |
|
|
Denis, your fix to survey_runtime.js on 02/01/2014 seems to have broken this :) |
|
|
OK, i try to fix another one with old template ... I revert or search for a beter way Token registration form use form#limesurvey too .... |
|
|
It's not JS ... i send 'lang' now, but same think ... |
|
|
@tpartner : Can anyone shed some light on why the functionality of the language switcher select was changed? Answer is here : http://bugs.limesurvey.org/view.php?id=7967 |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13650 |
|
|
Updated to use existing form (if exist) Maybe it's better to use allways $_GET for token and register ? But then need removing existing lang param in URL. What do you think Tony : better in $_GET or in $_POST ? Before it's only by url : no get or post, but http://bugs.limesurvey.org/view.php?id=7967 |
|
|
Hi Denis, The language now switches correctly but, since you are submitting the "register" form, the CAPTCHA warning appears after the switch. |
|
|
Yes ... Surely better in $_GET then. But if you have already a /lang/fr in URL : getParam don't get the good param. But we can have lang-fr or /lang/fr or &lang=fr or ?lang=fr Did you have an idea to remove it in JS ? PS: another alternative is to add a data-submit="UrlOfSurveyController" in the select or in the button. Then we can add directly it to this url. |
|
|
Got it, add to test with preview to see if it's OK. |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13652 |
|
|
Tony : 2nd fix : working in preview/token/register and in survey even if {LANGUAGECHANGER} is not at the good place. |
|
|
You got it :) |
|
|
JS needed for change language in token and register. |
|
|
2.05+ build 140109 released |
|
LimeSurvey: master 5d88fbd6 2014-01-07 15:40:15 Details Diff |
Fixed issue 08515: Language switcher does not work in token registration form Dev: lang search for all existing form Dev: alternative if form don't exist : remove /lang-XX, /lang/XX and lang=XX from url and do it in GET param Dev: Remove some hardly coded SQL in RegisterController Dev: remove some uneended code in RegisterController |
||
| mod - application/controllers/RegisterController.php | Diff File | ||
| mod - application/controllers/survey/index.php | Diff File | ||
| mod - scripts/survey_runtime.js | Diff File | ||
|
LimeSurvey: master 80c3d693 2014-01-07 16:53:01 Details Diff |
Dev: refix 08515: Language switcher does not work in token registration form Dev: use GET if we are no in form, except if #limesurvey for exist or we are not in preview mode |
||
| mod - application/helpers/frontend_helper.php | Diff File | ||
| mod - scripts/survey_runtime.js | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-01-07 13:19 | tpartner | New Issue | |
| 2014-01-07 13:19 | tpartner | File Added: limesurvey_survey_926833.lss | |
| 2014-01-07 14:00 | tpartner | Note Added: 27729 | |
| 2014-01-07 14:00 | tpartner | Assigned To | => DenisChenu |
| 2014-01-07 14:00 | tpartner | Status | new => assigned |
| 2014-01-07 14:31 | DenisChenu | Note Added: 27730 | |
| 2014-01-07 14:52 | DenisChenu | Note Edited: 27730 | View Revisions |
| 2014-01-07 15:22 | DenisChenu | Note Added: 27733 | |
| 2014-01-07 16:36 | DenisChenu | Note Added: 27734 | |
| 2014-01-07 16:40 | DenisChenu | Changeset attached | => LimeSurvey master 5d88fbd6 |
| 2014-01-07 16:40 | DenisChenu | Note Added: 27735 | |
| 2014-01-07 16:40 | DenisChenu | Resolution | open => fixed |
| 2014-01-07 16:46 | DenisChenu | Note Added: 27736 | |
| 2014-01-07 17:12 | tpartner | Note Added: 27737 | |
| 2014-01-07 17:23 | DenisChenu | Note Added: 27738 | |
| 2014-01-07 17:24 | DenisChenu | Note Edited: 27738 | View Revisions |
| 2014-01-07 17:39 | DenisChenu | Note Added: 27739 | |
| 2014-01-07 17:53 | DenisChenu | Changeset attached | => LimeSurvey master 80c3d693 |
| 2014-01-07 17:53 | DenisChenu | Note Added: 27740 | |
| 2014-01-07 17:54 | DenisChenu | Note Added: 27741 | |
| 2014-01-07 18:12 | tpartner | Note Added: 27742 | |
| 2014-01-07 19:25 | DenisChenu | Note Added: 27745 | |
| 2014-01-07 19:25 | DenisChenu | Status | assigned => resolved |
| 2014-01-07 19:25 | DenisChenu | Fixed in Version | => 2.05+ |
| 2014-01-09 23:31 | c_schmitz | Note Added: 27804 | |
| 2014-01-09 23:31 | c_schmitz | Status | resolved => closed |
