View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
08402Bug reportsOtherpublic2016-02-15 15:41
Reporterlarjona Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionwon't fix 
Target Version2.50.x 
Summary08402: Javascript does not pass the LibreJS tests, and gets blocked (as if it was non-free)
Description

Dear LimeSurvey developers
First, thanks for this amazing project and congratulations for your work.

I have deployed Limesurvey to setup a survey to free/open source software developers and contributors, and some of them complained that the Firefox plugin LibreJS blocks part of the JavaScript, as if it was non free.

I have researched a bit, and the problem seems to be that the JS code is not tagged in a way that this plugin recognizes the license of each .js file (or code embedded in other files).

For example, LibreJS complains about this files:

in attribute: onchange:javascript:$('[name=move]').val('changelang_'+ this.value);$('#limesurvey').submit();;

NONTRIVIAL: innerHTML identifier:
/scripts/jquery/jquery-ui.js
This script is detected as nonfree, external, and as defining functions or methods:
/scripts/jquery/jquery.ui.touch-punch.min.js
This script is detected as nonfree, external, and as defining functions or methods:
/upload/templates/mint_idea_striped/template.js
This script is detected as nonfree, external, and as defining functions or methods:
/scripts/survey_runtime.js

But I suppose it would be necessary to review all the .js files and the embedded javascript code.

The information about LibreJS is here:
http://www.gnu.org/software/librejs/

I would like to help to solve this issue; however, it involves "touching" the license information in the files for rewriting it or adding a license paragraph in a certain format (see http://www.gnu.org/software/librejs/free-your-javascript.html ), and I wanted to check first here that it's ok to do so manually (maybe that information, now, is added automatically with some script or the files that are provided by third parties are retrieved periodically from upstream projects).

Steps To Reproduce

1.- Install LibreJS plugin in Firefox
http://ftp.gnu.org/gnu/librejs/librejs-5.4.1.xpi

2.- Go to a website that runs a LimeSurvey survey, e.g.
https://surveys.libresoft.es/index.php?sid=68745

3.- Open the LibreJS report (clicking the icon in the Add-on bar, at the bottom right)

Additional Information

I would donate 30€ if this issue is resolved quickly. I understand it may involve lots of files and changes in the code, so I would donate anyway when this bug is solved. Thanks.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)Version 1.92+ Build 120919
I will donate to the project if issue is resolvedYes
BrowserFirefox/Iceweasel
Database type & versionMySQL 5.1
Server OS (if known)Ubuntu Linux 2.6.32-50-server
Webserver software & version (if known)Apache/2.2.14 (Ubuntu)
PHP VersionPHP Version 5.3.2-1ubuntu4.21

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2013-11-23 15:16

developer   ~27339

Last edited: 2013-11-23 15:17

Seems jquery have some problem in librejs : http://lists.gnu.org/archive/html/help-librejs/2013-09/msg00005.html
and bootstrap.js have same problem.

Think it's OK to fix our @licence part (allways a good idea to have clean licence information), but did librejs accepte MIT licence ? Unclear for me.

PS:
We can fix LS , but not third party script. Please contact the third party author.

c_schmitz

c_schmitz

2013-11-24 19:01

administrator   ~27342

Yes, I see third-party scripts in general as the real problem here.
Tagging our own scripts is not a problem though it is quite some effort and I see no immediate pressuring reason here.

Anyway, I don't see any obvious advantage to do this except for this strange plugin which I have never heard about it before. I think blocking non-free stuff is just weird.
larjona, you will have to contact the 3rd-party plugins authors directly as we only use unmodified libraries.

larjona

larjona

2013-11-25 00:36

reporter   ~27352

Thanks for the answers.
I'll contact third party authors too.

About MIT license, LibreJS is able to recognize it (Expat license): http://www.gnu.org/software/librejs/manual/html_node/Free-Licenses-Detection.html#Free-Licenses-Detection

Just to know (I'm not familiarized with Mantis BTS): this bug now looks open+aknowledged+fixed in 2.1. Does this mean that the LS part will be fixed in next version (2.1)?

c_schmitz

c_schmitz

2013-11-25 00:55

administrator   ~27353

Yes, Target is set for version 2.1

c_schmitz

c_schmitz

2016-02-15 15:41

administrator   ~35147

I still don't see any support for this, not even from the most common Open Source JS frameworks, so I will close this issue.

Issue History

Date Modified Username Field Change
2013-11-23 00:48 larjona New Issue
2013-11-23 15:16 DenisChenu Note Added: 27339
2013-11-23 15:17 DenisChenu Note Edited: 27339
2013-11-24 19:01 c_schmitz Note Added: 27342
2013-11-24 19:02 c_schmitz Status new => acknowledged
2013-11-24 19:03 c_schmitz Fixed in Version => 2.5
2013-11-25 00:36 larjona Note Added: 27352
2013-11-25 00:55 c_schmitz Note Added: 27353
2013-11-25 00:55 c_schmitz Fixed in Version 2.5 =>
2013-11-25 00:55 c_schmitz Target Version => 2.5
2016-02-15 15:41 c_schmitz Note Added: 35147
2016-02-15 15:41 c_schmitz Status acknowledged => closed
2016-02-15 15:41 c_schmitz Assigned To => c_schmitz
2016-02-15 15:41 c_schmitz Resolution open => won't fix