View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
08220Bug reportsImport/Exportpublic2014-01-23 13:23
Reportermfaber Assigned Toadamzammit  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Target Version2.05 RCFixed in Version2.05+ 
Summary08220: quexf-pdf export: single answer question > 1 page are cut
Description

Answer categories of single answer questions that do not fit on one page run over the end of the page and are lost.

Steps To Reproduce

export a survey containing a dropdown question w/ eg. 40 answer categories using quexf.
Have a look at the pdf.

Additional Information

Need to adapt drawSingleChoiceVertical() in quexmlpdf.php

TagsNo tags attached.
Attached Files
20131030.pdf (3,056,889 bytes)
20131101.pdf (3,123,952 bytes)
20131101.lss (43,047 bytes)
quexmlpdf.php (101,158 bytes)
Bug heat10
Complete LimeSurvey version number (& build)131002
I will donate to the project if issue is resolvedNo
BrowserFF
Database type & versionMySQL 5.0.10
Server OS (if known)Win7
Webserver software & version (if known)Apache/2.4.3 (Win32)
PHP VersionPhP 5.4.7

Relationships

related to 08344 closedadamzammit Feature requests quexf: conditional splitting with new question splitting option 
related to 08343 closedadamzammit Feature requests quexf: next page message with new question splitting option 

Users monitoring this issue

adamzammit, mfaber

Activities

mfaber

mfaber

2013-10-02 13:21

reporter   ~26473

Note to self: think about using several column of answer categories (as per user setting) if answers are short (e.g list of the 2 letter codes of ~50 states of america). At least implement page breaks as in drawSingleChoiceHorizontal().

adamzammit

adamzammit

2013-10-25 07:12

developer   ~26987

Hi Mfaber,

I have updated the queXMLPDF class to handle splitting most question types over multiple pages (although not set as default). I've patched it to include the limesurvey specific code. Do you mind testing this new class and letting me know how you go?

Thanks again for contributing to queXML / queXF.

Adam

mfaber

mfaber

2013-10-25 19:48

reporter   ~26994

Hi Adam,
thanks so much. Looks like it has been a lot of work.

The output looks good. So far I found one little pagination issue that was not there before. Please have a look at the end of page 2 in the attached pdf. I'll also attach the respective lss.

When splitting a non-matrix type question, it might make sense to add an an arrow or a small note that more answer categories can be found on the following page. But please consider this a feature request.

Lastly, loooooong texts such as a survey description are not split to another page. But that's really not an issue because one can just split overly long texts into several boilerplate question.

I am away at the moment and will conduct more testing when I have access to a better test environment.

Thanks again,
Mirko

adamzammit

adamzammit

2013-10-28 06:06

developer   ~27000

Hi Mirko,

Thanks for looking in to this. I have uploaded a patch that should resolve the new issue.

Your idea for a note/arrow when answer categories split a page is a good one. I've lodged a feature request/bug upstream here: https://bugs.launchpad.net/quexml/+bug/1245331

Regards,
Adam Zammit

mfaber

mfaber

2013-10-30 18:40

reporter   ~27043

Hi Adam,

Thanks for sending the patch!
Unfortunately the problem is still there (see end of page 2 in newly attached 20131030.pdf). Additionally, now the second part of the dual matrix question A6 is not displayed anymore (page 3). This used to work before (without the patch). In question c1 the "other"-item appears twice (on page 3 and 4).

regards,
Mirko
PS: The patch did not seem to match the new quexml library, so I searched the respective patch locations and incoporated the changes manually. Hope I didn't make a mistake there. For the next round of testing, could you maybe attach the complete libary? Thanks!
PPS: This is the branch on github I use for testing (now including the new library and the patch). Don't know if it's useful to you but here it is: https://github.com/mfaber/LimeSurvey/tree/quexml_pagination

adamzammit

adamzammit

2013-11-01 05:55

developer   ~27062

Hi Mirko,

I think you did the patching right but there was another bug. Attached is the updated queXMLPDF file with the fix attached. Let me know how you go.

Adam

mfaber

mfaber

2013-11-01 09:03

reporter   ~27063

Hi Adam,

In question c1 the "other"-item appears twice (on page 3 and 4). See new pdf and lss. Otherwise, despite my best efforts to reveal a pagination problem, I could not find one. :)

Thank you!
Mirko

adamzammit

adamzammit

2013-11-04 04:57

developer   ~27072

Hi Mirko,

Thanks again for your testing. I have attached a new version of the class which should resolve that bug.

Regards,
Adam Zammit

mfaber

mfaber

2013-11-04 10:25

reporter   ~27075

Hi Adam,

works well, thanks!

I think the new lib is fit for the 2.05 repository :).
Until there is a hint that more answer categories follow on the next page, I would suggest to have this feature switched off by default.

Another idea (don't hit me) would be to have a parameter specifying HOW/WHEN to split, so you could prevent a two answer category question (yes/no) to be distributed over two pages. Maybe something like "split_min", only split if splitting is on and a question has more than split_min (eg. 5) answer categories.

Anyway...feel free to upload the updated lib and set this issue to resolved...
If you're ok with it, i will issue 2 separate feature requests for the "next page message" and "split_min" ideas.

thanks again,
Mirko

adamzammit

adamzammit

2013-11-07 00:45

developer   ~27098

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13412

adamzammit

adamzammit

2013-11-07 00:48

developer   ~27099

Hi Mirko,

Thanks I have disabled by default as your suggestion.

Your other two suggestions are good. Please issue the feature requests here and if possible upstream as well https://bugs.launchpad.net/quexml and I'll get on to implementing them

Adam

mfaber

mfaber

2013-11-07 01:35

reporter   ~27100

Great! I have issued two feature requests and will set this to resolved.
Thanks,
Mirko

c_schmitz

c_schmitz

2013-11-25 15:39

administrator   ~27387

2.05RC7 released.

Related Changesets

LimeSurvey: 2.05 401f1d18

2013-11-06 23:40:12

adamzammit

Details Diff
Fixed issue 08220: quexf-pdf export: single answer question > 1 page are cut
Dev: Updated queXMLPDF class to upstream rev 101
Affected Issues
08220
mod - application/libraries/admin/quexmlpdf.php Diff File

LimeSurvey: master 0fcb1130

2014-01-23 12:00:47

mfaber


Committer: mfaber Details Diff
Dev: (QueXF) Enable splitting of single answer questions

Dev: Prevents page overflow.
Dev: Splitting is done only for questions with
Dev: many answer catergories
Affected Issues
08220
mod - application/libraries/admin/quexmlpdf.php Diff File

Issue History

Date Modified Username Field Change
2013-10-02 13:16 mfaber New Issue
2013-10-02 13:16 mfaber Status new => assigned
2013-10-02 13:16 mfaber Assigned To => mfaber
2013-10-02 13:16 mfaber Issue generated from: 08219
2013-10-02 13:17 mfaber Issue Monitored: adamzammit
2013-10-02 13:21 mfaber Note Added: 26473
2013-10-07 21:53 c_schmitz Assigned To mfaber => adamzammit
2013-10-07 21:53 c_schmitz Target Version => 2.05 RC
2013-10-25 07:10 adamzammit Issue Monitored: mfaber
2013-10-25 07:12 adamzammit Note Added: 26987
2013-10-25 07:12 adamzammit File Added: quexmlpdf.php
2013-10-25 08:56 c_schmitz Assigned To adamzammit => mfaber
2013-10-25 08:56 c_schmitz Status assigned => feedback
2013-10-25 19:48 mfaber Note Added: 26994
2013-10-25 19:48 mfaber Status feedback => assigned
2013-10-25 19:49 mfaber File Added: quexmlpdf_762212_en.pdf
2013-10-25 19:50 mfaber File Added: limesurvey_survey_762212.lss
2013-10-25 19:51 mfaber Assigned To mfaber => adamzammit
2013-10-28 05:13 adamzammit File Added: quexmlpdfbreakpatch.patch
2013-10-28 06:06 adamzammit Note Added: 27000
2013-10-30 18:40 mfaber Note Added: 27043
2013-10-30 18:40 mfaber File Added: 20131030.pdf
2013-11-01 05:54 adamzammit File Deleted: quexmlpdf.php
2013-11-01 05:54 adamzammit File Deleted: quexmlpdfbreakpatch.patch
2013-11-01 05:54 adamzammit File Added: quexmlpdf.php
2013-11-01 05:55 adamzammit Note Added: 27062
2013-11-01 09:03 mfaber Note Added: 27063
2013-11-01 09:04 mfaber File Added: 20131101.pdf
2013-11-01 09:04 mfaber File Added: 20131101.lss
2013-11-04 04:56 adamzammit File Deleted: quexmlpdf.php
2013-11-04 04:56 adamzammit File Added: quexmlpdf.php
2013-11-04 04:57 adamzammit Note Added: 27072
2013-11-04 10:25 mfaber Note Added: 27075
2013-11-07 00:45 adamzammit Changeset attached => LimeSurvey 2.05 401f1d18
2013-11-07 00:45 adamzammit Note Added: 27098
2013-11-07 00:45 adamzammit Resolution open => fixed
2013-11-07 00:48 adamzammit Note Added: 27099
2013-11-07 01:35 mfaber Note Added: 27100
2013-11-07 01:35 mfaber Relationship added related to 08344
2013-11-07 01:36 mfaber Relationship added related to 08343
2013-11-07 01:36 mfaber Status assigned => resolved
2013-11-07 01:36 mfaber Fixed in Version => 2.05 RC
2013-11-22 11:27 c_schmitz Fixed in Version 2.05 RC => 2.05+
2013-11-25 15:39 c_schmitz Note Added: 27387
2013-11-25 15:39 c_schmitz Status resolved => closed
2014-01-23 13:23 mfaber Changeset attached => LimeSurvey master 0fcb1130
2021-08-02 19:48 guest Bug heat 6 => 10