View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
08161 | Bug reports | Import/Export | public | 2013-09-15 08:44 | 2013-09-24 14:20 |
Reporter | mfaber | Assigned To | mfaber | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.00+ | ||||
Target Version | 2.05 RC | Fixed in Version | 2.05 RC | ||
Summary | 08161: quexf-pdf export: field lengths | ||||
Description | When exporting a survey using the quexml-export, the maximum_chars attribute is not taken into acount in text array (fixed to 10 characters) and number array question types. Furthermore, in short text questions, when no maximum_char value is set, field length defaults to 240 characters, effectively cluttering up the form. | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 130914 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | FF | ||||
Database type & version | MySQL 5.0.10 | ||||
Server OS (if known) | Win7 | ||||
Webserver software & version (if known) | Apache/2.4.3 (Win32) | ||||
PHP Version | PhP 5.4.7 | ||||
Hi Adam, issued a pull request on this one. It does not affect the quexml library, just the export helper...so there should be no upstream changed to be made. https://github.com/LimeSurvey/LimeSurvey/pull/126 Thanks |
|
Dear Mirko, I had a look at this request and I think making a decision in the export to choose a "longtext" field instead of a "text" field based on the maximum characters being > 50 isn't right. I think the user effectively chooses this by using a "short free text" or "long free text" question type in Limesurvey. If they choose "short free text" they should only get the equivalent "text" output in queXML - choosing "long free text" should give them the equivalent "longtext" output in queXML. Otherwise it is not clear to them what the will get in the paper output based on the Limesurvey questionnaire. Are you happy to leave that modification out but leave the other change in? Regards, |
|
Dear Adam, that makes sense. I'll update the pull request now. Thanks for reviewing |
|
Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13002 |
|
Thanks again! |
|
2.05RC1 released |
|
LimeSurvey: 2.05 07fb7639 2013-09-15 10:33 Committer: mfaber Details Diff |
Fixed issue 08161: (quexml-pdf) field lengths Dev: multi-flexi array text and number questions now honor Dev: maximum_chars attribute. Dev: Short free text question: when no maximum_chars value Dev: is given in attributes, field length defaults to 25, with values Dev: values above 50 (two lines of text), a text box will be used Dev: instead of the "form-type" text field. |
Affected Issues 08161 |
|
mod - application/helpers/export_helper.php | Diff File | ||
LimeSurvey: 2.05 605b0929 2013-09-16 08:22 Details Diff |
Merge pull request #126 from mfaber/quexf_fieldlength205 Fixed issue 08161: (quexml-pdf) field lengths |
Affected Issues 08161 |
|
mod - application/helpers/export_helper.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2013-09-15 08:44 | mfaber | New Issue | |
2013-09-15 08:44 | mfaber | Status | new => assigned |
2013-09-15 08:44 | mfaber | Assigned To | => mfaber |
2013-09-15 08:44 | mfaber | Issue generated from: 08159 | |
2013-09-15 08:48 | mfaber | Issue Monitored: adamzammit | |
2013-09-15 08:50 | mfaber | Note Added: 26220 | |
2013-09-16 04:50 | adamzammit | Note Added: 26242 | |
2013-09-16 08:07 | mfaber | Note Added: 26244 | |
2013-09-16 08:22 | mfaber | Changeset attached | => LimeSurvey 2.05 07fb7639 |
2013-09-16 08:22 | adamzammit | Changeset attached | => LimeSurvey 2.05 605b0929 |
2013-09-16 08:22 | adamzammit | Note Added: 26247 | |
2013-09-16 08:22 | adamzammit | Assigned To | mfaber => adamzammit |
2013-09-16 08:22 | adamzammit | Resolution | open => fixed |
2013-09-16 08:36 | mfaber | Note Added: 26248 | |
2013-09-16 08:36 | mfaber | Status | assigned => resolved |
2013-09-16 08:36 | mfaber | Fixed in Version | => 2.05 RC |
2013-09-16 08:36 | mfaber | Assigned To | adamzammit => mfaber |
2013-09-24 14:20 | c_schmitz | Note Added: 26347 | |
2013-09-24 14:20 | c_schmitz | Status | resolved => closed |