View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
08028 | Feature requests | Survey taking | public | 2013-07-22 12:33 | 2016-04-12 10:48 |
Reporter | Mazi | Assigned To | DenisChenu | ||
Priority | normal | Severity | feature | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.00+ | ||||
Fixed in Version | 2.06+ | ||||
Summary | 08028: File upload dialogue window can't be styled | ||||
Description | When using the file upload question type, it is nearly impossible to adjust a template to style the iframe which is shown after having clicked the "Upload files" link. | ||||
Steps To Reproduce | View the source code of a file upload question type. | ||||
Additional Information |
| ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 10 | ||||
Story point estimate | |||||
Users affected % | |||||
child of | 08178 | closed | DenisChenu | Bug reports | Upload file is broken in 2.05 (CRSF) |
Denis, can you have a look at this one? Carsten seems to be unavailable. |
|
Mazi : i really think Upload Quetsion type is .... bad coded . Don't work without JS etc ... I take a look but just adding template.css and template.js : is this OK ? PS: |
|
Great, Denis. I think the core problem are the hardcoded styles, especially for the iframe size. If we can move most of that to CSS, that would be nice. Another alterntive might be to set the size at the question attributes. |
|
Maybe :
You can update css in template.css, and you can use your own function in template.js But this one need a "No js ready upload system" then i put it in 2.1 system. |
|
Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13060 |
|
Mazi: to have a real way to have your own "opup": use your own doFileUpload() js function in template.js now. Think it's closed for 2.00. |
|
Bad function :i don't replace the 'modal dialog' open ..... Again : jsut a quick fix to allow to use own function in template. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14291 |
|
2 fix:
Think whole system must be rewrite without a iframe but for 2.1 or Question plugin |
|
Re-opened on user request. |
|
Yes, need more system on CSS for the upload.css. But it's a template issue. Not a core issue. Because I really don't have time on upload.css actually : move ro another, if another person have time |
|
Tony, what's your opinion on this? |
|
The fixes from Denis have improved the issue (see attached screenshot from IPhone) as the dialogue is now visible (not mostly off-screen) and hence can at least be closed. |
|
With FireFox OS and Opera for mobile : the button return to survey is show. But still the with f the page. For scrolling : really more difficult : scrolling in phone is really a pity. Denis |
|
Have fixed some in CSS for SkeletonQuest, fix it and move ot to anyone after. But : for a future release : upload QUestion in Plugin. I think the bug here is to save the files in same place than Survey file. Really awfull. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15079 |
|
Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15084 |
|
Version 2.50+ Build 140413 released |
|
LimeSurvey: 2.05 41ae8c05 2013-09-25 14:17 Details Diff |
Fixed issue 08178: Upload file is broken in 2.05 Fixed issue 08028: File upload dialogue window can't be styled (partial) Dev: can replace doFileUpload() js function by own function in template.js |
Affected Issues 08028, 08178 |
|
mod - application/controllers/UploaderController.php | Diff File | ||
mod - scripts/uploader.js | Diff File | ||
LimeSurvey: master e4069b9b 2013-09-25 14:47 Details Diff |
New feature 08028: File upload system can be replaced Dev: allow replacing doFileUpload(); js function Dev: close it for 2.00, TODO for 2.05: seperate doFileUpload in multi simple function Dev: for up to 2.05: new attribute in Plugin for file upload Dev: for 2.1: rewrite file upload |
Affected Issues 08028 |
|
mod - application/controllers/UploaderController.php | Diff File | ||
mod - scripts/uploader.js | Diff File | ||
LimeSurvey: master 52132007 2014-06-24 17:59 Details Diff |
Fixed issue 08028: File upload dialog function can be updated Dev: Add openUploadModalDialog js function, only when doc ready Dev: Fix the dialog width and heigth according to windows actual width and heigth Dev: Quick fix: all system must be rewrite without a iframe |
Affected Issues 08028 |
|
mod - scripts/modaldialog.js | Diff File | ||
LimeSurvey: master 458194ab 2015-04-09 15:29 Details Diff |
Fixed issue : Use capital on extension for file upload don't display file Dev: some fix for 08028 file upload dialog in little screen Dev: Fix only width set heigth, maybe have to adapat this too Dev: fix some css for upload frame Dev: HTML is really awfull (table with one line etc ..) fix with display:block, to do : fix it |
Affected Issues 08028 |
|
mod - application/controllers/UploaderController.php | Diff File | ||
mod - scripts/modaldialog.js | Diff File | ||
mod - scripts/uploader.js | Diff File | ||
mod - styles-public/uploader.css | Diff File | ||
LimeSurvey: 2.06 de95f90b 2015-04-10 16:00 Details Diff |
Fixed issue 08028: File upload dialogue window can't be styled Dev: except the table in "question" part all is done by css Dev: fix some HTML and javascript |
Affected Issues 08028 |
|
mod - application/controllers/UploaderController.php | Diff File | ||
mod - application/helpers/qanda_helper.php | Diff File | ||
mod - scripts/modaldialog.js | Diff File | ||
mod - scripts/uploader.js | Diff File | ||
add - styles-public/uploader-files.css | Diff File | ||
mod - styles-public/uploader.css | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2013-07-22 12:33 | Mazi | New Issue | |
2013-07-22 12:33 | Mazi | Status | new => assigned |
2013-07-22 12:33 | Mazi | Assigned To | => sammousa |
2013-07-22 14:56 | sammousa | Assigned To | sammousa => |
2013-08-16 11:59 | Mazi | Assigned To | => c_schmitz |
2013-08-31 13:01 | Mazi | Issue Monitored: DenisChenu | |
2013-08-31 13:02 | Mazi | Note Added: 26116 | |
2013-08-31 13:16 | DenisChenu | Note Added: 26117 | |
2013-08-31 13:16 | DenisChenu | Note Edited: 26117 | |
2013-08-31 13:20 | Mazi | Note Added: 26118 | |
2013-08-31 14:33 | DenisChenu | Note Added: 26119 | |
2013-09-15 18:32 | c_schmitz | Project | Bug reports => Feature requests |
2013-09-15 18:32 | c_schmitz | Assigned To | c_schmitz => |
2013-09-16 13:15 | Mazi | Assigned To | => DenisChenu |
2013-09-20 14:48 | DenisChenu | Relationship added | child of 08178 |
2013-09-25 14:17 | DenisChenu | Changeset attached | => LimeSurvey 2.05 41ae8c05 |
2013-09-25 14:17 | DenisChenu | Note Added: 26362 | |
2013-09-25 14:17 | DenisChenu | Resolution | open => fixed |
2013-09-25 15:21 | DenisChenu | Changeset attached | => LimeSurvey master e4069b9b |
2013-09-25 15:22 | DenisChenu | Note Added: 26365 | |
2013-09-25 15:22 | DenisChenu | Status | assigned => resolved |
2013-09-25 15:22 | DenisChenu | Fixed in Version | => 2.05+ |
2014-05-03 21:34 | c_schmitz | Status | resolved => closed |
2014-06-24 16:08 | DenisChenu | Note Added: 30223 | |
2014-06-24 16:08 | DenisChenu | Status | closed => feedback |
2014-06-24 16:08 | DenisChenu | Resolution | fixed => reopened |
2014-06-24 16:08 | DenisChenu | Status | feedback => new |
2014-06-24 16:08 | DenisChenu | Severity | @50@ => feature |
2014-06-24 16:08 | DenisChenu | Status | new => assigned |
2014-06-24 16:08 | DenisChenu | Fixed in Version | 2.05+ => |
2014-06-24 16:08 | DenisChenu | Target Version | 2.05 beta => |
2014-06-24 17:59 | DenisChenu | Changeset attached | => LimeSurvey master 52132007 |
2014-06-24 17:59 | DenisChenu | Note Added: 30224 | |
2014-06-24 18:12 | DenisChenu | Note Added: 30225 | |
2014-06-24 18:12 | DenisChenu | Status | assigned => resolved |
2014-06-24 18:12 | DenisChenu | Resolution | reopened => fixed |
2014-06-27 11:05 | Mazi | Note Added: 30236 | |
2014-06-27 11:05 | Mazi | Status | resolved => feedback |
2014-06-27 11:05 | Mazi | Resolution | fixed => reopened |
2014-06-27 11:21 | DenisChenu | Note Added: 30237 | |
2014-06-27 11:21 | DenisChenu | Note Edited: 30237 | |
2014-06-27 11:21 | DenisChenu | Assigned To | DenisChenu => |
2014-06-27 11:22 | DenisChenu | Assigned To | => DenisChenu |
2014-06-27 11:22 | DenisChenu | Status | feedback => new |
2014-06-27 11:22 | DenisChenu | Assigned To | DenisChenu => |
2014-06-27 11:50 | Mazi | Assigned To | => tpartner |
2014-06-27 11:50 | Mazi | Status | new => assigned |
2014-06-27 11:50 | Mazi | Note Added: 30238 | |
2014-06-27 12:01 | DLange | File Added: Screenshot_Uploader_iPhone.png | |
2014-06-27 12:05 | DLange | Note Added: 30239 | |
2014-06-27 12:10 | DenisChenu | Note Added: 30240 | |
2015-04-08 17:51 | DenisChenu | Assigned To | tpartner => DenisChenu |
2015-04-08 17:52 | DenisChenu | Note Added: 31966 | |
2015-04-09 15:30 | DenisChenu | Changeset attached | => LimeSurvey master 458194ab |
2015-04-09 15:30 | DenisChenu | Note Added: 31978 | |
2015-04-10 16:01 | DenisChenu | Changeset attached | => LimeSurvey 2.06 de95f90b |
2015-04-10 16:01 | DenisChenu | Note Added: 31983 | |
2015-04-11 12:21 | DenisChenu | Status | assigned => resolved |
2015-04-11 12:21 | DenisChenu | Fixed in Version | => 2.06+ |
2015-04-11 12:21 | DenisChenu | Resolution | reopened => fixed |
2016-04-12 10:48 | c_schmitz | Note Added: 37253 | |
2016-04-12 10:48 | c_schmitz | Status | resolved => closed |
2021-08-02 18:22 | guest | Bug heat | 8 => 10 |