View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
07782Bug reportsAccessibilitypublic2013-11-07 15:00
Reporterubuntourist Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Target Version2.05 RCFixed in Version2.00+ 
Summary07782: HTML5 misinterpretation of <track> nesting
Description

In HTML5, <track> should not nested inside of <source>. However, LimeSurvey converts

<video>
<source ... />
<track ... />
</video>

to:

<video>
<source ...>
<track ...>
</track>
</source>
</video>

Since there can be multiple source elements and multiple track elements that function independently, nesting <track> inside <source> breaks <track> if the browser chooses another <source> that does not contain the <track> element.

Steps To Reproduce

Enter into an HTML source window

<video preload="metadata"
controls="controls"
width="750" height="375">
<source src="http://...&quot; type="...mimetype..." />
<track src="http://...&quot; type="...mimetype..." kind="captions" />
</video>

where the sources and mime types are for videos and their subtitles / captions.
Save and close. Re-open and examine the source window.

TagsNo tags attached.
Attached Files
Bug heat6
Complete LimeSurvey version number (& build)130406
I will donate to the project if issue is resolvedNo
BrowserGoogle Chrome (and others)
Database type & versionPostgreSQL 8.4.13
Server OS (if known)Red Hat Enterprise Linux (RHEL) 6
Webserver software & version (if known)Apache 2.2.15
PHP Version5.3.3

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2013-04-22 10:28

developer   ~25029

Hello,

Maybe best is to deactivate "Inline HTML editor". Think it's a ckeditor bug and not a LS core bug.

Can you test with "Popup HTML editor" settings ?

c_schmitz

c_schmitz

2013-04-22 10:48

administrator   ~25032

http://dev.ckeditor.com/ticket/8119

c_schmitz

c_schmitz

2013-04-22 11:14

administrator   ~25033

Currently I do not see any quick solution on this. Maybe the CKEditor guys have an idea.

sammousa

sammousa

2013-04-22 23:46

reporter   ~25053

A work around would be to wrap all the tags in a quote as follows:
<div id="video"></div>
<script type="text/javascript">
$(document).ready(function() {
var tag = '<video preload="metadata"
controls="controls"
width="750" height="375">
<source src="http://...&quot; [^] type="...mimetype..." />
<track src="http://...&quot; [^] type="...mimetype..." kind="captions" />
</video>';
$('#video').html(tag);
}
</script>

It's ugly but it's a simple work around that'll always work.

-- If you have some JS / jQuery experience you could even implement a video JS function that takes the needed arguments (like sources and tracks) as a JS object and derives the correct syntax from that.

c_schmitz

c_schmitz

2013-07-22 15:28

administrator   ~25841

At http://dev.ckeditor.com/ticket/8119 someone proposed a solution. sammousa, can implement that without modifying the CKEditor core?

sammousa

sammousa

2013-08-16 12:10

reporter   ~26004

Unless ckeditor fixes this bug, this won't be fixed in 2.00+.

c_schmitz

c_schmitz

2013-10-30 22:05

administrator   ~27045

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=13391

c_schmitz

c_schmitz

2013-10-30 22:07

administrator   ~27047

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=13392

DenisChenu

DenisChenu

2013-10-31 10:19

developer   ~27050

Just:

Why support HTML5 if LS survey not support HTML5 ?

(really need a survey/question/ plugin here .... ;) )

c_schmitz

c_schmitz

2013-11-07 15:00

administrator   ~27130

Version 2.00+ Build 131107 released.

Related Changesets

LimeSurvey: master 22661054

2013-10-30 21:05:13

c_schmitz

Details Diff
Fixed issue 07782: HTML5 misinterpretation of <track> nesting
Dev Modified the CKEditor library directly. This is fixed in the latest version of CKEditor.
Affected Issues
07782
mod - third_party/ckeditor/_source/core/dtd.js Diff File

LimeSurvey: 2.05 9d4d0006

2013-10-30 21:05:13

c_schmitz

Details Diff
Fixed issue 07782: HTML5 misinterpretation of <track> nesting
Dev Modified the CKEditor library directly. This is fixed in the latest version of CKEditor.
Affected Issues
07782
mod - third_party/ckeditor/_source/core/dtd.js Diff File

Issue History

Date Modified Username Field Change
2013-04-20 23:44 ubuntourist New Issue
2013-04-20 23:44 ubuntourist File Added: limesurvey_survey_563849.lss
2013-04-22 10:28 DenisChenu Note Added: 25029
2013-04-22 10:48 c_schmitz Note Added: 25032
2013-04-22 11:14 c_schmitz Note Added: 25033
2013-04-22 11:14 c_schmitz Assigned To => c_schmitz
2013-04-22 11:14 c_schmitz Status new => acknowledged
2013-04-22 23:46 sammousa Note Added: 25053
2013-07-22 15:28 c_schmitz Assigned To c_schmitz => sammousa
2013-07-22 15:28 c_schmitz Status acknowledged => assigned
2013-07-22 15:28 c_schmitz Note Added: 25841
2013-08-16 12:10 sammousa Note Added: 26004
2013-08-16 12:10 sammousa Status assigned => confirmed
2013-10-07 11:25 c_schmitz Target Version => 2.05 RC
2013-10-29 14:38 c_schmitz Assigned To sammousa =>
2013-10-30 22:05 c_schmitz Changeset attached => LimeSurvey master 22661054
2013-10-30 22:05 c_schmitz Note Added: 27045
2013-10-30 22:05 c_schmitz Assigned To => c_schmitz
2013-10-30 22:05 c_schmitz Resolution open => fixed
2013-10-30 22:05 c_schmitz Status confirmed => assigned
2013-10-30 22:05 c_schmitz Status assigned => resolved
2013-10-30 22:05 c_schmitz Fixed in Version => 2.00+
2013-10-30 22:07 c_schmitz Changeset attached => LimeSurvey 2.05 9d4d0006
2013-10-30 22:07 c_schmitz Note Added: 27047
2013-10-31 10:19 DenisChenu Note Added: 27050
2013-11-07 15:00 c_schmitz Note Added: 27130
2013-11-07 15:00 c_schmitz Status resolved => closed