View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
07644Bug reportsSurvey editingpublic2013-03-08 10:362013-03-11 19:36
Reportersuisse Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Fixed in Version2.00+ 
Summary07644: {TEMPLATEURL} cannot be used in predefined labels inside "
Description

When using {TEMPLATEURL} in a predefined label, e.g. in order to use icons instead of text in a matrix question, it gets transformed to %7BTEMPLATEURL%7D when saving. This does not happen every time I do it.

If you workaround it by setting the text in phpMyAdmin, the labels show up right. But when using the label set in a question, suddenly whitespace is added and { TEMPLATEURL } will, of course, not be evaluated, thus the images do not show up.

As I cannot add more than one file, I chose to attach the label set, as you surely have a survey at hand where you can easily apply that set. I apologize if that was the bad choice...

Steps To Reproduce
  1. Create a label set and set text to {TEMPLATEURL}
  2. Store the set; it might or might not be stored correctly or URL encoded.
  3. Go to any matrix question and choose to edit sub questions or answer options
  4. Use label set and choose the newly created set
  5. The text will show up with white space around the braces.
TagsNo tags attached.
Attached Files
limesurvey_labelset_4.lsl (5,834 bytes)
limesurvey_survey_913582 (1).lss (16,817 bytes)
Bug heat6
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2013-03-08 11:04

developer   ~24580

Hello,

Just a comment:
Maybe TEMPLATEURL is a false good idea in Label set: because when you use Label Set you don't know the template used.

But still, using EM in label set have to be used, even if show error.
suisse

suisse

2013-03-08 11:10

reporter   ~24581

I do not quite agree on that. We are a company, so all our surveys use the same template in order to be consistent with the website design. I suppose that a lot of people use the same template over and over again.

This might, of course, be different on a hosted environment where you have different people from different entities and everyone has their own preferences when it comes to design.
Mazi

Mazi

2013-03-08 11:37

updater   ~24583

Last edited: 2013-03-08 11:38

Denis, you have already started discussing this issue so I assigned the ticket to you :-)

I also think that being able to use a placeholder for the paths makes sense.
DenisChenu

DenisChenu

2013-03-08 13:14

developer   ~24586

Last edited: 2013-03-08 13:16

Mazi : is there are already a placeholder for ROOTURL/PUBLICURL ?

Then we have to add this one ...

<quote> Denis, you have already started discussing this issue so I assigned the ticket to you :-)</quote>Like we say in France: "Allways turn seven times your tongue before speaking"
suisse

suisse

2013-03-08 13:17

reporter   ~24587

This will, of course, not resolve the issue -- at least not as long as white space is inserted between the curly braces and the placeholder.
DenisChenu

DenisChenu

2013-03-11 12:40

developer   ~24609

It's only with "{TEMPLATEURL}" . But updated model rules.
DenisChenu

DenisChenu

2013-03-11 12:42

developer   ~24610

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=11821

Related Changesets

LimeSurvey: master 897255a3

2013-03-11 12:37

DenisChenu


Details Diff		 Fixed issue 07644: {TEMPLATEURL} cannot be used in predefined labels inside "
Dev: updated model and add rules for xssfiltering		 Affected Issues
07644
mod - application/helpers/admin/label_helper.php Diff File
mod - application/models/Label.php Diff File

LimeSurvey: 2.05 d8999f70

2013-03-11 12:41

DenisChenu


Details Diff		 Fixed issue 07644: {TEMPLATEURL} cannot be used in predefined labels inside "
Dev: updated model and add rules for xssfiltering		 Affected Issues
07644
mod - application/helpers/admin/label_helper.php Diff File
mod - application/models/Label.php Diff File

Issue History

Date Modified Username Field Change
2013-03-08 10:36 suisse New Issue
2013-03-08 10:36 suisse File Added: limesurvey_labelset_4.lsl
2013-03-08 10:45 suisse File Added: limesurvey_survey_913582 (1).lss
2013-03-08 11:04 DenisChenu Note Added: 24580
2013-03-08 11:10 suisse Note Added: 24581
2013-03-08 11:37 Mazi Assigned To => DenisChenu
2013-03-08 11:37 Mazi Status new => assigned
2013-03-08 11:37 Mazi Note Added: 24583
2013-03-08 11:38 Mazi Note Edited: 24583
2013-03-08 13:14 DenisChenu Note Added: 24586
2013-03-08 13:16 DenisChenu Note Edited: 24586
2013-03-08 13:17 suisse Note Added: 24587
2013-03-11 12:40 DenisChenu Note Added: 24609
2013-03-11 12:41 DenisChenu Summary {TEMPLATEURL} cannot be used in predefined labels => {TEMPLATEURL} cannot be used in predefined labels inside "
2013-03-11 12:41 DenisChenu Project Feature requests => Bug reports
2013-03-11 12:42 DenisChenu Changeset attached => LimeSurvey master 897255a3
2013-03-11 12:42 DenisChenu Note Added: 24610
2013-03-11 12:42 DenisChenu Resolution open => fixed
2013-03-11 19:36 DenisChenu Changeset attached => LimeSurvey 2.05 d8999f70
2013-03-11 19:36 DenisChenu Status assigned => closed
2013-03-11 19:36 DenisChenu Fixed in Version => 2.00+
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing