View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
07159Bug reportsStatisticspublic2014-01-25 17:22
ReporterDenisChenu Assigned ToDenisChenu  
PrioritylowSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Target Version2.05 RCFixed in Version2.05+ 
Summary07159: PHP notice for arabic graph in statistics
Description

With graph statictics and debug to 2:
Undefined offset: -1 at /application/third_party/ar-php/Arabic/Glyphs.php(273)

Steps To Reproduce

Set debug to 2 with a arabic survey and test statistic

Additional Information

Maybe it's an ar-php issue: 3 solution :

  • see if a new ar-php version fix this issue
  • patch our own LS ar-php
  • report to ar-php bug system if exist ;) (beacuse i don't understand arabic :http://www.ar-php.org/)
TagsNo tags attached.
Attached Files
Bug heat4
Complete LimeSurvey version number (& build)130108
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)debian/linux
Webserver software & version (if known)apache
PHP VersionPHP Version 5.3

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2013-01-08 12:04

developer   ~23535

Tested with 3.5 : not same bug: post a topic in ar-php support

DenisChenu

DenisChenu

2013-01-08 12:10

developer   ~23536

https://sourceforge.net/p/ar-php/discussion/779212/thread/78fdf0d2/#b9dc

DenisChenu

DenisChenu

2013-01-21 13:04

developer   ~23728

Same think with ar-php 3.6

c_schmitz

c_schmitz

2013-02-22 21:53

administrator   ~24205

shnoulle: Can you attach a small sample survey as .lsa to reproduce?

DenisChenu

DenisChenu

2013-02-23 09:54

developer   ~24207

Done,

But have already the fix and it's only with debug=2.

:)

DenisChenu

DenisChenu

2013-02-23 09:55

developer   ~24208

The fix with 3.5:
Undefined variable: en_start
/ar-php/Arabic/Glyphs.php(440)

// need more work to fix lines starts by English words
if ($en_start) {

Think it can be replaced by:

if ($en_index) {

c_schmitz

c_schmitz

2013-02-24 16:39

administrator   ~24231

I agree that this is a bug in ar-php - the $en_start variable is defined nowhere.
However your proposed fix does not work, sadly.

DenisChenu

DenisChenu

2013-02-24 17:54

developer   ~24236

I test with 3.5 and seems to work good ?

What is the problem ?

Denis

c_schmitz

c_schmitz

2013-09-18 16:55

administrator   ~26281

I have the same problem (With graph statictics and debug to 2:
Undefined offset: -1 at /application/third_party/ar-php/Arabic/Glyphs.php(2281)) using version 3.6 ?

DenisChenu

DenisChenu

2013-09-18 17:08

developer   ~26282

Last edited: 2013-09-18 17:10

No,

With replacing
if ($en_start) {
by
if ($en_index) {

It fix the undefined offset. Not sure it fix ar-php but fix undefined offset.

No news from ar-php dev. And i can not really test because i don't have a lot of arabic test and didn't understand one word in arabic ...
ANd i don't found how to report patch in sf.net now ???

c_schmitz

c_schmitz

2013-10-07 13:54

administrator   ~26582

Try to report it here. http://sourceforge.net/p/ar-php/bugs/

If it works for you please implement the change for 2.05 - seems to be a rare bug anyway.

DenisChenu

DenisChenu

2013-10-08 12:12

developer   ~26616

I can not find the link to report a bug :
https://sourceforge.net/p/ar-php/discussion/779212/thread/409e37f0/?limit=25#eda2

and:
https://sourceforge.net/p/ar-php/discussion/779212/thread/78fdf0d2/

If you find the 'post new bug" button it can be great ;)

DenisChenu

DenisChenu

2014-01-22 16:45

developer   ~28082

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13742

DenisChenu

DenisChenu

2014-01-22 16:47

developer   ~28083

Update to 3.6.0
And fix ONLY the php notice

DenisChenu

DenisChenu

2014-01-22 17:05

developer   ~28089

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13744

DenisChenu

DenisChenu

2014-01-22 17:49

developer   ~28094

Last edited: 2014-01-22 17:49

Make a fork : https://github.com/Shnoulle/Ar-PHP

And contact dev:
https://sourceforge.net/p/ar-php/discussion/779212/thread/dc72b9db/?limit=25#978f
(by email too)

c_schmitz

c_schmitz

2014-01-25 17:22

administrator   ~28147

2.05+ Build 140125 released

Related Changesets

LimeSurvey: master 076d51db

2014-01-22 15:45:35

DenisChenu

Details Diff
Fixed issue 07159: PHP notice for arabic graph in statistics
Dev: update to ar-php 3.6.0
Dev: add fix for php notice ONLY
Dev: ar-php have issue with sentence starting without arabic caracter
Affected Issues
07159
mod - application/third_party/ar-php/Arabic.php Diff File
mod - application/third_party/ar-php/Arabic/Glyphs.php Diff File

LimeSurvey: master f5e791dc

2014-01-22 16:01:00

DenisChenu

Details Diff
Fixed issue 07159: PHP notice for arabic graph in statistics
Dev: this time REALLY update to ar-php 3.6.0
Dev: add fix for php notice ONLY
Affected Issues
07159
mod - application/third_party/ar-php/Arabic.php Diff File
mod - application/third_party/ar-php/Arabic/AutoSummarize.php Diff File
mod - application/third_party/ar-php/Arabic/Changes Diff File
mod - application/third_party/ar-php/Arabic/CharsetC.php Diff File
mod - application/third_party/ar-php/Arabic/CharsetD.php Diff File
mod - application/third_party/ar-php/Arabic/CompressStr.php Diff File
rm - application/third_party/ar-php/Arabic/Data.php Diff File
mod - application/third_party/ar-php/Arabic/Date.php Diff File
mod - application/third_party/ar-php/Arabic/Docs.zip Diff File
mod - application/third_party/ar-php/Arabic/Examples.zip Diff File
mod - application/third_party/ar-php/Arabic/Gender.php Diff File
mod - application/third_party/ar-php/Arabic/Glyphs.php Diff File
mod - application/third_party/ar-php/Arabic/Hiero.php Diff File
mod - application/third_party/ar-php/Arabic/Identifier.php Diff File
mod - application/third_party/ar-php/Arabic/KeySwap.php Diff File
mod - application/third_party/ar-php/Arabic/Mktime.php Diff File
mod - application/third_party/ar-php/Arabic/Normalise.php Diff File
mod - application/third_party/ar-php/Arabic/Numbers.php Diff File
mod - application/third_party/ar-php/Arabic/Query.php Diff File
mod - application/third_party/ar-php/Arabic/Salat.php Diff File
mod - application/third_party/ar-php/Arabic/Soundex.php Diff File
mod - application/third_party/ar-php/Arabic/Standard.php Diff File
mod - application/third_party/ar-php/Arabic/Stemmer.php Diff File
mod - application/third_party/ar-php/Arabic/StrToTime.php Diff File
mod - application/third_party/ar-php/Arabic/Transliteration.php Diff File
mod - application/third_party/ar-php/Arabic/WordTag.php Diff File
mod - application/third_party/ar-php/Arabic/data/ArQuery.xml Diff File
mod - application/third_party/ar-php/Arabic/data/arab_countries.xml Diff File
add - application/third_party/ar-php/Arabic/images.zip Diff File

LimeSurvey: master 40ebd35e

2014-01-22 16:33:52

DenisChenu

Details Diff
Dev: better patch for ar-php for bug 07159
Dev: see https://sourceforge.net/p/ar-php/discussion/779212/thread/dc72b9db/
Affected Issues
07159
mod - application/third_party/ar-php/Arabic/Glyphs.php Diff File

Issue History

Date Modified Username Field Change
2013-01-08 11:52 DenisChenu New Issue
2013-01-08 12:04 DenisChenu Note Added: 23535
2013-01-08 12:04 DenisChenu Assigned To => DenisChenu
2013-01-08 12:04 DenisChenu Status new => assigned
2013-01-08 12:10 DenisChenu Note Added: 23536
2013-01-21 13:04 DenisChenu Note Added: 23728
2013-02-22 21:53 c_schmitz Note Added: 24205
2013-02-23 09:54 DenisChenu File Added: survey_archive_515576.lsa
2013-02-23 09:54 DenisChenu Note Added: 24207
2013-02-23 09:55 DenisChenu Note Added: 24208
2013-02-24 16:39 c_schmitz Note Added: 24231
2013-02-24 17:54 DenisChenu Note Added: 24236
2013-09-18 16:55 c_schmitz Note Added: 26281
2013-09-18 17:08 DenisChenu Note Added: 26282
2013-09-18 17:10 DenisChenu Note Edited: 26282
2013-10-07 13:54 c_schmitz Note Added: 26582
2013-10-07 13:54 c_schmitz Target Version => 2.05 RC
2013-10-08 12:12 DenisChenu Note Added: 26616
2014-01-22 16:45 DenisChenu Changeset attached => LimeSurvey master 076d51db
2014-01-22 16:45 DenisChenu Note Added: 28082
2014-01-22 16:45 DenisChenu Resolution open => fixed
2014-01-22 16:47 DenisChenu Note Added: 28083
2014-01-22 16:47 DenisChenu Status assigned => resolved
2014-01-22 16:47 DenisChenu Fixed in Version => 2.05+
2014-01-22 17:05 DenisChenu Changeset attached => LimeSurvey master f5e791dc
2014-01-22 17:05 DenisChenu Note Added: 28089
2014-01-22 17:34 DenisChenu Changeset attached => LimeSurvey master 40ebd35e
2014-01-22 17:49 DenisChenu Note Added: 28094
2014-01-22 17:49 DenisChenu Note Edited: 28094
2014-01-25 17:22 c_schmitz Note Added: 28147
2014-01-25 17:22 c_schmitz Status resolved => closed