View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
07097 | Bug reports | Survey participants (Tokens) | public | 2012-12-17 11:51 | 2013-02-25 11:42 |
Reporter | pfpDave | Assigned To | mdekker | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.00+ | ||||
Fixed in Version | 2.00+ | ||||
Summary | 07097: View response details only appears once survey fully completed even when token persistence set | ||||
Description | If token persistence is set and a user has partially completed a survey, there's no easy way to find the partial response (more noticeable on large surveys), the 'View response details' magnifying glass icon doesn't appear in the token list until the survey has been fully completed. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 121127 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | IE8 | ||||
Database type & version | SQL Express 2012 | ||||
Server OS (if known) | Server 2008 | ||||
Webserver software & version (if known) | IIS 7 | ||||
PHP Version | 5.4.8 | ||||
Menno, since you touched this recently - can you make the magnifying glass icon visible if there is a partial response and token persistence is activated? |
|
Another note: I see you replaced the input icons with linked icons (which is great!) for issue 07082 - but the icon position is wrong since then (positioning and spacing) - can you please have a look at this too? Thank you ;). |
|
Can you explain what you mean by misplaced? In blobblueish it looks ok, maybe a little tight on the spacing, but I don't see what is wrong with the positioning. |
|
I can see that now too ... have uploaded a jpeg of the differences in spacing before and after the changes. |
|
Ok had another look, i think i see what you mean with position, it leaves me one question: the magnifying glass and gear icon share the same position. That makes it impossible to have both for an uncompleted repsonse I think. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=11266 |
|
Think we can add : do the survey if Uses left are up to 0 (or allow edit answer) (in token browse) For view response detail : why not for all respoinse, even if not closed ? Need a larger cell, or icon on :over only. |
|
did you check out my last commit? I always add the show response icon when it is not anonymous and a token is found in the responses. It takes you to the browse response screen, filtered on the token so you can see all (partial + complete) responses for that particular token. |
|
pfpDave, feedback please? |
|
Just upgraded my test environment to the latest build hoping to test this quickly for you but looks like Web Auth is broken again in this new build :( Will test properly later but it isn't asking me to login, simply giving me the error 'Incorrect username and/or password!' on the login screen, refreshing the page and closing and re-opening the browser return the same result when visiting http://platform_url/admin I have very little time at the moment so will have to park this for now. |
|
There was a patch for 07049 . Please have a look if reverting that patch resolves your web auth issue. |
|
Looking at the code, it does look like that's what will have broken my Web Auth ... Remote_user and Logon_user are both set for me (to the same), the issue is that the code block for logon_user will remove the 'domain\' prefix but the new code block for Remote_user doesn't ie this line: $sUser = substr($sUser, strrpos($sUser, "\")+1); To expand, the server variables grab my username as DOMAIN\USERID and the code needs only to match the 'USERID' part. Dave |
|
OK have now tested (by the way I got an error about language params 'langcode param is undefined' when I logged in, corrected by editing my profile and clicking save ... DB script required for this upgrade perhaps??) Error attached FYI. Changes is exactly what I was after, thanks ... slight spacing issue which is incredibly minor and I wouldn't normally mention but may be of interest ... first is that the sort toggle icon is half hidden to start with and then when column expanded to view up and down arrows don't line up ... are they meant to? Images uploaded FYI. For me though this can be closed, thanks again. |
|
Argh can you delete that last htm file I uploaded please? |
|
Done. |
|
LimeSurvey: master d58c2e85 2013-01-07 10:19 Details Diff |
dev: fixed icon position in token browse screen + added bg color to hover on jqgrid tables |
Affected Issues 07097 |
|
mod - application/controllers/admin/tokens.php | Diff File | ||
mod - styles/adminstyle.css | Diff File | ||
mod - styles/gringegreen/adminstyle.css | Diff File | ||
LimeSurvey: 2.1 ccddcbf5 2013-01-07 11:09 Details Diff |
dev: fixed icon position in token browse screen + added bg color to hover on jqgrid tables deV: also fixed footer height in browsetable (response browsing) |
Affected Issues 07097 |
|
mod - styles/adminstyle.css | Diff File | ||
mod - styles/blobblueish/adminstyle.css | Diff File | ||
mod - styles/gringegreen/adminstyle.css | Diff File | ||
LimeSurvey: master e5bbcea8 2013-01-07 11:10 Details Diff |
dev: fixed footer height in repsonse browsing |
Affected Issues 07097 |
|
mod - styles/blobblueish/adminstyle.css | Diff File | ||
mod - styles/gringegreen/adminstyle.css | Diff File | ||
LimeSurvey: master 1228f6dd 2013-01-15 16:08 Details Diff |
Fixed 07097: View response details only appears once survey fully completed even when token persistence set dev: needed to make action column a little wide to make it fit |
Affected Issues 07097 |
|
mod - application/controllers/admin/responses.php | Diff File | ||
mod - application/controllers/admin/tokens.php | Diff File | ||
mod - application/views/admin/token/browse.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-12-17 11:51 | pfpDave | New Issue | |
2013-01-05 15:19 | c_schmitz | Assigned To | => c_schmitz |
2013-01-05 15:19 | c_schmitz | Status | new => assigned |
2013-01-05 15:39 | c_schmitz | Assigned To | c_schmitz => mdekker |
2013-01-05 15:40 | c_schmitz | Note Added: 23473 | |
2013-01-05 15:42 | c_schmitz | Note Added: 23474 | |
2013-01-07 08:58 | mdekker | Note Added: 23507 | |
2013-01-07 09:41 | pfpDave | Note Added: 23508 | |
2013-01-07 09:41 | pfpDave | File Added: Response changes.jpg | |
2013-01-07 09:43 | mdekker | Note Added: 23509 | |
2013-01-07 10:20 | mdekker | Changeset attached | => LimeSurvey master d58c2e85 |
2013-01-07 11:11 | mdekker | Changeset attached | => LimeSurvey 2.1 ccddcbf5 |
2013-01-07 11:11 | mdekker | Changeset attached | => LimeSurvey master e5bbcea8 |
2013-01-15 16:08 | mdekker | Changeset attached | => LimeSurvey master 1228f6dd |
2013-01-15 16:08 | mdekker | Note Added: 23691 | |
2013-01-15 16:08 | mdekker | Resolution | open => fixed |
2013-01-16 12:12 | DenisChenu | Note Added: 23692 | |
2013-01-16 12:16 | mdekker | Note Added: 23694 | |
2013-01-16 12:16 | mdekker | Note Edited: 23694 | |
2013-02-22 21:45 | c_schmitz | Note Added: 24203 | |
2013-02-22 21:45 | c_schmitz | Status | assigned => feedback |
2013-02-25 10:13 | pfpDave | Note Added: 24249 | |
2013-02-25 10:13 | pfpDave | Status | feedback => assigned |
2013-02-25 10:55 | c_schmitz | Note Added: 24253 | |
2013-02-25 10:56 | c_schmitz | Status | assigned => feedback |
2013-02-25 11:09 | pfpDave | Note Added: 24254 | |
2013-02-25 11:09 | pfpDave | Status | feedback => assigned |
2013-02-25 11:19 | pfpDave | Note Added: 24256 | |
2013-02-25 11:19 | pfpDave | File Added: spacing1.jpg | |
2013-02-25 11:19 | pfpDave | File Added: spacing2.jpg | |
2013-02-25 11:19 | pfpDave | File Added: lang param error User warning.htm | |
2013-02-25 11:21 | pfpDave | Note Added: 24258 | |
2013-02-25 11:22 | c_schmitz | File Deleted: lang param error User warning.htm | |
2013-02-25 11:22 | c_schmitz | Note Added: 24259 | |
2013-02-25 11:23 | c_schmitz | Status | assigned => resolved |
2013-02-25 11:23 | c_schmitz | Fixed in Version | => 2.00+ |
2013-02-25 11:23 | pfpDave | Status | resolved => feedback |
2013-02-25 11:23 | pfpDave | Resolution | fixed => reopened |
2013-02-25 11:27 | pfpDave | Status | feedback => assigned |
2013-02-25 11:38 | c_schmitz | Issue cloned: 07329 | |
2013-02-25 11:38 | c_schmitz | Relationship added | related to 07329 |
2013-02-25 11:42 | c_schmitz | Status | assigned => closed |
2013-02-25 11:42 | c_schmitz | Resolution | reopened => fixed |
2016-12-08 10:39 | c_schmitz | Category | Tokens => Survey participants (Tokens) |