Well, strictly speaking this is correct because the condition on that question has not been met.
Shnoulle, do you see an easy way to fix this? I did have a looong look but were not able to come up with a solution. It would be ugly, anyway, because essentially it means that we override EM, somehow.

Yes, some idea, but not really tested.

In 1.92, there are some javascript for question group, but it break all other javascripting ... (for example the "Exclusive option" settings).

I can look at this one next week.
A lot of patch to do actually ;) and this week end is closed, i go to a "The Lord of the Rings Night", the trilogy on a big screen \o/

In 1.92, there was extra javascript for question preview to essentially disable relevance for that question, forcing it to be displayed.

Thomas,

Can you give me some help please, i want to remove the inline <style="display:none"> because is set in HTML not only via javascript.

The i make a
grep -R "display:none" *

But don't find where is set for questionid.

Denis

In 1.92 I found:
https://github.com/LimeSurvey/LimeSurvey/blob/1.92/admin/preview.php

it always does a show on the question in the javascript... maybe that is a pointer in the right direction?

In 2.00 question preview is handled via controllers/survey/index/. The question preview code is in controllers/admin/question that should be merged.

In surveyruntime helper (around line 863) there is specific javascript for preview group, but not for question.

@Schnoulle, can you fix this or should I give it a try?

Fix was easier than I thought... I will commit in a sec, maybe someone can review it before release.

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10884

Hi mdekker,

I'm not sure I understand the need for the $(document).change() function or the keydown event on the tab key but, if they are required, I think maybe this:

$('#question'. LEMqid).show();

Should be this:

$('#question'+LEMqid).show();

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10887

Tony: not it's php not js :).

Denis, I don't think it's supposed to be PHP, it's not wrapped in double-quotes or followed by a dot.

When formatted as valid JS, '#question'+LEMqid+'' returns the same as '#question" . $_qid . "'.

'#question" . $_qid . "' => #questionTHENUMBEROFTHEQUESTION directly in the source .

No ?

(see source ;) )

Er...no...see my screenshot of the source :)

Yes, you're right, first is OK, not the second.

Send a quick patch
https://github.com/LimeSurvey/LimeSurvey/commit/4e30e773c310604226328abd33ef31eaa5689eed

Thanks Denis.

I still don't get the reason for the "change" and "keydown" handlers. I just don't see what they could do.

But, if you are re-doing it for 2.1, I guess they can stay. As Menno says, they're not hurting anything.

Hello Tony,

With EM:
Hidding question in HTML
Hidding question in Javascript 3 or 4 times .

Working now.

mdekker fix and mine is OK.

New version 2.00 build 120206 released.