06990: Changing Question to None causes a JS Error in IE8 Compatibility view (IE7) (With fix)

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

06990	Bug reports	Survey editing	public	2012-11-29 18:36	2012-12-04 13:16

Reporter	pfpDave	Assigned To	tpartner
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Product Version	2.00+

Summary	06990: Changing Question to None causes a JS Error in IE8 Compatibility view (IE7) (With fix)
Description	Due to a another but, IE8 is switching to compatibility view frequently, which prevents the 'None' option working in a question group. The fix is very simple: Change /application/helpers/common_helper.php line 625 from: `$sQuestionselecter = "<option>".$clang->gT("None")."</option>\n".$sQuestionselecter;` to: `$sQuestionselecter = "<option value=\"none\">".$clang->gT("None")."</option>\n".$sQuestionselecter;`
Tags	No tags attached.

Bug heat	4
Complete LimeSurvey version number (& build)	121127
I will donate to the project if issue is resolved	No
Browser	IE8
Database type & version	SQL Express 2012
Server OS (if known)	Server 2008
Webserver software & version (if known)	IIS 7
PHP Version	5.4.8

User List	There are no users monitoring this issue.

tpartner 2012-12-01 13:48 partner ~22783	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10639

tpartner 2012-12-01 13:49 partner ~22784	Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10640

tpartner 2012-12-01 13:51 partner ~22785	pfpDave, I'm not sure we want to give that option a specific value so I just gave it a blank one. Thanks for the report and fix. Fixed in 2.0 & 2.1

c_schmitz 2012-12-04 13:16 administrator ~22851	LimeSurvey 2.0+ build 121204 released.

LimeSurvey: master 5331c9fc 2012-12-01 12:48:37 tpartner Details Diff	Fixed issue 06990: Changing Question to None causes a JS Error in IE8 Compatibility view (IE7) (With fix) Dev Added an empty value attribute for IE < 9	Affected Issues 06990
	mod - application/helpers/common_helper.php	Diff File
LimeSurvey: 2.1 7285145e 2012-12-01 12:48:53 tpartner Details Diff	Fixed issue 06990: Changing Question to None causes a JS Error in IE8 Compatibility view (IE7) (With fix) Dev Added an empty value attribute for IE < 9	Affected Issues 06990
	mod - application/helpers/common_helper.php	Diff File

Date Modified	Username	Field	Change
2012-11-29 18:36	pfpDave	New Issue
2012-12-01 13:47	tpartner	Assigned To	=> tpartner
2012-12-01 13:47	tpartner	Status	new => assigned
2012-12-01 13:48	tpartner	Changeset attached	=> LimeSurvey master 5331c9fc
2012-12-01 13:48	tpartner	Note Added: 22783
2012-12-01 13:48	tpartner	Resolution	open => fixed
2012-12-01 13:49	tpartner	Changeset attached	=> LimeSurvey 2.1 7285145e
2012-12-01 13:49	tpartner	Note Added: 22784
2012-12-01 13:51	tpartner	Note Added: 22785
2012-12-01 13:51	tpartner	Status	assigned => resolved
2012-12-04 13:16	c_schmitz	Note Added: 22851
2012-12-04 13:16	c_schmitz	Status	resolved => closed
2019-11-01 17:25	c_schmitz	Category	Survey design => Survey editing