View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
06958Bug reportsSurvey participants (Tokens)public2012-12-04 13:16
ReporterpfpDave Assigned Tomdekker  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary06958: Error 2048 intermittently when adding tokens to CPD from survey with custom attributes set
Description

I've seen this a few times now but it doesn't appear to do it all the time. To reproduce:

  1. Add 2 custom attributes to a survey and the same 2 to the CPD
  2. Add participants (I imported from LDAP) with custom attributes
  3. Tick 'Select all' checkbox to select 25 participants
  4. click 'Add Participants to Central Database' button
  5. Map the attributes from the survey to the CPD
  6. Click Continue
  7. Note the error below.
  8. The participants appear to be added as required
  9. Delete the participants and then start from step 3
  10. Note at step 5 that one attribute is pre-mapped, the other is not
  11. Error appears again, next time both attributes are pre-mapped and no error.

NB: The pre-mapped attributes don't have friendly names ie 'attribute_cpdb_2'

NB I Also get a minor JS error on the mapping screen (but I always get this):

TypeError: $(this).qtip is not a function
[Break On This Error]
hide: {when: 'mouseout'}

<h1>PHP Error [2048]</h1>
<p>Non-static method ParticipantAttributeNames::getAttributeNames() should not be called statically, assuming $this from incompatible context (C:\limesurvey_test\application\models\Participants.php:1265)</p>
<pre>#0 C:\limesurvey_test\application\models\Participants.php(1265): LSYii_Application->handleError()
#1 C:\limesurvey_test\application\controllers\admin\participantsaction.php(1735): Participants->copyToCentral()
#2 unknown(0): participantsaction->addToCentral()
#3 C:\limesurvey_test\framework\web\actions\CAction.php(107): ReflectionMethod->invokeArgs()
#4 C:\limesurvey_test\application\core\Survey_Common_Action.php(82): participantsaction->runWithParamsInternal()
#5 C:\limesurvey_test\framework\web\CController.php(309): participantsaction->runWithParams()
#6 C:\limesurvey_test\framework\web\CController.php(287): AdminController->runAction()
#7 C:\limesurvey_test\framework\web\CController.php(266): AdminController->runActionWithFilters()
#8 C:\limesurvey_test\application\controllers\AdminController.php(159): AdminController->run()
#9 C:\limesurvey_test\framework\web\CWebApplication.php(276): AdminController->run()
#10 C:\limesurvey_test\framework\web\CWebApplication.php(135): LSYii_Application->runController()
#11 C:\limesurvey_test\framework\base\CApplication.php(162): LSYii_Application->processRequest()
#12 C:\limesurvey_test\index.php(178): LSYii_Application->run()
</pre>

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)121121
I will donate to the project if issue is resolvedNo
BrowserIE8
Database type & versionSQL Express 2012
Server OS (if known)Server 2008
Webserver software & version (if known)IIS 7
PHP Version5.4.8

Users monitoring this issue

There are no users monitoring this issue.

Activities

mdekker

mdekker

2012-11-28 16:45

reporter   ~22642

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=10529

mdekker

mdekker

2012-11-28 16:45

reporter   ~22643

Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=10530

mdekker

mdekker

2012-11-28 16:45

reporter   ~22644

replaced static calls

pfpDave

pfpDave

2012-11-28 16:59

reporter   ~22647

Test on build 121127 (using participants.php file from Master branch below) and behaviour is identical. Error below. Also the JS error still exists:

TypeError: $(this).qtip is not a function
[Break On This Error]

hide: {when: 'mouseout'}

Error:

<h1>PHP Error [2048]</h1>
<p>Non-static method ParticipantAttributeNames::getAttributeNames() should not be called statically, assuming $this from incompatible context (C:\limesurvey_test\application\models\Participants.php:1271)</p>
<pre>#0 C:\limesurvey_test\application\models\Participants.php(1271): LSYii_Application->handleError()
#1 C:\limesurvey_test\application\controllers\admin\participantsaction.php(1735): Participants->copyToCentral()
#2 unknown(0): participantsaction->addToCentral()
#3 C:\limesurvey_test\framework\web\actions\CAction.php(107): ReflectionMethod->invokeArgs()
#4 C:\limesurvey_test\application\core\Survey_Common_Action.php(82): participantsaction->runWithParamsInternal()
#5 C:\limesurvey_test\framework\web\CController.php(309): participantsaction->runWithParams()
#6 C:\limesurvey_test\framework\web\CController.php(287): AdminController->runAction()
#7 C:\limesurvey_test\framework\web\CController.php(266): AdminController->runActionWithFilters()
#8 C:\limesurvey_test\application\controllers\AdminController.php(159): AdminController->run()
#9 C:\limesurvey_test\framework\web\CWebApplication.php(276): AdminController->run()
#10 C:\limesurvey_test\framework\web\CWebApplication.php(135): LSYii_Application->runController()
#11 C:\limesurvey_test\framework\base\CApplication.php(162): LSYii_Application->processRequest()
#12 C:\limesurvey_test\index.php(178): LSYii_Application->run()
</pre>

mdekker

mdekker

2012-11-28 20:08

reporter   ~22655

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=10536

mdekker

mdekker

2012-11-28 20:09

reporter   ~22656

Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=10539

mdekker

mdekker

2012-11-28 20:10

reporter   ~22657

I missed two static calls. Think I fixed the js error too.

pfpDave

pfpDave

2012-11-29 10:37

reporter   ~22672

That looks much better, very many thanks!

c_schmitz

c_schmitz

2012-12-04 13:16

administrator   ~22870

LimeSurvey 2.0+ build 121204 released.

Related Changesets

LimeSurvey: master 327b5c92

2012-11-28 15:44:51

mdekker

Details Diff
Fixed 06958: Error 2048 intermittently when adding tokens to CPD from survey with custom attributes set Affected Issues
06958
mod - application/models/Participants.php Diff File

LimeSurvey: 2.1 fdaa9670

2012-11-28 15:44:59

mdekker

Details Diff
Fixed 06958: Error 2048 intermittently when adding tokens to CPD from survey with custom attributes set Affected Issues
06958
mod - application/models/Participants.php Diff File

LimeSurvey: master 1d2cdb8f

2012-11-28 18:34:25

mdekker

Details Diff
Fixed 06958: Error 2048 intermittently when adding tokens to CPD from survey with custom attributes set Affected Issues
06958
mod - application/models/ParticipantAttributeNames.php Diff File
mod - application/models/Participants.php Diff File

LimeSurvey: 2.1 4c60d780

2012-11-28 18:34:45

mdekker

Details Diff
Fixed 06958: Error 2048 intermittently when adding tokens to CPD from survey with custom attributes set Affected Issues
06958
mod - application/models/ParticipantAttributeNames.php Diff File
mod - application/models/Participants.php Diff File

LimeSurvey: master 5b9c8eeb

2012-11-28 19:05:07

mdekker

Details Diff
Fixed 06958: Error 2048 intermittently when adding tokens to CPD from survey with custom attributes set Affected Issues
06958
mod - application/controllers/admin/participantsaction.php Diff File
mod - application/views/admin/participants/attributeMapToken_view.php Diff File

LimeSurvey: 2.1 cf859546

2012-11-28 19:05:27

mdekker

Details Diff
Fixed 06958: Error 2048 intermittently when adding tokens to CPD from survey with custom attributes set Affected Issues
06958
mod - application/controllers/admin/participantsaction.php Diff File
mod - application/views/admin/participants/attributeMapToken_view.php Diff File
mod - application/views/admin/participants/attributeMap_view.php Diff File

Issue History

Date Modified Username Field Change
2012-11-26 14:13 pfpDave New Issue
2012-11-28 16:43 mdekker Assigned To => mdekker
2012-11-28 16:43 mdekker Status new => assigned
2012-11-28 16:45 mdekker Changeset attached => LimeSurvey master 327b5c92
2012-11-28 16:45 mdekker Note Added: 22642
2012-11-28 16:45 mdekker Resolution open => fixed
2012-11-28 16:45 mdekker Changeset attached => LimeSurvey 2.1 fdaa9670
2012-11-28 16:45 mdekker Note Added: 22643
2012-11-28 16:45 mdekker Note Added: 22644
2012-11-28 16:59 pfpDave Note Added: 22647
2012-11-28 20:08 mdekker Changeset attached => LimeSurvey master 1d2cdb8f
2012-11-28 20:08 mdekker Changeset attached => LimeSurvey master 5b9c8eeb
2012-11-28 20:08 mdekker Note Added: 22655
2012-11-28 20:09 mdekker Changeset attached => LimeSurvey 2.1 4c60d780
2012-11-28 20:09 mdekker Changeset attached => LimeSurvey 2.1 cf859546
2012-11-28 20:09 mdekker Note Added: 22656
2012-11-28 20:10 mdekker Note Added: 22657
2012-11-29 10:37 pfpDave Note Added: 22672
2012-11-29 11:02 mdekker Status assigned => resolved
2012-11-29 11:02 mdekker Fixed in Version => 2.00+
2012-12-04 13:16 c_schmitz Note Added: 22870
2012-12-04 13:16 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)