View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
06946 | Bug reports | Survey editing | public | 2012-11-24 10:34 | 2013-02-26 20:03 |
Reporter | damien | Assigned To | damien | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.00+ | ||||
Fixed in Version | 2.00+ | ||||
Summary | 06946: "Quick-add" fail to parse expressions with ' " ' | ||||
Description | The "Quick-add" feature in the label set / subquestions editor fail to parse expressions with ' " ' (a quotation mark). | ||||
Steps To Reproduce |
What should happens: What happens: | ||||
Additional Information | The parsing is done 'scripts/admin/subquestions.js' with the function 'quickaddlabels' | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 121121 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome 22.0.1229.79 | ||||
Database type & version | MySQL 5.5.24 | ||||
Server OS (if known) | Ubuntu 12.04 | ||||
Webserver software & version (if known) | Apache | ||||
PHP Version | 5.4.4-9 | ||||
Found exactly the reason of the bug: The parsing is right. value=" + value + " So, because the value have a ' " ', we get this as a result with the string ' a"a ' So we have: To fix this, the script need to escape the ' " '. The user can't use the special HTML escape character " ; to fix this because the ";" is used by the parsing to set label code. PS: The file is answer.js, not subquestions.js The quick and dirty fix: Line 614 of scripts/admin/answers.js : I hope I helped EDIT: I separed " and ; because if I join them together, the browser will show the " character. |
|
Hello Damian, thank you for the suggested fix. I see no general problem with it. You should also in general get a GitHub account and submit the fix(es) as a pull request. Please also have a look at out standard for Git commit messages: http://docs.limesurvey.org/Standard+for+Git+commit+messages&structure=LimeSurvey+development |
|
Any progress? |
|
Yes, but I'm busy this week like I said in the mailing list. The patch is done, I just need to commit it and do a correct pull request Sorry for being so late |
|
? |
|
Damien, this was almost two weeks ago. Can you give us a status, please? |
|
Sorry, I'm busy these days. I will attach the patch here tommorow but I think I won't have time until next week to do the pull. |
|
Related pull: https://github.com/LimeSurvey/LimeSurvey/pull/64 |
|
Sorry for the delay. Thank you very much for the patch. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=11681 |
|
New version released. |
|
LimeSurvey: master 62398f9f 2012-12-15 11:14
Details Diff |
Fixed issue 06946: "Quick-add" fail to parse expressions with ' " ' |
Affected Issues 06946 |
|
mod - scripts/admin/answers.js | Diff File | ||
LimeSurvey: master 1f62231a 2013-02-24 16:25 Details Diff |
Merge pull request #64 from MDamien/master Fixed issue 06946: "Quick-add" fail to parse expressions with ' " ' |
Affected Issues 06946 |
|
mod - scripts/admin/answers.js | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-11-24 10:34 | damien | New Issue | |
2012-11-24 11:01 | damien | Note Added: 22477 | |
2012-11-25 11:40 | damien | Note Edited: 22477 | |
2012-11-25 11:40 | damien | Note Edited: 22477 | |
2012-11-25 11:42 | damien | Note Edited: 22477 | |
2012-11-25 12:50 | damien | Issue Monitored: damien | |
2012-11-25 15:06 | Mazi | Assigned To | => c_schmitz |
2012-11-25 15:06 | Mazi | Status | new => assigned |
2012-11-25 19:59 | c_schmitz | Note Added: 22489 | |
2012-11-25 19:59 | c_schmitz | Assigned To | c_schmitz => damien |
2012-11-30 15:55 | c_schmitz | Note Added: 22748 | |
2012-11-30 17:35 | damien | Note Added: 22759 | |
2012-12-11 10:35 | c_schmitz | Note Added: 23108 | |
2012-12-13 10:29 | c_schmitz | Note Added: 23210 | |
2012-12-13 11:05 | damien | Note Added: 23211 | |
2013-01-21 09:10 | mdekker | Note Added: 23725 | |
2013-02-19 11:22 | c_schmitz | Assigned To | damien => c_schmitz |
2013-02-24 16:26 | c_schmitz | Assigned To | c_schmitz => damien |
2013-02-24 16:26 | c_schmitz | Note Added: 24226 | |
2013-02-24 16:26 | c_schmitz | Status | assigned => resolved |
2013-02-24 16:26 | c_schmitz | Fixed in Version | => 2.00+ |
2013-02-24 16:26 | c_schmitz | Resolution | open => fixed |
2013-02-24 16:26 |
|
Changeset attached | => LimeSurvey master 62398f9f |
2013-02-24 16:26 | c_schmitz | Changeset attached | => LimeSurvey master 1f62231a |
2013-02-24 16:26 | c_schmitz | Note Added: 24227 | |
2013-02-26 20:03 | c_schmitz | Note Added: 24413 | |
2013-02-26 20:03 | c_schmitz | Status | resolved => closed |
2019-11-01 17:25 | c_schmitz | Category | Survey design => Survey editing |
2021-08-04 18:27 | guest | Bug heat | 6 => 8 |