View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
06943 | Bug reports | Survey participants (Tokens) | public | 2012-11-23 12:35 | 2012-12-04 13:16 |
Reporter | rom | Assigned To | mdekker | ||
Priority | high | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.00+ | ||||
Fixed in Version | 2.00+ | ||||
Summary | 06943: Restoring a Token Table of an pre 2.x Survey results in MySQL Error | ||||
Description | Restoring a Token Table of an deactivated survey which has been created before the 2.00+ Update results in an empty token table. | ||||
Steps To Reproduce | We had multiple EXPIRED Surveys in Limesurvey v1.91+ Build 10746. Each of these Surveys had a Token Table with 7 additional Attribute Fields. We just upgraded to v2.00+ Build 121121 in a Test Environment. Once we deactivate one of our expired Surveys, we get the usual warning message, that the tokens table has been renamed to {{old_tokens_45688_20121123122124}} Once we try to restore the token table (Survey = still deactivated) by clicking on the Token Management Button we SOMETIMES get an SQL Error Message:Internal Server Error
| ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 121121 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | MySQL v5 | ||||
Server OS (if known) | Linux | ||||
Webserver software & version (if known) | Apache | ||||
PHP Version | 5.3 | ||||
In general we do not support the restoration of old survey or token tables from previous versions. They are completely unlinked from the system and in general are not updated. |
|
Ich verstehe das dies auf alte Survey/Token-Tabellen zutrifft welche zum Zeitpunkt des Updates 1.90->2.00 bereits deaktiviert waren (old_tokens_xxxx). Die hier angesprochenen Surveys/Tokens waren aber noch AKTIV, die Umfragen sind lediglich ausgelaufen (expired). Sollte in dem Fall bei einem Update nicht die Token Tabelle auf den neusten Stand angehoben werden? |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10442 |
|
@rom: you can try to replace your tokens.php with the one from the changeset or edit the file manually. please report back if this fixed your problem |
|
Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10443 |
|
Feel free to reopen if the problem still exists after this fix |
|
@mdekker: I replaced the tokens and the survey_links file, and did not get the SQL Error again. (4 tries) But still getting the same result as before: The tokens table is empty afterwards. I attached a video file for better explanation. Also, please note: That error DOES NOT occur if I manually delete every token (since you guys removed the "empty token table" option) and replace them with dummy entries. The entries in the video are not dummy entries, they are the old ones. I just replaced the real names with a "test" string. |
|
it looks like the tokens are there, but not showing because of some illegal join condition. I will check on that. In the meantime, can you verify for me that in the table the records are present using a tool like phpmyadmin or similar? |
|
I tried again but am not able to reproduce when i delete the extra fields from the token table i can get the sql error you had but that is fixed now and the missing fields are created. Following that I always see the right numbers and the tokens. Maybe something else has changed that fixed this from happening. There has been one other commit to the tokens.php file. |
|
I updated my tokens.php file to the one from 24.11.2012 Still the same issue. Checked with phpmyadmin, and the table is there, and has content. But I finally got it: I digged through the content of the token tables as the problem did not occur with dummy entries, and just figured out the differences between the dummy entries and my old ones. Once I set the "completed" field from a single entry to a date - e.g. "2011-11-01 10:20" instead of "N", the whole table is not displayed in the backend. I guess this will help you a lot. |
|
Thanks, will have a look later! Are the fields in the old table empty or NULL? |
|
No, the old table also is set to a Timestamp like "2011-11-01 10:20" in the completed column. Maybe the Token Management uses some other SQL commands to display the Token Table once the survey is deactivated as opposed to when it is activated or expired. That could even make a bit of sense from a specific point of view, as a deactivated suvey may not contain tokens with a completed status, instead it should only contain incomplete tokens. |
|
Your survey is deactivated... got that after reading a thousand times and breaking my head why it works for me ;-) I'm fixing it right now. Thank you for being precise and persistent, finally we got it! Will commit the fix soon. |
|
Thanks for fixing it (& the warm words ;)) |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10509 |
|
Feel free to reopen if the issue still exists. (is not in release 121127) |
|
LimeSurvey 2.0+ build 121204 released. |
|
LimeSurvey: master 8f924023 2012-11-23 16:54 Details Diff |
Fixed 06943: Restoring a Token Table of an pre 2.x Survey results in MySQL Error |
Affected Issues 06943 |
|
mod - application/controllers/admin/tokens.php | Diff File | ||
mod - application/models/Survey_links.php | Diff File | ||
LimeSurvey: 2.1 d120ff10 2012-11-23 16:58 Details Diff |
Fixed 06943: Restoring a Token Table of an pre 2.x Survey results in MySQL Error |
Affected Issues 06943 |
|
mod - application/controllers/admin/tokens.php | Diff File | ||
mod - application/models/Survey_links.php | Diff File | ||
LimeSurvey: master 54a8af98 2012-11-24 11:43 Details Diff |
dev: cosmetic changes (include prefix in table name display) |
Affected Issues 06943 |
|
mod - application/controllers/admin/tokens.php | Diff File | ||
LimeSurvey: master bb915051 2012-11-27 13:42 Details Diff |
Fixed 06943: Restoring a Token Table of an pre 2.x Survey results in MySQL Error dev: real change is only check for related record when survey is active, other is cleanup / optimization |
Affected Issues 06943 |
|
mod - application/controllers/admin/tokens.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-11-23 12:35 | rom | New Issue | |
2012-11-23 15:09 | c_schmitz | Assigned To | => c_schmitz |
2012-11-23 15:09 | c_schmitz | Status | new => assigned |
2012-11-23 15:12 | c_schmitz | Note Added: 22445 | |
2012-11-23 15:12 | c_schmitz | Status | assigned => closed |
2012-11-23 15:12 | c_schmitz | Resolution | open => won't fix |
2012-11-23 15:20 | rom | Note Added: 22450 | |
2012-11-23 15:20 | rom | Status | closed => feedback |
2012-11-23 15:20 | rom | Resolution | won't fix => reopened |
2012-11-23 16:46 | mdekker | Assigned To | c_schmitz => mdekker |
2012-11-23 16:46 | mdekker | Status | feedback => assigned |
2012-11-23 16:55 | mdekker | Changeset attached | => LimeSurvey master 8f924023 |
2012-11-23 16:55 | mdekker | Note Added: 22451 | |
2012-11-23 16:56 | mdekker | Note Added: 22452 | |
2012-11-23 16:58 | mdekker | Changeset attached | => LimeSurvey 2.1 d120ff10 |
2012-11-23 16:58 | mdekker | Note Added: 22453 | |
2012-11-23 17:21 | mdekker | Note Added: 22458 | |
2012-11-23 17:21 | mdekker | Status | assigned => resolved |
2012-11-23 17:21 | mdekker | Fixed in Version | => 2.00+ |
2012-11-23 17:21 | mdekker | Resolution | reopened => fixed |
2012-11-23 17:23 | rom | File Added: 2012-11-23 17h20_43.mp4 | |
2012-11-23 17:27 | rom | Note Added: 22460 | |
2012-11-23 17:27 | rom | Status | resolved => feedback |
2012-11-23 17:27 | rom | Resolution | fixed => reopened |
2012-11-23 17:29 | rom | Note Edited: 22460 | |
2012-11-24 11:19 | mdekker | Note Added: 22478 | |
2012-11-24 11:54 | mdekker | Changeset attached | => LimeSurvey master 54a8af98 |
2012-11-24 11:55 | mdekker | Note Added: 22479 | |
2012-11-26 14:53 | rom | Note Added: 22541 | |
2012-11-26 14:53 | rom | Status | feedback => assigned |
2012-11-26 19:34 | mdekker | Note Added: 22549 | |
2012-11-27 11:17 | rom | Note Added: 22602 | |
2012-11-27 13:34 | mdekker | Note Added: 22603 | |
2012-11-27 13:42 | rom | Note Added: 22604 | |
2012-11-27 13:42 | mdekker | Changeset attached | => LimeSurvey master bb915051 |
2012-11-27 13:42 | mdekker | Note Added: 22605 | |
2012-11-28 13:59 | mdekker | Note Added: 22620 | |
2012-11-28 13:59 | mdekker | Status | assigned => resolved |
2012-11-28 13:59 | mdekker | Resolution | reopened => fixed |
2012-12-04 13:16 | c_schmitz | Note Added: 22876 | |
2012-12-04 13:16 | c_schmitz | Status | resolved => closed |
2016-12-08 10:39 | c_schmitz | Category | Tokens => Survey participants (Tokens) |