I should have added that getQuestionAttributeValues is called by /application/helpers/admin/statistics_helper.php around line 2848:
$aattr = getQuestionAttributeValues($qqid, substr($rt, 0, 1));

the question id (qqid) is derrived from the full question id ie 997138X18X3391 which is passed into the $rt parameter in the buildOutputList function. I'm wondering if somewhere in the function it should try and determine if the question has a parent and if so, pass the parent id to getQuestionAttributeValues instead?

I believe I have a fix but would appreciate someone checking it, particularly the question types, it seems to work OK for me. Fix follows:

change \application\helpers\admin\statistics_helper.php around line 2849 from:

$aattr = getQuestionAttributeValues($qqid, substr($rt, 0, 1));

to:

    if (strpos("1ABCEFHR:;", $outputs['qtype']) === false) {
                $tmpqqid = $qqid;
            } else {
                $tmpqqid=substr($qqid, 0, strlen($qqid)-1);
            }

$aattr = getQuestionAttributeValues($tmpqqid, substr($rt, 0, 1));

Slight amendment but still not a final fix ...
this fix is fine until you have more than 9 sub questions!

    if ($outputs['qtype'] == "R") {
                $tmpqqid=substr($qqid, 0, strpos($qqid, "-")-1);
            } elseif (strpos("1ABCEFH:;", $outputs['qtype']) === false) {
                $tmpqqid = $qqid;
            } else {
                $tmpqqid=substr($qqid, 0, strlen($qqid)-1);
            }
$aattr = getQuestionAttributeValues($tmpqqid, substr($rt, 0, 1));

A much better and hopefully, final fix:

change \application\helpers\admin\statistics_helper.php as follows:

Add at line 562:

$qqid = "";

Line 1541 change from:

    return array("alist"=>$alist, "qtitle"=>$qtitle, "qquestion"=>$qquestion, "qtype"=>$qtype, "statisticsoutput"=>$statisticsoutput);

to:

    return array("alist"=>$alist, "qtitle"=>$qtitle, "qquestion"=>$qquestion, "qtype"=>$qtype, "statisticsoutput"=>$statisticsoutput, "parentqid"=>$qqid);

Line 2849 change from:

    $aattr = getQuestionAttributeValues($qqid, substr($rt, 0, 1));

to:

$aattr = getQuestionAttributeValues($outputs['parentqid'], substr($rt, 0, 1));

Your final fix will break the output for non-array question types.

They seem to work OK for me?

parentqid will always be the Question ID or Parent Question ID where the question doesn't have children

Carsten,

I've been using this fix with statistics on a live and dev surveys and all looks ok to me, I've also tested on the latest build '121121' and all seems OK ... I'm not sure why you think it will break non-array Q types?

Hello pfpDave,

you are right, seems to work fine - sorry for the false assumption.
For us to review a patch like this alot quicker it would be great if you can do gitHub pull-requests. That makes it alot easier :).

Sounds good, I'll read up on how to do that and will register with Github.

Cheers

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10615

Thank you!

Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10626

LimeSurvey 2.0+ build 121204 released.