View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
06919 | Bug reports | Survey editing | public | 2012-11-21 18:03 | 2012-12-04 13:16 |
Reporter | pfpDave | Assigned To | tpartner | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.00+ | ||||
Summary | 06919: Save as label set from within survey doesn't work in IE | ||||
Description | When clicking 'Save as Label set' within a survey array question, the label set is created with empty options. This but is present in IE 8 and IE8 Compatibility view (IE7 mode) but not Firefox 16.0.2 | ||||
Steps To Reproduce |
| ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 121115 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | IE8 | ||||
Database type & version | SQL Express 2012 | ||||
Server OS (if known) | Server 2008 | ||||
Webserver software & version (if known) | IIS 7 | ||||
PHP Version | 5.4.8 | ||||
Tony, I bet this is a IE specific issue because of some not properly closed array or something where FF is more lenient about these things. Do you care to take a look? |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10471 |
|
Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10472 |
|
The JS substr function doesn't work in IE < 9 when using a negative start value (subquestions.js ~ 707) so I added a global compatibility fix. |
|
This has almost fixed the issue for me but: In an Array question, if I select Save as Label set on a set of subquestions I get the same problem. Tested on Version 2.00+ Build 121121 |
|
New 2.00+ build released. |
|
Hi, Was this one closed in error or do I need to re-log the issue? As per my last comment the issue isn't quite fully fixed. Many thanks |
|
pfpDave, have you updated to the latest release? |
|
I have and the functionality is as previously stated, ie: In an Array question, if I select Save as Label set on a set of subquestions I get the same problem. Tested (again) on Build 121127 |
|
I cannot reproduce the problem since my fix in IE7/8/9. Carsten, can you? |
|
I've re-tested and it appears that the issue only occurs when trying to save sub-questions AND when the survey is active. I'm also experiencing IE8 switching into compatibility mode quite a bit now for some reason and if I try and quick add a set of options, before they save it loses the data and switches to compatibility mode ... should I log this as a seperate bug? |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10531 |
|
Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10532 |
|
pfpDave, thanks for the extensive testing. The problem with activated surveys is now fixed too. Please open another bug for the Compatibility view problem if you feel it's warranted. |
|
This now works for me, many thanks. I have however found another bug with the width of the list box when selecting save as existing set but I'll log that as another bug! :-) |
|
LimeSurvey 2.0+ build 121204 released. |
|
LimeSurvey: master 0bb730c4 2012-11-24 17:22 Details Diff |
Fixed issue 06919: Save as label set from within survey doesn't work in IE Dev Added a fix for broken substr function with negative start value (in older IE) |
Affected Issues 06919 |
|
mod - scripts/admin/admin_core.js | Diff File | ||
LimeSurvey: 2.1 1b7c6938 2012-11-24 17:22 Details Diff |
Fixed issue 06919: Save as label set from within survey doesn't work in IE Dev Added a fix for broken substr function with negative start value (in older IE) |
Affected Issues 06919 |
|
mod - scripts/admin/admin_core.js | Diff File | ||
LimeSurvey: master af660349 2012-11-28 19:13 Details Diff |
Fixed issue 06919: Save as label set from within survey doesn't work in IE Dev Handle un-editable subquestion codes when survey is activated |
Affected Issues 06919 |
|
mod - scripts/admin/subquestions.js | Diff File | ||
LimeSurvey: 2.1 82bc429b 2012-11-28 19:14 Details Diff |
Fixed issue 06919: Save as label set from within survey doesn't work in IE Dev Handle un-editable subquestion codes when survey is activated |
Affected Issues 06919 |
|
mod - scripts/admin/subquestions.js | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-11-21 18:03 | pfpDave | New Issue | |
2012-11-22 23:19 | c_schmitz | Assigned To | => c_schmitz |
2012-11-22 23:19 | c_schmitz | Status | new => assigned |
2012-11-22 23:19 | c_schmitz | Assigned To | c_schmitz => tpartner |
2012-11-22 23:20 | c_schmitz | Note Added: 22438 | |
2012-11-24 17:22 | tpartner | Changeset attached | => LimeSurvey master 0bb730c4 |
2012-11-24 17:22 | tpartner | Note Added: 22480 | |
2012-11-24 17:22 | tpartner | Resolution | open => fixed |
2012-11-24 17:23 | tpartner | Changeset attached | => LimeSurvey 2.1 1b7c6938 |
2012-11-24 17:23 | tpartner | Note Added: 22481 | |
2012-11-24 17:27 | tpartner | Note Added: 22482 | |
2012-11-24 17:27 | tpartner | Status | assigned => resolved |
2012-11-26 11:07 | pfpDave | Note Added: 22513 | |
2012-11-27 06:11 | c_schmitz | Note Added: 22573 | |
2012-11-27 06:11 | c_schmitz | Status | resolved => closed |
2012-11-27 15:13 | pfpDave | Note Added: 22607 | |
2012-11-27 15:13 | pfpDave | Status | closed => feedback |
2012-11-27 15:13 | pfpDave | Resolution | fixed => reopened |
2012-11-27 16:01 | tpartner | Note Added: 22608 | |
2012-11-27 17:36 | pfpDave | Note Added: 22610 | |
2012-11-27 17:36 | pfpDave | Status | feedback => assigned |
2012-11-27 17:55 | tpartner | Assigned To | tpartner => c_schmitz |
2012-11-27 17:55 | tpartner | Note Added: 22611 | |
2012-11-28 16:32 | pfpDave | Note Added: 22639 | |
2012-11-28 17:34 | tpartner | Assigned To | c_schmitz => tpartner |
2012-11-28 19:13 | tpartner | Changeset attached | => LimeSurvey master af660349 |
2012-11-28 19:13 | tpartner | Note Added: 22648 | |
2012-11-28 19:15 | tpartner | Changeset attached | => LimeSurvey 2.1 82bc429b |
2012-11-28 19:15 | tpartner | Note Added: 22649 | |
2012-11-28 19:18 | tpartner | Note Added: 22650 | |
2012-11-28 19:18 | tpartner | Status | assigned => resolved |
2012-11-28 19:18 | tpartner | Resolution | reopened => fixed |
2012-11-29 10:01 | pfpDave | Note Added: 22670 | |
2012-12-04 13:16 | c_schmitz | Note Added: 22871 | |
2012-12-04 13:16 | c_schmitz | Status | resolved => closed |
2019-11-01 17:25 | c_schmitz | Category | Survey design => Survey editing |