View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
06775 | Bug reports | Survey participants (Tokens) | public | 2012-10-25 13:41 | 2012-10-25 15:36 |
Reporter | ems1985 | Assigned To | mdekker | ||
Priority | urgent | Severity | block | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.00+ | ||||
Fixed in Version | 2.00+ | ||||
Summary | 06775: If a closed survey with tokens is de-activated and then re-activated you cannot take the survey anymore | ||||
Description | Script attempts to read tokens from wrong table. | ||||
Steps To Reproduce | If you have a closed survey with tokens initialized, you have to enter the token when you start taking the survey. This works fine. | ||||
Additional Information | Error Message: Apparently the script tries to read from "lime_survey_XXXXXX.token" instead of "lime_tokens_XXXXXX.token" Note: This error only appears after de and re-activating the survey. It works fine on the first activation of a survey | ||||
Tags | No tags attached. | ||||
Attached Files | tk-uba8c8dc55aaih3.htm (19,738 bytes)
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <title>CDbException</title> <style type="text/css"> /*<![CDATA[*/ html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;} body{line-height:1;} ol,ul{list-style:none;} blockquote,q{quotes:none;} blockquote:before,blockquote:after,q:before,q:after{content:none;} :focus{outline:0;} ins{text-decoration:none;} del{text-decoration:line-through;} table{border-collapse:collapse;border-spacing:0;} body { font: normal 9pt "Verdana"; color: #000; background: #fff; } h1 { font: normal 18pt "Verdana"; color: #f00; margin-bottom: .5em; } h2 { font: normal 14pt "Verdana"; color: #800000; margin-bottom: .5em; } h3 { font: bold 11pt "Verdana"; } pre { font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace; } pre span.error { display: block; background: #fce3e3; } pre span.ln { color: #999; padding-right: 0.5em; border-right: 1px solid #ccc; } pre span.error-ln { font-weight: bold; } .container { margin: 1em 4em; } .version { color: gray; font-size: 8pt; border-top: 1px solid #aaa; padding-top: 1em; margin-bottom: 1em; } .message { color: #000; padding: 1em; font-size: 11pt; background: #f3f3f3; -webkit-border-radius: 10px; -moz-border-radius: 10px; border-radius: 10px; margin-bottom: 1em; line-height: 160%; } .source { margin-bottom: 1em; } .code pre { background-color: #ffe; margin: 0.5em 0; padding: 0.5em; line-height: 125%; border: 1px solid #eee; } .source .file { margin-bottom: 1em; font-weight: bold; } .traces { margin: 2em 0; } .trace { margin: 0.5em 0; padding: 0.5em; } .trace.app { border: 1px dashed #c00; } .trace .number { text-align: right; width: 2em; padding: 0.5em; } .trace .content { padding: 0.5em; } .trace .plus, .trace .minus { display:inline; vertical-align:middle; text-align:center; border:1px solid #000; color:#000; font-size:10px; line-height:10px; margin:0; padding:0 1px; width:10px; height:10px; } .trace.collapsed .minus, .trace.expanded .plus, .trace.collapsed pre { display: none; } .trace-file { cursor: pointer; padding: 0.2em; } .trace-file:hover { background: #f0ffff; } /*]]>*/ </style> </head> <body> <div class="container"> <h1>CDbException</h1> <p class="message"> CDbCommand failed to execute the SQL statement: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'lime_survey_21816.token' in 'where clause'. The SQL statement executed was: SELECT id,submitdate,lastpage FROM lime_survey_21816 WHERE lime_survey_21816.token='uba8c8dc55aaih3' order by id desc </p> <div class="source"> <p class="file">D:\web\xampp\htdocs\limesurvey\framework\db\CDbCommand.php(528)</p> <div class="code"><pre><span class="ln">516</span> return $result; <span class="ln">517</span> } <span class="ln">518</span> catch(Exception $e) <span class="ln">519</span> { <span class="ln">520</span> if($this->_connection->enableProfiling) <span class="ln">521</span> Yii::endProfile('system.db.CDbCommand.query('.$this->getText().$par.')','system.db.CDbCommand.query'); <span class="ln">522</span> $errorInfo = $e instanceof PDOException ? $e->errorInfo : null; <span class="ln">523</span> $message = $e->getMessage(); <span class="ln">524</span> Yii::log(Yii::t('yii','CDbCommand::{method}() failed: {error}. The SQL statement executed was: {sql}.', <span class="ln">525</span> array('{method}'=>$method, '{error}'=>$message, '{sql}'=>$this->getText().$par)),CLogger::LEVEL_ERROR,'system.db.CDbCommand'); <span class="ln">526</span> if(YII_DEBUG) <span class="ln">527</span> $message .= '. The SQL statement executed was: '.$this->getText().$par; <span class="error"><span class="ln error-ln">528</span> throw new CDbException(Yii::t('yii','CDbCommand failed to execute the SQL statement: {error}', </span><span class="ln">529</span> array('{error}'=>$message)),(int)$e->getCode(),$errorInfo); <span class="ln">530</span> } <span class="ln">531</span> } <span class="ln">532</span> <span class="ln">533</span> /** <span class="ln">534</span> * Builds a SQL SELECT statement from the given query specification. <span class="ln">535</span> * @param array $query the query specification in name-value pairs. The following <span class="ln">536</span> * query options are supported: {@link select}, {@link distinct}, {@link from}, <span class="ln">537</span> * {@link where}, {@link join}, {@link group}, {@link having}, {@link order}, <span class="ln">538</span> * {@link limit}, {@link offset} and {@link union}. <span class="ln">539</span> * @return string the SQL statement <span class="ln">540</span> * @since 1.1.6 </pre></div> </div> <div class="traces"> <h2>Stack Trace</h2> <table style="width:100%;"> <tbody><tr class="trace core collapsed"> <td class="number"> #0 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> D:\web\xampp\htdocs\limesurvey\framework\db\CDbCommand.php(408): <strong>CDbCommand</strong>-><strong>queryInternal</strong>("fetch", array(2), array()) </div> <div class="code"><pre><span class="ln">403</span> * @return mixed the first row (in terms of an array) of the query result, false if no result. <span class="ln">404</span> * @throws CException execution failed <span class="ln">405</span> */ <span class="ln">406</span> public function queryRow($fetchAssociative=true,$params=array()) <span class="ln">407</span> { <span class="error"><span class="ln error-ln">408</span> return $this->queryInternal('fetch',$fetchAssociative ? $this->_fetchMode : PDO::FETCH_NUM, $params); </span><span class="ln">409</span> } <span class="ln">410</span> <span class="ln">411</span> /** <span class="ln">412</span> * Executes the SQL statement and returns the value of the first column in the first row of data. <span class="ln">413</span> * This is a convenient method of {@link query} when only a single scalar </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #1 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> D:\web\xampp\htdocs\limesurvey\application\controllers\survey\index.php(607): <strong>CDbCommand</strong>-><strong>queryRow</strong>() </div> <div class="code"><pre><span class="ln">602</span> <span class="ln">603</span> if (!isset($_SESSION['survey_'.$surveyid]['srid']) && $thissurvey['anonymized'] == "N" && $thissurvey['active'] == "Y" && isset($token) && $token !='') <span class="ln">604</span> { <span class="ln">605</span> // load previous answers if any (dataentry with nosubmit) <span class="ln">606</span> $sQuery="SELECT id,submitdate,lastpage FROM {$thissurvey['tablename']} WHERE {$thissurvey['tablename']}.token='{$token}' order by id desc"; <span class="error"><span class="ln error-ln">607</span> $aRow = Yii::app()->db->createCommand($sQuery)->queryRow(); </span><span class="ln">608</span> if ( $aRow ) <span class="ln">609</span> { <span class="ln">610</span> if(($aRow['submitdate']=='' && $thissurvey['tokenanswerspersistence'] == 'Y' )|| ($aRow['submitdate']!='' && $thissurvey['alloweditaftercompletion'] == 'Y')) <span class="ln">611</span> { <span class="ln">612</span> $_SESSION['survey_'.$surveyid]['srid'] = $aRow['id']; </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #2 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> D:\web\xampp\htdocs\limesurvey\application\controllers\survey\index.php(18): <strong>index</strong>-><strong>action</strong>() </div> <div class="code"><pre><span class="ln">13</span> <span class="ln">14</span> class index extends CAction { <span class="ln">15</span> <span class="ln">16</span> public function run() <span class="ln">17</span> { <span class="error"><span class="ln error-ln">18</span> $this->action(); </span><span class="ln">19</span> } <span class="ln">20</span> <span class="ln">21</span> function action() <span class="ln">22</span> { <span class="ln">23</span> global $surveyid; </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #3 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> D:\web\xampp\htdocs\limesurvey\framework\web\actions\CAction.php(75): <strong>index</strong>-><strong>run</strong>() </div> <div class="code"><pre><span class="ln">70</span> { <span class="ln">71</span> $method=new ReflectionMethod($this, 'run'); <span class="ln">72</span> if($method->getNumberOfParameters()>0) <span class="ln">73</span> return $this->runWithParamsInternal($this, $method, $params); <span class="ln">74</span> else <span class="error"><span class="ln error-ln">75</span> return $this->run(); </span><span class="ln">76</span> } <span class="ln">77</span> <span class="ln">78</span> /** <span class="ln">79</span> * Executes a method of an object with the supplied named parameters. <span class="ln">80</span> * This method is internally used. </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #4 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> D:\web\xampp\htdocs\limesurvey\framework\web\CController.php(309): <strong>CAction</strong>-><strong>runWithParams</strong>(array("sid" => "21816", "token" => "uba8c8dc55aaih3")) </div> <div class="code"><pre><span class="ln">304</span> { <span class="ln">305</span> $priorAction=$this->_action; <span class="ln">306</span> $this->_action=$action; <span class="ln">307</span> if($this->beforeAction($action)) <span class="ln">308</span> { <span class="error"><span class="ln error-ln">309</span> if($action->runWithParams($this->getActionParams())===false) </span><span class="ln">310</span> $this->invalidActionParams($action); <span class="ln">311</span> else <span class="ln">312</span> $this->afterAction($action); <span class="ln">313</span> } <span class="ln">314</span> $this->_action=$priorAction; </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #5 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> D:\web\xampp\htdocs\limesurvey\framework\web\CController.php(287): <strong>CController</strong>-><strong>runAction</strong>(index) </div> <div class="code"><pre><span class="ln">282</span> * @see runAction <span class="ln">283</span> */ <span class="ln">284</span> public function runActionWithFilters($action,$filters) <span class="ln">285</span> { <span class="ln">286</span> if(empty($filters)) <span class="error"><span class="ln error-ln">287</span> $this->runAction($action); </span><span class="ln">288</span> else <span class="ln">289</span> { <span class="ln">290</span> $priorAction=$this->_action; <span class="ln">291</span> $this->_action=$action; <span class="ln">292</span> CFilterChain::create($this,$action,$filters)->run(); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #6 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> D:\web\xampp\htdocs\limesurvey\framework\web\CController.php(266): <strong>CController</strong>-><strong>runActionWithFilters</strong>(index, array()) </div> <div class="code"><pre><span class="ln">261</span> { <span class="ln">262</span> if(($parent=$this->getModule())===null) <span class="ln">263</span> $parent=Yii::app(); <span class="ln">264</span> if($parent->beforeControllerAction($this,$action)) <span class="ln">265</span> { <span class="error"><span class="ln error-ln">266</span> $this->runActionWithFilters($action,$this->filters()); </span><span class="ln">267</span> $parent->afterControllerAction($this,$action); <span class="ln">268</span> } <span class="ln">269</span> } <span class="ln">270</span> else <span class="ln">271</span> $this->missingAction($actionID); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #7 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> D:\web\xampp\htdocs\limesurvey\framework\web\CWebApplication.php(276): <strong>CController</strong>-><strong>run</strong>("index") </div> <div class="code"><pre><span class="ln">271</span> { <span class="ln">272</span> list($controller,$actionID)=$ca; <span class="ln">273</span> $oldController=$this->_controller; <span class="ln">274</span> $this->_controller=$controller; <span class="ln">275</span> $controller->init(); <span class="error"><span class="ln error-ln">276</span> $controller->run($actionID); </span><span class="ln">277</span> $this->_controller=$oldController; <span class="ln">278</span> } <span class="ln">279</span> else <span class="ln">280</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".', <span class="ln">281</span> array('{route}'=>$route===''?$this->defaultController:$route))); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #8 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> D:\web\xampp\htdocs\limesurvey\framework\web\CWebApplication.php(135): <strong>CWebApplication</strong>-><strong>runController</strong>("survey/index/sid/21816/token/uba8c8dc55aaih3") </div> <div class="code"><pre><span class="ln">130</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value) <span class="ln">131</span> $_GET[$name]=$value; <span class="ln">132</span> } <span class="ln">133</span> else <span class="ln">134</span> $route=$this->getUrlManager()->parseUrl($this->getRequest()); <span class="error"><span class="ln error-ln">135</span> $this->runController($route); </span><span class="ln">136</span> } <span class="ln">137</span> <span class="ln">138</span> /** <span class="ln">139</span> * Registers the core application components. <span class="ln">140</span> * This method overrides the parent implementation by registering additional core components. </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #9 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> D:\web\xampp\htdocs\limesurvey\framework\base\CApplication.php(162): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div> <div class="code"><pre><span class="ln">157</span> */ <span class="ln">158</span> public function run() <span class="ln">159</span> { <span class="ln">160</span> if($this->hasEventHandler('onBeginRequest')) <span class="ln">161</span> $this->onBeginRequest(new CEvent($this)); <span class="error"><span class="ln error-ln">162</span> $this->processRequest(); </span><span class="ln">163</span> if($this->hasEventHandler('onEndRequest')) <span class="ln">164</span> $this->onEndRequest(new CEvent($this)); <span class="ln">165</span> } <span class="ln">166</span> <span class="ln">167</span> /** </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #10 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> D:\web\xampp\htdocs\limesurvey\index.php(178): <strong>CApplication</strong>-><strong>run</strong>() </div> <div class="code"><pre><span class="ln">173</span> * <span class="ln">174</span> */ <span class="ln">175</span> require_once BASEPATH . 'yii' . EXT; <span class="ln">176</span> require_once APPPATH . 'core/LSYii_Application' . EXT; <span class="ln">177</span> <span class="error"><span class="ln error-ln">178</span> Yii::createApplication('LSYii_Application', APPPATH . 'config/config' . EXT)->run(); </span><span class="ln">179</span> <span class="ln">180</span> /* End of file index.php */ <span class="ln">181</span> /* Location: ./index.php */ </pre></div> </td> </tr> </tbody></table> </div> <div class="version"> 2012-10-25 14:25:04 Apache/2.2.21 (Win32) mod_ssl/2.2.21 OpenSSL/1.0.0e PHP/5.3.8 mod_perl/2.0.4 Perl/v5.10.1 <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.10 </div> </div> <script type="text/javascript"> /*<![CDATA[*/ var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)"); var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)"); var e = document.getElementsByTagName("div"); for(var j=0,len=e.length;j<len;j++){ if(traceReg.test(e[j].className)){ e[j].onclick = function(){ var trace = this.parentNode.parentNode; if(collapsedReg.test(trace.className)) trace.className = trace.className.replace("collapsed", "expanded"); else trace.className = trace.className.replace("expanded", "collapsed"); } } } /*]]>*/ </script> </body></html> | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 121024 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | MySQL 5.1.63 | ||||
Server OS (if known) | Debian | ||||
Webserver software & version (if known) | Apache/2.2.16 (Debian) | ||||
PHP Version | 5.3.3-7+squeeze14 | ||||
I've noticed the error doesn't occur if you FIRST re-initialize the token table and then re-activate the survey. See video here: http://youtu.be/yJGqA_aNxMs |
|
Please attach the particular survey as .lss file. Thank you. |
|
I don't see how that would help since a) its not limited to a specific survey (i could reproduce the error on different installations/surveys) and b) the tokens and token structure is not included in the .lss file. |
|
Well, I cannot reproduce that issue here, so it might help me to help you. Wouldn't you consider that a fair trade-off? |
|
It's shown in the video I posted. I tried it on two independent installations (one of them fresh). There must be one more multiple lines in the code where a script tries to access lime_survey_XXXXXX.token instead of lime_tokens_XXXXXX.token |
|
also maybe you can change the priority of the bug to a lower level, since there is a workaround for the error (reload token table BEFORE reactivating the survey) |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10022 |
|
LimeSurvey 2.00+ Build 121025 released - please update. |
|
LimeSurvey: master 44faacf3 2012-10-25 06:22:26 Details Diff |
Fixed 06775: If a closed survey with tokens is de-activated and then re-activated you cannot take the survey anymore dev: on activation we always need a token field if survey is not anonymous, the token field will only show in fieldmap when tokens are really activated |
Affected Issues 06775 |
|
mod - application/helpers/admin/activate_helper.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-10-25 13:41 | ems1985 | New Issue | |
2012-10-25 14:11 | ems1985 | Note Added: 21654 | |
2012-10-25 14:13 | c_schmitz | Note Added: 21655 | |
2012-10-25 14:13 | c_schmitz | Assigned To | => c_schmitz |
2012-10-25 14:13 | c_schmitz | Status | new => feedback |
2012-10-25 14:20 | ems1985 | Note Added: 21656 | |
2012-10-25 14:20 | ems1985 | Status | feedback => assigned |
2012-10-25 14:22 | c_schmitz | Note Added: 21657 | |
2012-10-25 14:29 | c_schmitz | File Added: tk-uba8c8dc55aaih3.htm | |
2012-10-25 14:38 | ems1985 | File Added: limesurvey_survey_527375 (2).lss | |
2012-10-25 14:48 | c_schmitz | Assigned To | c_schmitz => mdekker |
2012-10-25 14:51 | ems1985 | Note Added: 21661 | |
2012-10-25 15:01 | ems1985 | Note Added: 21664 | |
2012-10-25 15:22 | mdekker | Changeset attached | => LimeSurvey master 44faacf3 |
2012-10-25 15:22 | mdekker | Note Added: 21666 | |
2012-10-25 15:22 | mdekker | Resolution | open => fixed |
2012-10-25 15:34 | mdekker | Status | assigned => resolved |
2012-10-25 15:34 | mdekker | Fixed in Version | => 2.00+ |
2012-10-25 15:36 | c_schmitz | Note Added: 21669 | |
2012-10-25 15:36 | c_schmitz | Status | resolved => closed |
2016-12-08 10:39 | c_schmitz | Category | Tokens => Survey participants (Tokens) |