View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
06708Bug reportsSurvey participants (Tokens)public2012-10-17 10:39
Reporterhelper Assigned Toc_schmitz  
PrioritylowSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary06708: $register_errormsg not displaying at signup
Description

The global $register_errormsg is not showing up at register when errors occur (for example, missing email, bad answer for captcha).

Note: the errormsg appears in NON-token mode.

Steps To Reproduce

Activate a survey with the following:

basic template...

Anonymized responses? Responses to this survey are NOT anonymized. Cannot be changed
Allow editing responses after completion? Yes
Enable token-based response persistence? Yes
Allow public registration? Yes
Use HTML format for token emails? Yes
Send confirmation emails? Yes

Generate tokens at activation

Go to survey and attempt to sign up - do not answer the captcha or give a bad answer. No error appears to the end user.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)121014
I will donate to the project if issue is resolvedNo
BrowserIE8, FF, Chrome
Database type & versionmysqlnd 5.0.10 - 20111026
Server OS (if known)Windows 7
Webserver software & version (if known)Apache 2.4
PHP Version5.4

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2012-10-16 11:11

administrator   ~21351

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=9886

c_schmitz

c_schmitz

2012-10-16 12:23

administrator   ~21357

New 2.00+ Build 121016 released.

helper

helper

2012-10-16 13:49

reporter   ~21363

The fix induced another bug - did not know whether to open another bug or reopen this one.

Steps to reproduce:

  1. logon
  2. Click on the Tempate Editor icon - results in an error:

Undefined variable: surveyid

C:\xampp\htdocs\limesurvey\application\helpers\replacements_helper.php(771)

Suggestion for fix (replace line 771 with the following):

if (isset($surveyid) && isset($SESSION['survey'.$surveyid]) && isset($SESSION['survey'.$surveyid]['register_errormsg']))

helper

helper

2012-10-16 19:24

reporter   ~21383

The fix to replacements_helper.php is missing a istantiation of the global $register_errormsg. Appears that there is a cross over here in there is a change towards an array ($thissurvey[register_errormsg]) - the new logic:

if (isset($surveyid) && isset($_SESSION['survey_'.$surveyid]) && isset($_SESSION['survey_'.$surveyid]['register_errormsg']))
{
    $register_errormsg=$_SESSION['survey_'.$surveyid]['register_errormsg'];
    unset($_SESSION['survey_'.$surveyid]['register_errormsg']);
}

will not work with the $thissurvey[register_errormsg]. We need to either set a global for $register_errormsg or finish moving to the array.

c_schmitz

c_schmitz

2012-10-17 10:39

administrator   ~21399

That part is obsolete and will be removed.

Related Changesets

LimeSurvey: master 13ae7772

2012-10-16 02:10:58

c_schmitz

Details Diff
Fixed issue 06708: Error messages not displaying at survey signup when user did not completely/correctly fill out the form Affected Issues
06708
mod - application/controllers/RegisterController.php Diff File
mod - application/helpers/replacements_helper.php Diff File
mod - scripts/admin/questions.js Diff File

Issue History

Date Modified Username Field Change
2012-10-15 20:46 helper New Issue
2012-10-16 10:55 c_schmitz Assigned To => c_schmitz
2012-10-16 10:55 c_schmitz Status new => assigned
2012-10-16 11:11 c_schmitz Status assigned => resolved
2012-10-16 11:11 c_schmitz Fixed in Version => 2.00+
2012-10-16 11:11 c_schmitz Resolution open => fixed
2012-10-16 11:11 c_schmitz Changeset attached => LimeSurvey master 13ae7772
2012-10-16 11:11 c_schmitz Note Added: 21351
2012-10-16 12:23 c_schmitz Note Added: 21357
2012-10-16 12:23 c_schmitz Status resolved => closed
2012-10-16 13:49 helper Note Added: 21363
2012-10-16 13:49 helper Status closed => feedback
2012-10-16 13:49 helper Resolution fixed => reopened
2012-10-16 19:24 helper Note Added: 21383
2012-10-16 19:24 helper Status feedback => assigned
2012-10-17 10:39 c_schmitz Note Added: 21399
2012-10-17 10:39 c_schmitz Status assigned => closed
2012-10-17 10:39 c_schmitz Resolution reopened => fixed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)