View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
06650Bug reportsSurvey editingpublic2012-10-04 19:362012-10-19 16:21
ReporterDenisChenu Assigned Totpartner  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary06650: LimeReplacementField dialog is ugly in 2.00
Description

In 1.92, LimeReplacementField dialog is not very beautiful but you see all string and content take 100% of width.

In 2.00 : you don't see the footer texte and content don't take 100% of screen

Steps To Reproduce

Compare LimeReplacementField dialog from 1.92 and 2.0

Additional Information

For the width : we have a style="width:100%;" inline class for table.dialog
For the height: the end text is in td.cke_dialog_footer for 2.00, in another tr/td for 1.92.

TagsNo tags attached.
Attached Files
ckeditor-200.png (41,277 bytes)   
ckeditor-200.png (41,277 bytes)   
ckeditor-192.png (44,241 bytes)   
ckeditor-192.png (44,241 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)121004
I will donate to the project if issue is resolvedNo
BrowserFF14
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2012-10-04 21:00

administrator   ~21040

Tony, I think I remember that you fixed this in 1.92, didn't you? Can you have another go at it please?
DenisChenu

DenisChenu

2012-10-05 08:55

developer   ~21044

A bit of css in CK can do the trick but if we make update for CK : bug again ...

Maybe a patch for ck dialog ;)
tpartner

tpartner

2012-10-10 02:03

partner   ~21150

Given the AJAX source of the dialog content, I don't think we can make it future-proof by just modifying the dialog options in limereplacementfields.js.

How about creating our own skin? Something like "ls-office2003".
DenisChenu

DenisChenu

2012-10-10 11:08

developer   ~21154

Last edited: 2012-10-10 12:41

Tony : I can be great,(great idea)

and maybe after in dev :
ls-{$adminstyle} if possible after.

If we an put the skin in a var in HTML, then we can use own :
if (is_dir("third_party/skins/{$adminstyle}){
ckeditor_style = {$adminstyle}
}else{
ckeditor_style = ls_default
}
c_schmitz

c_schmitz

2012-10-10 12:30

administrator   ~21156

tpartner: You are the expert :-) If you think our own skin is the best option, please do.
tpartner

tpartner

2012-10-18 14:58

partner   ~21441

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=9930
tpartner

tpartner

2012-10-18 15:01

partner   ~21442

Denis, I have pushed the new skin to master, do you want it pushed to 2.1 so you can tackle the ls-{$adminstyle} bit?
DenisChenu

DenisChenu

2012-10-18 16:04

developer   ~21445

For 2.2 maybe ;)
c_schmitz

c_schmitz

2012-10-19 16:21

administrator   ~21484

New version 2.00+ Build 121019 released. Please update.

Related Changesets

LimeSurvey: master af74af69

2012-10-18 05:58:20

tpartner

Details Diff 		Fixed issue 06650: LimeReplacementField dialog is ugly in 2.00
Dev Added LimeSurvey editor skin		 Affected Issues
06650
mod - scripts/admin/ckeditor-config.js Diff File
mod - scripts/admin/limereplacementfields/dialogs/limereplacementfields.js Diff File
add - third_party/ckeditor/skins/ls-office2003/dialog.css Diff File
add - third_party/ckeditor/skins/ls-office2003/editor.css Diff File
add - third_party/ckeditor/skins/ls-office2003/icons.png Diff File
add - third_party/ckeditor/skins/ls-office2003/icons_rtl.png Diff File
add - third_party/ckeditor/skins/ls-office2003/images/dialog_sides.gif Diff File
add - third_party/ckeditor/skins/ls-office2003/images/dialog_sides.png Diff File
add - third_party/ckeditor/skins/ls-office2003/images/dialog_sides_rtl.png Diff File
add - third_party/ckeditor/skins/ls-office2003/images/mini.gif Diff File
add - third_party/ckeditor/skins/ls-office2003/images/noimage.png Diff File
add - third_party/ckeditor/skins/ls-office2003/images/sprites.png Diff File
add - third_party/ckeditor/skins/ls-office2003/images/sprites_ie6.png Diff File
add - third_party/ckeditor/skins/ls-office2003/skin.js Diff File
add - third_party/ckeditor/skins/ls-office2003/templates.css Diff File

Issue History

Date Modified Username Field Change
2012-10-04 19:36 DenisChenu New Issue
2012-10-04 19:36 DenisChenu File Added: ckeditor-200.png
2012-10-04 19:37 DenisChenu File Added: ckeditor-192.png
2012-10-04 20:59 c_schmitz Assigned To => tpartner
2012-10-04 20:59 c_schmitz Status new => assigned
2012-10-04 21:00 c_schmitz Note Added: 21040
2012-10-05 08:55 DenisChenu Note Added: 21044
2012-10-10 02:03 tpartner Note Added: 21150
2012-10-10 02:03 tpartner Status assigned => feedback
2012-10-10 02:04 tpartner Assigned To tpartner => c_schmitz
2012-10-10 02:04 tpartner Status feedback => assigned
2012-10-10 11:08 DenisChenu Note Added: 21154
2012-10-10 12:30 c_schmitz Note Added: 21156
2012-10-10 12:30 c_schmitz Assigned To c_schmitz => tpartner
2012-10-10 12:41 DenisChenu Note Edited: 21154
2012-10-18 14:58 tpartner Changeset attached => LimeSurvey master af74af69
2012-10-18 14:58 tpartner Note Added: 21441
2012-10-18 14:58 tpartner Resolution open => fixed
2012-10-18 14:59 tpartner Assigned To tpartner => DenisChenu
2012-10-18 15:01 tpartner Note Added: 21442
2012-10-18 16:04 DenisChenu Note Added: 21445
2012-10-18 16:04 DenisChenu Assigned To DenisChenu => tpartner
2012-10-18 16:06 DenisChenu Status assigned => resolved
2012-10-18 16:06 DenisChenu Fixed in Version => 2.00+
2012-10-19 16:21 c_schmitz Note Added: 21484
2012-10-19 16:21 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing