View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
06606Bug reportsOtherpublic2012-10-17 16:53
ReporterFred Assigned Toaniesshsethh  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary06606: Participant attribute grid - can only edit the first attribute
Description

If participants have multiple attributes, clicking on any of them opens the edit box for the first one.

Steps To Reproduce

Create a participant with several attribute.
List participants and expand attributes
Click on edit button for the second or later attribute
The top attribute (rather than the one you selected) enters edit mode.

Additional Information

In my test case there are 16 attributes, a mix of text box and drop down.

TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)120926
I will donate to the project if issue is resolvedNo
Browserfirefox
Database type & versionmysql 5.5.9
Server OS (if known)mac osx
Webserver software & version (if known)apache 2.2.17
PHP Version5.3.6

Users monitoring this issue

aniesshsethh

Activities

aniesshsethh

aniesshsethh

2012-10-15 18:23

reporter   ~21335

Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=9877

aniesshsethh

aniesshsethh

2012-10-15 18:25

reporter   ~21336

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=9878

pjbauer

pjbauer

2012-10-16 00:07

reporter   ~21340

Last edited: 2012-10-16 00:22

I loaded from Github and this feature still has problems.

When editing the participants table...

Attribute names are now numbers (I never assigned)

Attributes for the drop-down lists all show only one option ("undefined") rather than the entries entered in the attribute setup. (Saving a change after selecting from dropdown does not cause an error like text fields (see below) - but the change (to 'undefined') does not take.)

When saving a text attribute/field edit (onclick of submit) - I get a pop-up warning/error. This bug always existed in 2.0 even before the Github update...

Internal Server Error

CDbCommand failed to execute the SQL statement: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'attribute_id' cannot be null

An internal error occurred while the Web server was processing your request. Please contact the webmaster to report this problem.

Thank you.
2012-10-15 17:05:58

It looks like something is goofy with "attributes" - both for Participants and Tokens. It seems like the attribute name, value, and label is being confused in the code somewhere.

pjbauer

pjbauer

2012-10-16 00:48

reporter   ~21341

To followup - This worked ok (everything was fine - including the names that were shown as numbers and the drop down lists showing only undefined) AFTER I optimized all mySQL tables with overhead. Could be an index issue?

Fred

Fred

2012-10-16 16:03

reporter   ~21368

Tested this. The correct row now opens for edit... most of the time.

The last attribute in the grid is not editable. For example, if a participant has 10 attributes, you can't edit the 10th one. Pressing on the edit button or double clicking on the attribute value does nothing.

This happens regardless of whether the attribute is on the first page of attributes, 2nd page, or if you search for the attribute value and get an exact match (meaning there is only one attribute displayed, and since it is the LAST one it is not editable)

aniesshsethh

aniesshsethh

2012-10-16 16:13

reporter   ~21371

@pjbauer : probably

@fred : I tested it and it seems to work fine, can you please have a go once more on a clean install and let me know.thanks .

Fred

Fred

2012-10-16 16:23

reporter   ~21372

I have a clean install straight from github this morning. Browser cache is clean. It works on Firefox but not Chrome. My test case has 16 attributes, a mixture of text box and drop down.

pjbauer

pjbauer

2012-10-16 16:56

reporter   ~21375

It seems to be working ok now.

The only thing I'd like to see is that when the dropdown select box appears when you edit an attribute, that select box defaults to the actual value that is currently entered rather than "Select One". It can be confusing if you don't remember what the actual value was prior to editing.

aniesshsethh

aniesshsethh

2012-10-16 17:02

reporter   ~21377

@pjbauer : thanks, and about the feature , that I will try implement as soon as get some time.

@Fred, can you please attach your db dump in this issue, I just checked in chrome and it seems to working fine for me, maybe your db dump will help.thanks.

Fred

Fred

2012-10-17 15:49

reporter   ~21406

The problem with editing the last row is gone now. It must have been something cache-related. That jqgrid control has been plagued with problems as Jason can attest.

c_schmitz

c_schmitz

2012-10-17 16:52

administrator   ~21410

Always clear your browser cache after updates.

Related Changesets

LimeSurvey: 2.1 6c71f1af

2012-10-15 09:22:41

aniesshsethh

Details Diff
Fixed issue 06606: Participant attribute grid - can only edit the first attribute
Dev Working working fine now
Affected Issues
06606
mod - application/controllers/admin/participantsaction.php Diff File

LimeSurvey: master 3ee990fe

2012-10-15 09:22:41

aniesshsethh

Details Diff
Fixed issue 06606: Participant attribute grid - can only edit the first attribute
Dev Working working fine now
Affected Issues
06606
mod - application/controllers/admin/participantsaction.php Diff File

Issue History

Date Modified Username Field Change
2012-09-28 17:01 Fred New Issue
2012-09-29 13:30 c_schmitz Assigned To => jcleeland
2012-09-29 13:30 c_schmitz Status new => assigned
2012-10-14 13:42 Mazi Issue Monitored: aniesshsethh
2012-10-15 18:23 aniesshsethh Changeset attached => LimeSurvey 2.1 6c71f1af
2012-10-15 18:23 aniesshsethh Note Added: 21335
2012-10-15 18:23 aniesshsethh Assigned To jcleeland => aniesshsethh
2012-10-15 18:23 aniesshsethh Resolution open => fixed
2012-10-15 18:25 aniesshsethh Changeset attached => LimeSurvey master 3ee990fe
2012-10-15 18:25 aniesshsethh Note Added: 21336
2012-10-15 18:41 aniesshsethh Assigned To aniesshsethh => Mazi
2012-10-15 18:41 aniesshsethh Assigned To Mazi => aniesshsethh
2012-10-15 18:42 aniesshsethh Assigned To aniesshsethh => Mazi
2012-10-15 18:42 aniesshsethh Status assigned => feedback
2012-10-16 00:07 pjbauer Note Added: 21340
2012-10-16 00:08 pjbauer Note Edited: 21340
2012-10-16 00:22 pjbauer Note Edited: 21340
2012-10-16 00:48 pjbauer Note Added: 21341
2012-10-16 10:37 Mazi Assigned To Mazi => aniesshsethh
2012-10-16 10:37 Mazi Status feedback => assigned
2012-10-16 16:03 Fred Note Added: 21368
2012-10-16 16:13 aniesshsethh Note Added: 21371
2012-10-16 16:23 Fred Note Added: 21372
2012-10-16 16:56 pjbauer Note Added: 21375
2012-10-16 17:02 aniesshsethh Note Added: 21377
2012-10-17 15:49 Fred Note Added: 21406
2012-10-17 16:52 c_schmitz Note Added: 21410
2012-10-17 16:52 c_schmitz Status assigned => resolved
2012-10-17 16:52 c_schmitz Fixed in Version => 2.00+
2012-10-17 16:53 c_schmitz Status resolved => closed
2021-08-03 05:38 guest Bug heat 8 => 10