View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
06467Bug reportsSurvey takingpublic2012-09-20 14:12
ReporterTMSWhite Assigned ToDenisChenu  
PriorityhighSeveritypartial_block 
Status closedResolutionfixed 
Product Version1.92+ 
Fixed in Version1.92+ 
Summary06467: checkbox for 'other' missing for multiple choice
Description

This was removed as part of commit https://github.com/LimeSurvey/LimeSurvey/commit/7465610473987160e656f3512b8bb613fd75120f

We've had half a dozen complaints. It also disables other as an option in array_filter and array_filter_exclude, so I recommend reverting this change

Additional Information

I've confirmed that reverting this leads to the proper behavior.

TagsNo tags attached.
Attached Files
Bug heat4
Complete LimeSurvey version number (& build)120725
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql 5.3
Server OS (if known)Windows XP
Webserver software & version (if known)XAMPP
PHP Version5.3

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2012-08-11 17:18

developer   ~20357

Need a lot of reworking on $checkotherscript.

A lot of user have difficulty to use other on multi choice before this patch.

Solution : put on "display:hidden" in HTML or in template.css.

DenisChenu

DenisChenu

2012-08-11 17:36

developer   ~20358

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=9328

DenisChenu

DenisChenu

2012-08-11 17:43

developer   ~20359

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=9329

DenisChenu

DenisChenu

2012-08-12 14:05

developer   ~20361

Tom : Can you have a look at the last commit:

I tested with array_filter / array_filter_exclusio and relevance equation (other!="").

Seems OK : but can not test with IE9/IE10.

Denis

TMSWhite

TMSWhite

2012-08-14 00:46

reporter   ~20400

It still doesn't work correctly. Look at the attached survey - you will see two 'other' entries for each Multiple Choice and Multiple Choice with Comments type questions.

TMSWhite

TMSWhite

2012-08-14 00:57

reporter   ~20401

Actually, it works fine for 1.92. However, in the attached, 'other' is duplicated in Yii (there are two rows with name 'other' for each Multiple Choice question)

TMSWhite

TMSWhite

2012-08-14 00:58

reporter   ~20402

Yii implementation needs to be checked - there are duplicate 'other' rows

DenisChenu

DenisChenu

2012-08-14 01:28

developer   ~20403

I don't touch to Multiple Choice (with comment) question type .

Another issue ?

DenisChenu

DenisChenu

2012-08-14 01:38

developer   ~20404

It's another issue:
There are other sub-question in $ansresult array().

DenisChenu

DenisChenu

2012-08-14 01:47

developer   ~20406

It's OK with another Yii export.

See imported file

DenisChenu

DenisChenu

2012-08-14 10:05

developer   ~20415

Tom : when i look to sub question in G2/mc_t2, i have 6 sub question:

  • sq1
  • sq2
  • sq3
  • sq4
  • sq5
  • other

Maybe there are a "minor' bug : "can put other in subquestion/answer code (and break survey)"

TMSWhite

TMSWhite

2012-08-16 18:56

reporter   ~20486

The problem with multiple 'other' fields seems related to Excel file import, so closing this bug.

TMSWhite

TMSWhite

2012-08-16 18:57

reporter   ~20487

Also fixed in 2.0RC9

Related Changesets

LimeSurvey: master ba70c012

2012-08-11 08:33:25

DenisChenu

Details Diff
Fixed issue 06467 : checkbox for 'other' missing for multiple choice
Dev : revert http://git.io/frXDaw
Affected Issues
06467
mod - qanda.php Diff File

LimeSurvey: Yii e5323a97

2012-08-11 08:40:41

DenisChenu

Details Diff
Fixed issue 06467 checkbox for 'other' missing for multiple choice
Dev : add a class for visibilty:hidden
Affected Issues
06467
mod - application/helpers/qanda_helper.php Diff File
mod - templates/citronade/template.css Diff File

LimeSurvey: master 5cdcc081

2012-08-12 04:36:49

DenisChenu

Details Diff
Fixed issue: Multiple option with checkbox : Other can be checked at submit with empty value
Dev: add blur at onkeyup function : tested in IE6/FF14
Dev: close issue 06467 : checkbox for 'other' missing for multiple choice : updating javascript
Dev: use visibility:hidden in citronade
Affected Issues
06467
mod - qanda.php Diff File
mod - templates/citronade/template.css Diff File

LimeSurvey: Yii 50624c0b

2012-08-12 04:59:11

DenisChenu

Details Diff
Fixed issue: Multiple option with checkbox : Other can be checked at submit with empty value
Dev: add blur at onkeyup function : tested in IE6/FF14
Dev: close issue 06467 : checkbox for 'other' missing for multiple choice : updating javascript
Dev: use visibility:hidden in citronade and some other fix
Affected Issues
06467
mod - application/helpers/qanda_helper.php Diff File
mod - templates/citronade/template.css Diff File

Issue History

Date Modified Username Field Change
2012-08-11 16:39 TMSWhite New Issue
2012-08-11 17:07 DenisChenu Assigned To => DenisChenu
2012-08-11 17:07 DenisChenu Status new => assigned
2012-08-11 17:18 DenisChenu Note Added: 20357
2012-08-11 17:36 DenisChenu Changeset attached => LimeSurvey master ba70c012
2012-08-11 17:36 DenisChenu Note Added: 20358
2012-08-11 17:36 DenisChenu Resolution open => fixed
2012-08-11 17:43 DenisChenu Changeset attached => LimeSurvey Yii e5323a97
2012-08-11 17:43 DenisChenu Note Added: 20359
2012-08-12 13:40 DenisChenu Changeset attached => LimeSurvey master 5cdcc081
2012-08-12 14:02 DenisChenu Changeset attached => LimeSurvey Yii 50624c0b
2012-08-12 14:05 DenisChenu Note Added: 20361
2012-08-12 14:05 DenisChenu Status assigned => feedback
2012-08-13 18:40 DenisChenu Status feedback => resolved
2012-08-13 18:40 DenisChenu Fixed in Version => 1.92+
2012-08-14 00:46 TMSWhite Note Added: 20400
2012-08-14 00:46 TMSWhite File Added: limesurvey_survey_472317.lss
2012-08-14 00:57 TMSWhite Note Added: 20401
2012-08-14 00:58 TMSWhite Note Added: 20402
2012-08-14 00:58 TMSWhite Status resolved => new
2012-08-14 01:28 DenisChenu Note Added: 20403
2012-08-14 01:38 DenisChenu Note Added: 20404
2012-08-14 01:47 DenisChenu Note Added: 20406
2012-08-14 01:48 DenisChenu File Added: limesurvey_survey_932989.lss
2012-08-14 01:57 DenisChenu Assigned To DenisChenu => TMSWhite
2012-08-14 01:57 DenisChenu Status new => feedback
2012-08-14 10:05 DenisChenu Note Added: 20415
2012-08-16 18:56 TMSWhite Note Added: 20486
2012-08-16 18:56 TMSWhite Status feedback => assigned
2012-08-16 18:57 TMSWhite Note Added: 20487
2012-08-16 18:57 TMSWhite Status assigned => resolved
2012-08-16 18:57 TMSWhite Assigned To TMSWhite => DenisChenu
2012-09-20 14:12 c_schmitz Status resolved => closed