View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 12
IDProjectCategoryView StatusDate SubmittedLast Update
06300Bug reportsSurvey participants (Tokens)public2012-07-03 15:532012-07-18 16:33
Reporterjnpope Assigned ToDenisChenu  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version1.92+ 
Fixed in Version1.92+ 
Summary06300: Duplicate Token generation (Version 1.92+ Build 120425)
Description

Limesurvey appears to create/recycle token values after the first 32768.

We have a survey with 82,000 participants and we have identical tokens showing up two or three times (after 32768 unique tokens the system starts re-using the same tokens).

Steps To Reproduce

Generate a participant list of 80,000 with tokens.

Run SQL against the token table:
SELECT [token],COUNT(*) as total
from {insert_your_token_table_here}
GROUP BY token
ORDER BY total desc

Additional Information

The only reference I could find was:
-Fixed #3058: Only created 32768 tokens automatically - massive speedup for token generation - generates 50,000 tokens in 2 minutes now on a decent server (c_schmitz).

TagsNo tags attached.
Bug heat12
Complete LimeSurvey version number (& build)120425
I will donate to the project if issue is resolvedNo
BrowserFirefox
Database type & versionSQL Server 2008
Server OS (if known)Win2008R2 Server
Webserver software & version (if known)Apache 2
PHP Version5

Relationships

Relationship GraphDependency Graph
has duplicate 06301 closedDenisChenu Tokens are duplicated if not generated in one batch 

Users monitoring this issue

There are no users monitoring this issue.

Activities

lowprofile

lowprofile

2012-07-03 16:03

reporter   ~19598

here was my old issue, not sure if its related
http://bugs.limesurvey.org/view.php?id=4279
DenisChenu

DenisChenu

2012-07-03 17:42

developer   ~19599

Some other test with "Dummy token" : set "Token length:" to one (it's just to see the bug) and launch (for 100 token), tou are sure to have same token.

Denis
DenisChenu

DenisChenu

2012-07-04 20:27

developer   ~19615

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8896
DenisChenu

DenisChenu

2012-07-05 09:31

developer   ~19616

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8898
DenisChenu

DenisChenu

2012-07-05 10:49

developer   ~19619

Fix again : http://git.io/x2GLVg
DenisChenu

DenisChenu

2012-07-05 12:05

developer   ~19621

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8900
DenisChenu

DenisChenu

2012-07-05 12:37

developer   ~19623

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8901
c_schmitz

c_schmitz

2012-07-18 16:33

administrator   ~19785

1.92+ version released.

Related Changesets

LimeSurvey: master 9ea95743

2012-07-04 11:21:27

DenisChenu

Details Diff 		Fixed issue 06300 : Token can be duplicated under some condition
Dev: use in_array function, and not !isset
Dev: Fill the token table with existing token for dummytokens		 Affected Issues
06300
mod - admin/tokens.php Diff File

LimeSurvey: Yii 8e3bd1a2

2012-07-05 00:28:38

DenisChenu

Details Diff 		Fixed issue 06300 : Token can be duplicated under some condition (For Yii : dummy token)
Dev: Fill the token table with existing token for dummytokens		 Affected Issues
06300
mod - application/controllers/admin/tokens.php Diff File
mod - application/models/Tokens_dynamic.php Diff File

LimeSurvey: master 5afab728

2012-07-05 03:03:08

DenisChenu

Details Diff 		Dev : Fixed 06301,06300 AND old #3058
Dev : remove in_array test, put true for $existingtokens[$newtoken]		 Affected Issues
06300, 06301
mod - admin/tokens.php Diff File

LimeSurvey: Yii f11f8e58

2012-07-05 03:34:31

DenisChenu

Details Diff 		Dev : Fixed 06301,06300 AND old #3058
Dev : remove in_array test, put true for $existingtokens[$newtoken]
Dev tested with 1 000 000 token too		 Affected Issues
06300, 06301
mod - application/controllers/admin/tokens.php Diff File
mod - application/models/Tokens_dynamic.php Diff File

Issue History

Date Modified Username Field Change
2012-07-03 15:53 jnpope New Issue
2012-07-03 16:03 lowprofile Note Added: 19598
2012-07-03 17:42 DenisChenu Note Added: 19599
2012-07-04 20:14 DenisChenu Assigned To => DenisChenu
2012-07-04 20:14 DenisChenu Status new => assigned
2012-07-04 20:21 DenisChenu Relationship added has duplicate 06301
2012-07-04 20:27 DenisChenu Changeset attached => LimeSurvey master 9ea95743
2012-07-04 20:27 DenisChenu Note Added: 19615
2012-07-04 20:27 DenisChenu Resolution open => fixed
2012-07-05 09:31 DenisChenu Changeset attached => LimeSurvey Yii 8e3bd1a2
2012-07-05 09:31 DenisChenu Note Added: 19616
2012-07-05 09:31 DenisChenu Status assigned => resolved
2012-07-05 09:31 DenisChenu Fixed in Version => 1.92+
2012-07-05 10:49 DenisChenu Note Added: 19619
2012-07-05 12:05 DenisChenu Changeset attached => LimeSurvey master 5afab728
2012-07-05 12:05 DenisChenu Note Added: 19621
2012-07-05 12:37 DenisChenu Changeset attached => LimeSurvey Yii f11f8e58
2012-07-05 12:37 DenisChenu Note Added: 19623
2012-07-18 16:33 c_schmitz Note Added: 19785
2012-07-18 16:33 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)