View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
06183Bug reportsSurvey takingpublic2012-07-19 23:34
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00RC2 
Target Version2.00RC3Fixed in Version2.00RC5 
Summary06183: Ranking question unaccessible without javascript and touch screen
Description

Ranking question need optimisation for touch screen and without javascript

Steps To Reproduce

Try ranking question without javascript (and if the ranking question is mandatory: you can't answer next question)
Try ranking question with opera mini

Additional Information

I start work on here,

  • Use select/option without javascript
  • Use sortable with javascript
  • include jqury.ui.touch for touch screen.

Need some work

  • Accept html part for sortable (remove it for select/option)
  • min_answers need reworking.

Think we can put min and max answers in Expression Manager after.

TagsNo tags attached.
Attached Files
ranking.css (959 bytes)   
/* Drag-n-drop ranking default styles */

.dragDropTable .SortableTitle{display:block}
.dragDropTable .columns2{width:50%;float:left;margin:0;padding:0}
:dir(ltr) .dragDropTable .columns2{float:right}
.dragDropTable .clear{clear:both}

.dragDropTable {
    width: 100%;
}


.dragDropTable .dragDropChoices,
.dragDropTable .dragDropRanks {
	margin: 5px 0 0 0; 
	background: transparent none;
}

.dragDropTable .dragDropChoiceList,
.dragDropTable .dragDropRankList {
    margin: 0;
    padding: 0;
    padding-bottom:2em;
    list-style-type: none;
	border: 1px solid #CCCCCC;
	display: block; /* Force the li to full width */
}

.dragDropTable .dragDropChoiceList li,
.dragDropTable .dragDropRankList li {
    margin: 3px;
    *margin-left: -13px; /* IE7 and below */
    padding: 3px;
	min-height: 1.3em;
	height:auto !important;height: 1.3em; /* IE6 and below hack */
	font-weight: normal;
	cursor: move;
	display: block; /* Force the li to full width */
}

ranking.css (959 bytes)   
ranking.js (5,028 bytes)
survey_runtime.js (27,111 bytes)
qanda_helper.php (296,589 bytes)
Bug heat6
Complete LimeSurvey version number (& build)120608
I will donate to the project if issue is resolvedNo
BrowseriOs / TB without JS / Opera Mini touch
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2012-06-15 00:39

developer   ~19257

Hello Tom,

I need some advice or help for this.

Actually, the solution i propose work without Expression Manager or Conditions.

I test only without javascript sortable, update the select box don't update the relevance. Then I think we need some other var for relevance.

It's specific for ranking question ? When i look to another do_ function, it seem more simple.

Did i to change expression manager according to this new functionnality (maybe we can use same function than other select box, and the sortable lauch 'select.change' function ?
Or did i change qanda according to actual EM settings ?

Thank's of the advice.

Denis

TMSWhite

TMSWhite

2012-06-15 01:08

reporter   ~19258

EM requires JavaScript, including jQuery, so I don't personally see the point of trying to support a browser that doesn't support JavaScript.

I'm also afraid that I just don't have time to help with this issue. Sorry.

DenisChenu

DenisChenu

2012-06-15 11:15

developer   ~19270

See for EM javascript.

DenisChenu

DenisChenu

2012-07-02 17:02

developer   ~19596

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8884

c_schmitz

c_schmitz

2012-07-19 23:34

administrator   ~19825

2.00RC6 released.

Related Changesets

LimeSurvey: Yii 7a716c1d

2012-07-02 07:59:38

DenisChenu

Details Diff
Fixed issue 06183 : Ranking question unaccessible without javascript and touch screen
Dev : use jquery ui sortable
Dev tested with max answers from Expression manager, some condition on next question ...
Affected Issues
06183
mod - application/helpers/common_helper.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/helpers/qanda_helper.php Diff File
add - scripts/ranking.js Diff File
mod - scripts/survey_runtime.js Diff File
add - styles-public/ranking.css Diff File

Issue History

Date Modified Username Field Change
2012-06-08 19:38 DenisChenu New Issue
2012-06-08 19:38 DenisChenu Status new => assigned
2012-06-08 19:38 DenisChenu Assigned To => DenisChenu
2012-06-08 19:38 DenisChenu File Added: diff-ranking.diff
2012-06-08 19:39 DenisChenu Product Version 2.00RC3 => 2.00RC2
2012-06-15 00:32 DenisChenu File Deleted: diff-ranking.diff
2012-06-15 00:32 DenisChenu File Added: ranking.css
2012-06-15 00:33 DenisChenu File Added: ranking.js
2012-06-15 00:33 DenisChenu File Added: survey_runtime.js
2012-06-15 00:33 DenisChenu File Added: qanda_helper.php
2012-06-15 00:34 DenisChenu Assigned To DenisChenu => TMSWhite
2012-06-15 00:39 DenisChenu Note Added: 19257
2012-06-15 01:08 TMSWhite Note Added: 19258
2012-06-15 01:08 TMSWhite Assigned To TMSWhite =>
2012-06-15 11:13 DenisChenu Assigned To => DenisChenu
2012-06-15 11:15 DenisChenu Note Added: 19270
2012-07-02 17:02 DenisChenu Changeset attached => LimeSurvey Yii 7a716c1d
2012-07-02 17:02 DenisChenu Note Added: 19596
2012-07-02 17:02 DenisChenu Resolution open => fixed
2012-07-10 17:21 DenisChenu Status assigned => resolved
2012-07-10 17:21 DenisChenu Fixed in Version => 2.00RC5
2012-07-19 23:34 c_schmitz Note Added: 19825
2012-07-19 23:34 c_schmitz Status resolved => closed