View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
06094Bug reportsSurvey takingpublic2012-05-14 16:452012-05-17 10:27
ReporterDenisChenu Assigned ToTMSWhite  
PrioritynormalSeveritypartial_block 
Status closedResolutionno change required 
Product Version1.92+ 
Fixed in Version1.92+ 
Summary06094: Anonymity compromised
Description

With an anonymous survey.
Settings:
Save IP address? to YES
Save referrer URL? to YES
Anonymized responses? to YES

IP adress and ref URL are saved in DB. Anonymity is compromised.

Steps To Reproduce

Add a new survey,
settings:
Save IP address? to YES
Save referrer URL? to YES
Anonymized responses? to YES

Additional Information

Started the patch, just need some information in js.

Maybe something with Date stamp? too.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)120509
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionMysql 5.1.49
Server OS (if known)debian/linux
Webserver software & version (if known)apache
PHP VersionPHP Version 5.3.3-7

Users monitoring this issue

There are no users monitoring this issue.

Activities

TMSWhite

TMSWhite

2012-05-14 17:42

reporter   ~18739

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8438
TMSWhite

TMSWhite

2012-05-14 17:43

reporter   ~18740

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8439
DenisChenu

DenisChenu

2012-05-14 17:57

developer   ~18741

I work on javascript exclusion :)
TMSWhite

TMSWhite

2012-05-14 17:59

reporter   ~18742

Do you mean you're addressing this sub-issue:

"However, front-end can still show the mutually exclusive options of anonymized + save_ip + save_referrer_url"
DenisChenu

DenisChenu

2012-05-14 18:01

developer   ~18743

Actually, i work for an "automatic exclude when select 'anonimity to yes'.

But i remove alert for flashmessage, then take some times ...

I put: "Started the patch, just need some information in js.", i work have same patch ... but continue working on javascript information.
c_schmitz

c_schmitz

2012-05-14 19:33

administrator   ~18745

Sorry, but I am not sure that there is a bug here.

1.) The 'fix' changes the existing behaviour in LimeSurvey which was there for years. I don't understand how this suddenly became a problem? Besides that changing the behaviour in a stable release is out of the question.

2.) The 'Anonymized responses' refers exclusively to the connection between tokends and responses. It doesn't refer to IP addresses or referrer URLs since they don't necessarily identify a person and could be used for good reason for anonymous statistics.
TMSWhite

TMSWhite

2012-05-14 20:10

reporter   ~18746

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8444
DenisChenu

DenisChenu

2012-05-14 20:11

developer   ~18747

Last edited: 2012-05-14 20:13

OK.

I think we can't say it's an anonym survey if we save refURL and IP.

Sentence had to be changed, LS is used by a lot of user where anonymous is very important.

Maybe:
Anonimity : YES/NO
Link between token and answers : YES/NO

I saw this was like this, it's why i put in bug report :).

(js reverted: http://git.io/i7mWmg ;))
TMSWhite

TMSWhite

2012-05-14 20:15

reporter   ~18748

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8445
TMSWhite

TMSWhite

2012-05-14 20:19

reporter   ~18749

I also agree that a survey shouldn't really be called anonymous if one logs IP address and referral URL. However, authors who want to ensure the survey is truly anonymous will ensure the settings are right so that they don't log those things.
TMSWhite

TMSWhite

2012-05-14 20:29

reporter   ~18750

No change from original required - all changes were reverted
c_schmitz

c_schmitz

2012-05-17 10:27

administrator   ~18817

New 1.92+ version released.

Related Changesets

LimeSurvey: master 1a9fdcb6

2012-05-14 08:38:10

TMSWhite

Details Diff 		Fixed issue 06094: Anonymity compromised
Dev This fixes problem in survey-taking. However, front-end can still show the mutually exclusive options of anonymized + save_ip + save_referrer_url		 Affected Issues
06094
mod - classes/expressions/LimeExpressionManager.php Diff File

LimeSurvey: Yii 330cb594

2012-05-14 08:40:57

TMSWhite

Details Diff 		Fixed issue 06094: Anonymity compromised
Dev This fixes problem in survey-taking. However, front-end can still show the mutually exclusive options of anonymized + save_ip + save_referrer_url		 Affected Issues
06094
mod - application/helpers/expressions/em_manager_helper.php Diff File

LimeSurvey: master 09051181

2012-05-14 11:09:18

TMSWhite

Details Diff 		Fixed issue 06094: Anonymity compromised
Dev This is not a bug. Reverted commit https://github.com/LimeSurvey/LimeSurvey/commit/1a9fdcb67a6e39db73f154ebcf39b844b6b1dd3a		 Affected Issues
06094
mod - classes/expressions/LimeExpressionManager.php Diff File

LimeSurvey: Yii ff5af1cb

2012-05-14 11:13:43

TMSWhite

Details Diff 		Fixed issue 06094: Anonymity compromised
Dev This is not a bug. Reverted commit https://github.com/LimeSurvey/LimeSurvey/commit/330cb594da503b4be95057d7337ed40fde999cbf		 Affected Issues
06094
mod - application/helpers/expressions/em_manager_helper.php Diff File

Issue History

Date Modified Username Field Change
2012-05-14 16:45 DenisChenu New Issue
2012-05-14 16:45 DenisChenu Severity minor => partial_block
2012-05-14 17:21 TMSWhite Assigned To => TMSWhite
2012-05-14 17:21 TMSWhite Status new => assigned
2012-05-14 17:41 TMSWhite Summary Anonymity compromission => Anonymity compromised
2012-05-14 17:42 TMSWhite Changeset attached => LimeSurvey master 1a9fdcb6
2012-05-14 17:42 TMSWhite Note Added: 18739
2012-05-14 17:42 TMSWhite Resolution open => fixed
2012-05-14 17:43 TMSWhite Changeset attached => LimeSurvey Yii 330cb594
2012-05-14 17:43 TMSWhite Note Added: 18740
2012-05-14 17:43 TMSWhite Status assigned => resolved
2012-05-14 17:43 TMSWhite Fixed in Version => 1.92+
2012-05-14 17:57 DenisChenu Note Added: 18741
2012-05-14 17:59 TMSWhite Note Added: 18742
2012-05-14 18:01 DenisChenu Note Added: 18743
2012-05-14 19:33 c_schmitz Note Added: 18745
2012-05-14 19:34 c_schmitz Status resolved => feedback
2012-05-14 19:34 c_schmitz Resolution fixed => reopened
2012-05-14 20:10 TMSWhite Changeset attached => LimeSurvey master 09051181
2012-05-14 20:10 TMSWhite Note Added: 18746
2012-05-14 20:11 DenisChenu Note Added: 18747
2012-05-14 20:11 DenisChenu Status feedback => assigned
2012-05-14 20:13 DenisChenu Note Edited: 18747
2012-05-14 20:13 DenisChenu Note Edited: 18747
2012-05-14 20:15 TMSWhite Changeset attached => LimeSurvey Yii ff5af1cb
2012-05-14 20:15 TMSWhite Note Added: 18748
2012-05-14 20:19 TMSWhite Note Added: 18749
2012-05-14 20:28 TMSWhite Assigned To TMSWhite =>
2012-05-14 20:29 TMSWhite Note Added: 18750
2012-05-14 20:29 TMSWhite Status assigned => resolved
2012-05-14 20:29 TMSWhite Resolution reopened => no change required
2012-05-14 20:29 TMSWhite Assigned To => TMSWhite
2012-05-17 10:27 c_schmitz Note Added: 18817
2012-05-17 10:27 c_schmitz Status resolved => closed