View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
05901 | Bug reports | Survey taking | public | 2012-03-12 12:33 | 2012-03-15 01:32 |
Reporter | DenisChenu | Assigned To | TMSWhite | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.00a2 | ||||
Fixed in Version | 2.00a3 | ||||
Summary | 05901: Unable to movenext or submit a survey | ||||
Description | When launch a survey with f0419d8, each time try to click next button or submit, Have the alert javascripot box : And unable to move next | ||||
Steps To Reproduce | Launch a public survey, and try to click on next or submit. | ||||
Additional Information | Seems it's not F5 test. Deactivate it are OK, don't found when/where/why step incrementation are removed. | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 0000 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | FF10 ( without RefUrl) | ||||
Database type & version | Mysql 5.1.49 | ||||
Server OS (if known) | debian/linux | ||||
Webserver software & version (if known) | apache | ||||
PHP Version | PHP Version 5.3.3-7 | ||||
Thomas, can you please have a look at this? |
|
I also have a handful of commits applied to 1.92 that need to be ported to Yii too, which I figure should take priority (e.g. since there was a POSTkey-related change recently and I need to confirm it was accurately ported to Yii). My gut sense is that it probably relates to how Yii is using $_SESSION. In all $_SESSION[var] variables are all stored as $_SESSION['survey'_surveyid][var], or some variant, so some may not have been converted. Are we fully committed to that approach? Storing session for all potentially active surveys seems it might risk straining the memory limits on some machines. |
|
Hello, But Yii have some Class for session (http://www.yiiframework.com/doc/api/1.1/CHttpSession). Then sometimes it's Use Yii::app()->session['var'] seems the best solution ? But for $_SESSION['survey'_surveyid][var] : we can have same var with different value for different survey. example for langage: My lang is english, i go on a chinese/dutch : i set the langage in dutch / I go on a french/english survey : i set in english for this survey. I want see the chines/dutch in dutch after a while . I think for Participant panel, actually there are less situation like that. |
|
Denis- I personally don't see any value in using Yii:app()->session(). It doesn't implement any features that aren't better supported by $_SESSION, and it does not support nested arrays. I think we should just stick with $_SESSION unless there is truly some security issue or other reason why using Yii::app->session() might make sense. Also, LS already deals with cases when you want to switch language so that you get the right values. Most of the content in $_SESSION is not language specific, so if we replicated it, that would be a waste of memory. If we really want to hold all possible languages in memory, that could be considered, but I wouldn't do it by copying the entire createFieldMap $_SESSION object for each language. -Tom |
|
For [survey_$surveyid][var], you're right. I don't know when this was implemented. But actually, have a lot of bug in survey taking :). Yii::app()->session([var][var]) seem to work. I think if we use a framework, we can use some helper included in framework. |
|
fixed with commit https://github.com/LimeSurvey/LimeSurvey/commit/acf37e3ecbd6e73e33e58e95897bcbc5604babed |
|
Awesome, thank you! |
|
I think it's OK, but I haven't done complete testing - will do that later tonight. |
|
LimeSurvey: Yii acf37e3e 2012-03-13 15:27:09 Details Diff |
Fixed issue 05901: Unable to movenext or submit a survey |
Affected Issues 05901 |
|
mod - application/helpers/SurveyRuntimeHelper.php | Diff File | ||
mod - application/helpers/expressions/em_core_helper.php | Diff File | ||
mod - application/helpers/expressions/em_manager_helper.php | Diff File | ||
mod - application/helpers/frontend_helper.php | Diff File | ||
mod - application/helpers/qanda_helper.php | Diff File | ||
LimeSurvey: Yii 3d98bb94 2012-03-13 22:40:23 Details Diff |
Dev some additional fixes for issue 05901 |
Affected Issues 05901 |
|
mod - application/helpers/expressions/em_manager_helper.php | Diff File | ||
mod - application/helpers/qanda_helper.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-03-12 12:33 | DenisChenu | New Issue | |
2012-03-12 17:18 | c_schmitz | Assigned To | => TMSWhite |
2012-03-12 17:18 | c_schmitz | Status | new => assigned |
2012-03-12 17:20 | c_schmitz | Note Added: 17890 | |
2012-03-12 20:36 | TMSWhite | Note Added: 17900 | |
2012-03-12 23:29 | DenisChenu | Note Added: 17902 | |
2012-03-12 23:29 | DenisChenu | Note Edited: 17902 | |
2012-03-13 02:36 | TMSWhite | Note Added: 17904 | |
2012-03-13 03:18 | DenisChenu | Note Added: 17905 | |
2012-03-13 23:54 | TMSWhite | Note Added: 17909 | |
2012-03-13 23:54 | TMSWhite | Status | assigned => resolved |
2012-03-13 23:54 | TMSWhite | Fixed in Version | => 2.00a3 |
2012-03-13 23:54 | TMSWhite | Resolution | open => fixed |
2012-03-14 01:00 | c_schmitz | Note Added: 17910 | |
2012-03-14 02:22 | TMSWhite | Note Added: 17911 | |
2012-03-14 21:08 | TMSWhite | Changeset attached | => Import 2012-03-09 13:30:34 Yii 3d98bb94 |
2012-03-14 21:08 | TMSWhite | Changeset attached | => Import 2012-03-09 13:30:34 Yii acf37e3e |
2012-03-15 01:32 | c_schmitz | Status | resolved => closed |