Thomas, can you please have a look at this?
It looks like LimeExpressionManager::GetLastMoveResult returns 0 in SurveyRuntimeHelper Line 119 for some reason.

I also have a handful of commits applied to 1.92 that need to be ported to Yii too, which I figure should take priority (e.g. since there was a POSTkey-related change recently and I need to confirm it was accurately ported to Yii).

My gut sense is that it probably relates to how Yii is using $_SESSION. In all $_SESSION[var] variables are all stored as $_SESSION['survey'_surveyid][var], or some variant, so some may not have been converted.

Are we fully committed to that approach? Storing session for all potentially active surveys seems it might risk straining the memory limits on some machines.

Hello,
<quote>My gut sense is that it probably relates to how Yii is using $_SESSION. In all $_SESSION[var] variables are all stored as $_SESSION['survey'_surveyid][var], or some variant, so some may not have been converted.</quote>
Seems same think for langage.

But Yii have some Class for session (http://www.yiiframework.com/doc/api/1.1/CHttpSession). Then sometimes it's
Yii::app()->session and sometimes $_SESSION ...

Use Yii::app()->session['var'] seems the best solution ?

But for $_SESSION['survey'_surveyid][var] : we can have same var with different value for different survey.

example for langage: My lang is english, i go on a chinese/dutch : i set the langage in dutch / I go on a french/english survey : i set in english for this survey. I want see the chines/dutch in dutch after a while . I think for Participant panel, actually there are less situation like that.

Denis-

I personally don't see any value in using Yii:app()->session(). It doesn't implement any features that aren't better supported by $_SESSION, and it does not support nested arrays. I think we should just stick with $_SESSION unless there is truly some security issue or other reason why using Yii::app->session() might make sense.

Also, LS already deals with cases when you want to switch language so that you get the right values. Most of the content in $_SESSION is not language specific, so if we replicated it, that would be a waste of memory. If we really want to hold all possible languages in memory, that could be considered, but I wouldn't do it by copying the entire createFieldMap $_SESSION object for each language.

-Tom

For [survey_$surveyid][var], you're right. I don't know when this was implemented. But actually, have a lot of bug in survey taking :).

Yii::app()->session([var][var]) seem to work.

I think if we use a framework, we can use some helper included in framework.
The real question is : Did we need to use a framework ? But i think it's to late to have this question ;).

fixed with commit https://github.com/LimeSurvey/LimeSurvey/commit/acf37e3ecbd6e73e33e58e95897bcbc5604babed

Awesome, thank you!

I think it's OK, but I haven't done complete testing - will do that later tonight.