View Issue Details

This bug affects 1 person(s).
 2
IDProjectCategoryView StatusLast Update
05538Bug reportsSurvey takingpublic2012-03-14 21:08
Reporteruser11163Assigned Toc_schmitz  
PriorityhighSeveritypartial_block 
Status closedResolutionfixed 
Product Version1.91+ 
Fixed in Version1.91+ 
Summary05538: Further File Uploads Fail after First Upload Processed Following Next/Prev Question Group
Description

In a multiple File Upload question in a multiple question group survey, once an initial file has been processed, then the Next/Prev question group is selected, then further file uploads in the same question are not handled correctly.

I have marked it "high" as a fundamental aspect of the "File Upload" behavior is broken.

See 'Steps to Reproduce'

Steps To Reproduce

Create survey containing multiple Question Groups with one group per page. Create "File Upload" question allowing multiple file uploads on first group. In a survey, upload one file, "Return to Survey" then click Next/Prev. (This moves the uploaded file(s) from temp upload area to permanent files area.)

Click "Upload Files" again, upload a new file, and repeat "Return to Survey" then click Next/Prev.

Expected Behavior: Newly uploaded file should be moved to permanent files area.
Observed Behavior: Newly uploaded file is left in temporary upload area.

I believe this is due to a logic bug in save.php whereby only the first file is tested for presence in the temp area, instead of all files. In the above steps, the firs file is already moved, so future uploads are not processed correctly.

See uploaded 'save.php' for possible code fix.

TagsNo tags attached.
Attached Files
save.php (40,129 bytes)
Bug heat2
Complete LimeSurvey version number (& build)11232
I will donate to the project if issue is resolvedNo
BrowserChrome / Fiewfox
Database type & versionmysql 5.5.9
Server OS (if known)Windows 7
Webserver software & version (if known)apache 2.2.19
PHP Version5.3.6

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2011-10-28 18:12

administrator   ~16558

Thank you very much - the patch looks fine. Committed in rev. 11296

c_schmitz

c_schmitz

2011-11-08 18:56

administrator   ~16633

New version released.

Related Changesets

LimeSurvey: Yii 31c22f25

2011-10-28 11:12

c_schmitz


Details Diff
Fixed issue 05538: Further file uploads may fail after first upload processed following Next/Prev question group - patch by litotes

git-svn-id: file:///Users/Shitiz/Downloads/lssvn/source/limesurvey_ci@11297 b72ed6b6-b9f8-46b5-92b4-906544132732
Affected Issues
05538
mod - application/libraries/Save.php Diff File

Issue History

Date Modified Username Field Change
2011-10-27 21:57 user11163 New Issue
2011-10-27 21:57 user11163 File Added: save.php
2011-10-28 18:10 c_schmitz Assigned To => c_schmitz
2011-10-28 18:10 c_schmitz Status new => assigned
2011-10-28 18:12 c_schmitz Note Added: 16558
2011-10-28 18:12 c_schmitz Status assigned => resolved
2011-10-28 18:12 c_schmitz Fixed in Version => 1.91+
2011-10-28 18:12 c_schmitz Resolution open => fixed
2011-11-08 18:56 c_schmitz Note Added: 16633
2011-11-08 18:56 c_schmitz Status resolved => closed
2012-03-14 21:08 c_schmitz Changeset attached => Import 2012-03-09 13:30:34 Yii 31c22f25